Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2016

bernard.oflynn awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Aug 29 2016, 1:30 PM · Workboards (v3), Restricted Project
epriestley closed T11540: Write something that is technically a game for Ludum Dare 36 as Wontfix.

I had some family stuff come up and was only able to spend about three hours on this before Ludum Dare ended, and it never turned into anything playable. I got as far as letting you jump between systems and zoom into planetary bodies:

Aug 29 2016, 12:02 PM
epriestley added a comment to T11548: 500 Internal Server Error when trying to clone HG repo via https.

This is almost certainly T4369. I would expect that this repository is larger than 2GB?

Aug 29 2016, 10:58 AM · Bug Report
epriestley merged T11548: 500 Internal Server Error when trying to clone HG repo via https into T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Aug 29 2016, 10:57 AM · Diffusion (v3), Restricted Project
epriestley merged task T11548: 500 Internal Server Error when trying to clone HG repo via https into T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Aug 29 2016, 10:57 AM · Bug Report
epriestley closed T11549: sdefrgthzuioö as Invalid.
Aug 29 2016, 10:56 AM · Bug Report

Aug 27 2016

epriestley closed T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded as Resolved by committing Restricted Diffusion Commit.
Aug 27 2016, 4:11 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

Basically, if you want to see this implemented, please describe an attack scenario you're concerned about in detail.

Aug 27 2016, 2:17 PM · Security, Auth
epriestley added a comment to T11546: File Storage setup doc makes a hokey suggestion.

Yes, I wasn't aware that enable_post_data_reading existed when I wrote this.

Aug 27 2016, 2:02 PM · Feature Request, Documentation
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

This is technically easy for us to implement, I'd just like a real security justification for it. From the first link, the justification seems to be:

Aug 27 2016, 1:32 PM · Security, Auth
kristo.mario awarded T4900: Workboards updating in real time a Love token.
Aug 27 2016, 12:17 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T11540: Write something that is technically a game for Ludum Dare 36.

So far I have made the computer draw some circles:

Aug 27 2016, 3:27 AM
epriestley edited the content of Changelog.
Aug 27 2016, 12:44 AM
epriestley created 2016 Week 35 (Very Late August).
Aug 27 2016, 12:42 AM
chad awarded T11533: Upgrading: Changes to Default Homepage a Haypence token.
Aug 27 2016, 12:24 AM · NUX, Dashboards, Installing & Upgrading
epriestley updated the task description for T11533: Upgrading: Changes to Default Homepage.
Aug 27 2016, 12:17 AM · NUX, Dashboards, Installing & Upgrading

Aug 26 2016

epriestley triaged T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS as Low priority.
Aug 26 2016, 11:51 PM · Documentation, Setup
epriestley renamed T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS from Launching daemons kills the system to Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.
Aug 26 2016, 11:44 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

I'll retarget this to add a setup warning about micro instances, this isn't the first time they've done surprising things (T2727, T8204, T8210).

Aug 26 2016, 11:44 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

If you fiddle with the dropdown in the upper right you should be able to get historic data and maybe see if the graph went not-so-good around then. Doesn't seem implausible.

Aug 26 2016, 11:38 PM · Documentation, Setup
epriestley renamed T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment from Remarkup autocomplete for tasks to Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.
Aug 26 2016, 11:02 PM · Restricted Project, Remarkup, Feature Request
epriestley merged task T7138: Remarkup should have an "Link Wiki page" button with typeahead into T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.
Aug 26 2016, 11:00 PM · Remarkup
epriestley merged T7138: Remarkup should have an "Link Wiki page" button with typeahead into T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.
Aug 26 2016, 11:00 PM · Restricted Project, Remarkup, Feature Request
epriestley added a comment to T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.

If the task is frequently referenced, you can give it a Phurl and use ((super_cool_task)), as in ((php7)) and ((httpoxy)).

Aug 26 2016, 11:00 PM · Restricted Project, Remarkup, Feature Request
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

Here's the actual credit graph in the AWS web console, under the Monitoring tab (lower right):

Aug 26 2016, 10:55 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

One thing we could possibly do is try to hit the AWS meta-service during startup:

Aug 26 2016, 10:53 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

It's hard to say because workloads differ, but I'd steer away from the CPU credited "burstable" t2.* instances based on generally negative experiences with micros in the past.

Aug 26 2016, 10:43 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

In AWS, my understanding is that micro instances have CPU credits and their CPU is stopped or heavily throttled if you exceed the credit hours. Has the instance exhausted its CPU credits? I think there's a graph on the console, maybe in the "CloudWatch" tab or something like that? I don't actually have any micro instances up right now to check.

Aug 26 2016, 10:31 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

(Is your server an underclocked Raspberry Pi emulated on an Amiga?)

Aug 26 2016, 10:23 PM · Documentation, Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

Does /usr/bin/env php -v also print 5.6, versus 7?

Aug 26 2016, 10:01 PM · Documentation, Setup
epriestley added a comment to T11542: Make remarkup checklists interactive.

See some discussion in T3945.

Aug 26 2016, 6:56 PM · Remarkup, Feature Request
venky awarded T11540: Write something that is technically a game for Ludum Dare 36 a 100 token.
Aug 26 2016, 6:39 PM
epriestley moved T11541: Remove getIconURI() from PhabricatorApplication from Backlog to Basic on the Contributor Onboarding board.
Aug 26 2016, 5:45 PM · Contributor Onboarding, Infrastructure, Design
epriestley created T11541: Remove getIconURI() from PhabricatorApplication.
Aug 26 2016, 5:45 PM · Contributor Onboarding, Infrastructure, Design
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

D16460 is marked as fixing this, and we always send data via Files afterwards. This is different from the approach I'd outlined above (no mode where we continue to return text directly), but two additional considerations have arisen:

Aug 26 2016, 5:32 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a revision to T11524: Import-time diff generation fails for particular commits in cluster mode: Unknown Object (Differential Revision).
Aug 26 2016, 5:28 PM · Phacility, Clusters, Daemons, Diffusion
epriestley added a revision to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded: Unknown Object (Differential Revision).
Aug 26 2016, 5:28 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T11336: Provide a stable address range for Phacility outbound requests.

Yes, that's correct.

Aug 26 2016, 4:22 PM · Customer Impact
epriestley added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.

Oh! var_dump(...) or print_r(...) should send stuff to a big pink header on the page.

Aug 26 2016, 3:59 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley created T11540: Write something that is technically a game for Ludum Dare 36.
Aug 26 2016, 3:27 PM
epriestley created an object: C147: Ludum Dare 36.
Aug 26 2016, 3:19 PM
epriestley added a revision to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded: Unknown Object (Differential Revision).
Aug 26 2016, 3:14 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a revision to T11524: Import-time diff generation fails for particular commits in cluster mode: Unknown Object (Differential Revision).
Aug 26 2016, 3:14 PM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.

Ah, right -- I think those are both expected and that you're on the right track. You should be able to use $request->getStrList(...) instead of $request->getStr(...) to read the list, then head() to grab the first (item if it exists).

Aug 26 2016, 3:09 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley closed T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps as Resolved by committing Restricted Diffusion Commit.
Aug 26 2016, 2:39 PM · Diffusion
epriestley closed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured as Resolved by committing Restricted Diffusion Commit.
Aug 26 2016, 2:38 PM · Contributor Onboarding, Setup
epriestley added a comment to T11538: the conduit API is awkward to use when one must send arrays.

I'm happy to rewrite your script so it works, but we charge $1,500/hr for custom development (see Consulting) because time spent helping individual users with unique problems takes away from developing and improving Phabricator. Are you interested in this?

Aug 26 2016, 2:29 PM · Bug Report
epriestley closed T11538: the conduit API is awkward to use when one must send arrays as Invalid.

This is not a bug.

Aug 26 2016, 1:46 PM · Bug Report
epriestley added a revision to T11524: Import-time diff generation fails for particular commits in cluster mode: Unknown Object (Differential Revision).
Aug 26 2016, 12:36 PM · Phacility, Clusters, Daemons, Diffusion
epriestley added a revision to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps: Unknown Object (Differential Revision).
Aug 26 2016, 12:24 PM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

Introducing an epoch64 type ends up being pretty messy:

Aug 26 2016, 12:13 PM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

Perhaps a better solution is to introduce an epoch64 datatype and store these timestamps faithfully, since they're at least sort of possible to write and do have a relatively unambiguous meaning. Introducing a new type instead of changing the meaning of the existing epoch would let us accommodate this without requiring tons and tons of migrations or exposing us to a lot of weird fallout.

Aug 26 2016, 12:01 PM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.
$ git cat-file commit HEAD > message.original
$ nano message.original # Adjust timestamps to crazy values.
$ git hash-object -t commit --stdin -w < message.original
23c3584bd6030c4f8b9ad9ce5419d218990b75a5
$ git reset --hard 23c3584bd6030c4f8b9ad9ce5419d218990b75a5
HEAD is now at 23c3584 Time travel! Spooky!
$ git show
commit 23c3584bd6030c4f8b9ad9ce5419d218990b75a5
Author: epriestley <git@epriestley.com>
Date:   Mon Jul 22 06:20:00 48622 -0700
Aug 26 2016, 11:59 AM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

After some effort, I'm unable to figure out how to generate these commits using vanilla git. I can't figure out how get them with --date or GIT_COMMITTER_DATE to git commit: dates after 2100 are treated like the current date.

Aug 26 2016, 11:53 AM · Diffusion
epriestley created T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.
Aug 26 2016, 11:39 AM · Diffusion
epriestley moved T4369: Phabricator HTTP repository hosting has fairly severe scalability limits from Backlog to v3 on the Diffusion board.
Aug 26 2016, 11:10 AM · Diffusion (v3), Restricted Project
scott.horsley awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 26 2016, 3:32 AM · Workboards (v3), Restricted Project
epriestley added a comment to T11535: Make it possible for arc land to disable upstream branch tracking.

Why are you tracking branches you don't want to land onto?

Aug 26 2016, 1:28 AM · Arcanist, Restricted Project
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

The particular issue is that that the change removed a file containing the bytes ... 0xE5 0x76 .... The 0xE5 is probably an å in Latin 1.

Aug 26 2016, 1:25 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

I extracted the response body prior to encoding as a serialized()'d object so I can narrow down what's causing the encoding to fail and it looks reasonable, looking like it's almost certainly a UTF8 issue now.

Aug 26 2016, 1:12 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

Not too surprisingly, the response is empty. AphrontResponse->encodeJSONForHTTPResponse() uses json_encode() and does not detect UTF8-related encoding failures, so the chance that this is a UTF8 issue is pretty high. We should also probably fix that so fail earlier and more explicitly (and don't emit HTTP 200).

Aug 26 2016, 1:04 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

The next step I want to take is figuring out what the actual problematic response body looks like, but that's slightly tricky right now because there's no way to make Conduit calls from the CLI.

Aug 26 2016, 1:00 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

I want to avoid implementing things in Phabricator just because there's a low barrier to entry to ask us and we're responsive -- over time, this tends to punish us for being responsive by cluttering our codebase with cruft to work around weird decisions that other companies are making in their products.

Aug 26 2016, 12:47 AM · Feature Request

Aug 25 2016

epriestley added a comment to T11534: Repository clustering does not respect disabled bindings?.

From IRC, this might be a false positive / not the root cause since destroying the binding didn't fix the problem, but I can run through things locally.

Aug 25 2016, 11:51 PM · Almanac, Clusters
epriestley created T11534: Repository clustering does not respect disabled bindings?.
Aug 25 2016, 11:10 PM · Almanac, Clusters
epriestley added a revision to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured: Unknown Object (Differential Revision).
Aug 25 2016, 10:49 PM · Contributor Onboarding, Setup
epriestley claimed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I was ultimately able to reproduce this, but it took some work and the instructions above definitely weren't sufficeient:

Aug 25 2016, 10:38 PM · Contributor Onboarding, Setup
epriestley added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

Alright, let me see if I can get anywhere with this.

Aug 25 2016, 10:14 PM · Contributor Onboarding, Setup
epriestley added a subtask for T11533: Upgrading: Changes to Default Homepage: T5315: Remove the "welcome.html" configuration option when Dashboards is available.
Aug 25 2016, 7:05 PM · NUX, Dashboards, Installing & Upgrading
epriestley added a parent task for T5315: Remove the "welcome.html" configuration option when Dashboards is available: T11533: Upgrading: Changes to Default Homepage.
Aug 25 2016, 7:05 PM · Dashboards (v2)
epriestley created T11533: Upgrading: Changes to Default Homepage.
Aug 25 2016, 6:22 PM · NUX, Dashboards, Installing & Upgrading
epriestley moved T10679: When phurl.short-uri is configured, use it in the UI from Backlog to Basic on the Contributor Onboarding board.
Aug 25 2016, 5:11 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley reassigned T10679: When phurl.short-uri is configured, use it in the UI from lpriestley to jcox.

Phurl is a URL shortener. This is an amazing unique type of application which I personally invented in 2015.

Aug 25 2016, 5:10 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I've also never used seamless so I'm not sure how support looks in practice, but this isn't immediately reassuring:

Aug 25 2016, 5:00 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I think that only prevents referrer leaking -- it doesn't deal with the other issues in T4190#60441 (or request amplification attacks), right?

Aug 25 2016, 4:58 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

The vaguely related T5378 is also in the queue somewhere. It may not really intersect with this, but if we do end up trying to auto-embed any URI that ends in .jpg again it probably will. I'm not sure we should, but just a heads up for context.

Aug 25 2016, 4:29 PM · Contributor Onboarding, Remarkup
epriestley moved T4190: Rebuild remarkup image proxying from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
epriestley reassigned T4190: Rebuild remarkup image proxying from epriestley to jcox.

The general shape of what we're trying to do here is that when a user writes the URL of an image in a comment (e.g., http://funny.lol/silly-dog.jpg, perhaps with some magic *$!symbols$*!) it would be nice to just show the image. Today, they'd have to download and re-upload it, which is somewhat cumbersome.

Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
epriestley added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Contributor Onboarding.
Aug 25 2016, 3:30 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T10673: Convert Phurl to use EditEngine from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley reassigned T10673: Convert Phurl to use EditEngine from lpriestley to jcox.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10673: Convert Phurl to use EditEngine.

EditEngine is a slightly different way to build forms that look the same as other forms, introduced circa January 2016. Some applications have moved to it, while others have not yet. It seems pretty reasonable and stable, though, so we're in the process of moving everything over.

Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley moved T11532: Replace paste language selection dropdown with a typeahead from Backlog to Basic on the Contributor Onboarding board.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley assigned T11532: Replace paste language selection dropdown with a typeahead to jcox.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

First, let's sort of limit the direct damage this misconfiguration causes by changing this line in PhabricatorUserLog->initializeNewLog():

Aug 25 2016, 2:43 PM · Contributor Onboarding, Setup
epriestley renamed T11532: Replace paste language selection dropdown with a typeahead from Replace paste dropdown with a typeahead to Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:34 PM · Paste, Contributor Onboarding
epriestley added a project to T10681: Add Phurl Conduit API methods : Contributor Onboarding.
Aug 25 2016, 2:33 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley added a project to T10673: Convert Phurl to use EditEngine: Contributor Onboarding.
Aug 25 2016, 2:32 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

T7643#175911 has some discussion of this.

Aug 25 2016, 2:31 PM · Feature Request
epriestley added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

Is there a valid technical reason for Google to work like this?

Aug 25 2016, 2:25 PM · Feature Request
epriestley created T11532: Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:24 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Ah, nice! I'll write up some guidance on adding a setup check for this shortly.

Aug 25 2016, 2:22 PM · Contributor Onboarding, Setup
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

In the read/write case, it's too late once we hit a hook -- we need to be able to decide which cluster node to send the traffic to, and we need to know if it's a read or write request before we make that decision, since there may be a nearby read-only node and a distant read/write node. If we can examine the stream and make a determination that the request is read-only, we can freely pick a nearby read-only node.

Aug 25 2016, 4:42 AM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Today, we technically do not need to decode the protocol, but we will need to be able to distinguish between read and write requests to implement cluster read-only nodes (T10883) in the future and need to be able to rewrite the protocol to keep parity with fork-like/virtual-ref features that we plan to support in Git (T10691, T8092).

Aug 25 2016, 4:26 AM · Diffusion, Mercurial
epriestley closed T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close as Resolved.

The action is indistinguishable from an update from Herald's perspective. Herald runs on the state of the object, not changes to it, so "Changed file content" will just match whatever the diff changes.

Aug 25 2016, 1:06 AM · Bug Report

Aug 24 2016

epriestley closed T7492: Documentation for Paste as Wontfix.

No one actually seems confused by Paste. Obviously documentation "should" exist, but probably not worth keeping this task around since it has just been idle for more than a year. I suspect we'll write it as soon as someone runs into a problem that needs to be documented.

Aug 24 2016, 11:54 PM · Documentation, Paste
epriestley closed T7476: Add function_exists() guards to play nice together with illuminate/support (for working with eloquent, the laravel database layer) as Wontfix.

We haven't seen more interest in this in a long time, and I don't currently plan to make compatibility-focused changes to the stack.

Aug 24 2016, 11:53 PM
epriestley merged T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Tokens
epriestley added a comment to T7468: No way to disable web notifications for token awards.

I'm going to merge this into T10448, which discusses limitations and improvements to the mail tags system. This is an example of a cross-cutting tag ("No Application/System Settings") that isn't handled gracefully by the current system, but correcting this and other similar issues is a goal of future work.

Aug 24 2016, 11:51 PM · Tokens