Page MenuHomePhabricator
Feed Advanced Search

Apr 30 2016

epriestley merged T7516: Add git clone url to conduit repository.query into T10366: General support for multiple URIs for a repository.
Apr 30 2016, 12:21 AM · Diffusion (v3), Restricted Project, Feature Request
epriestley merged task T7516: Add git clone url to conduit repository.query into T10366: General support for multiple URIs for a repository.
Apr 30 2016, 12:21 AM · Restricted Project, Diffusion (v3), Conduit
epriestley added a comment to T7516: Add git clone url to conduit repository.query.

I'm going to merge this into T10366. After D15822, this information is available via diffusion.repository.search by asking for the uris attachment. Note that:

Apr 30 2016, 12:21 AM · Restricted Project, Diffusion (v3), Conduit
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 30 2016, 12:13 AM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a comment to T10905: Cannot triple-click to select task title in phabricator (due to icon in the title).

Try that one instead.

Apr 30 2016, 12:00 AM · Bug Report

Apr 29 2016

epriestley closed T10905: Cannot triple-click to select task title in phabricator (due to icon in the title) as Resolved by committing Restricted Diffusion Commit.
Apr 29 2016, 11:59 PM · Bug Report
epriestley added a revision to T10905: Cannot triple-click to select task title in phabricator (due to icon in the title): Unknown Object (Differential Revision).
Apr 29 2016, 11:56 PM · Bug Report
epriestley reopened T10905: Cannot triple-click to select task title in phabricator (due to icon in the title) as "Open".

Actually, this doesn't behave well with very long titles. Let me see if I can find an alternate fix.

Apr 29 2016, 11:51 PM · Bug Report
epriestley added a comment to T10905: Cannot triple-click to select task title in phabricator (due to icon in the title).

Thanks for the report. This should be fixed in HEAD of master, and should promote to stable within 24 hours. Let us know if you run into anything else.

Apr 29 2016, 11:43 PM · Bug Report
epriestley closed T10905: Cannot triple-click to select task title in phabricator (due to icon in the title) as Resolved by committing Restricted Diffusion Commit.
Apr 29 2016, 11:43 PM · Bug Report
epriestley added a revision to T10905: Cannot triple-click to select task title in phabricator (due to icon in the title): Unknown Object (Differential Revision).
Apr 29 2016, 11:40 PM · Bug Report
epriestley added a comment to T10906: Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color.

Can you point us at where in the UI these are used, exactly? Just want to make sure we're fixing the right thing.

Apr 29 2016, 11:32 PM · Bug Report
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 29 2016, 9:25 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 29 2016, 8:38 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
gurrinder awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Apr 29 2016, 8:01 PM · Workboards (v3), Restricted Project
epriestley created T10903: Customize "open in new window" link behavior for RemarkupEngine.
Apr 29 2016, 5:26 PM · Phacility, Remarkup
epriestley added a project to T10901: Support title art for Phame blogs: Phacility.
Apr 29 2016, 5:21 PM · Phacility, Phame
epriestley created T10902: Support third-party package definitions in Celerity, or remember how it works if I already built it.
Apr 29 2016, 5:20 PM · Phacility, Celerity
epriestley created T10901: Support title art for Phame blogs.
Apr 29 2016, 5:13 PM · Phacility, Phame
epriestley added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

This is the expected method.

Apr 29 2016, 3:11 PM · Design, Bug Report
epriestley renamed T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts from "Printable version" does not appear to have any effect on order page in Phortune / Phacility to Print CSS does not fold/hide curtains for object pages like Phortune carts.
Apr 29 2016, 3:06 PM · Design, Bug Report
epriestley added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

It has the visible effect of removing the page header and footer.

Apr 29 2016, 3:06 PM · Design, Bug Report
epriestley closed T10896: Changing repository from hosted to fetched fails as Resolved.
Apr 29 2016, 3:04 PM · Bug Report
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

The heuristic only triggers if the repository was previously empty. So it might possibly get a false positive on the very first pull request to a new empty repository, but should be fine after that.

Apr 29 2016, 3:04 PM · Bug Report
epriestley renamed T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD` from easy browsing of revision of current branch to Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
Apr 29 2016, 1:53 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

Note that when you do this, you may generate a large amount of email you don't want, because you're adding commits to a repository which was previously marked as fully imported (it "completed" the import process when it was an empty, hosted repository). You may want to disable publishing in "Publish/Notify". See also T9554.

Apr 29 2016, 1:52 PM · Bug Report
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

I can't reproduce this. Here's what I tried. First, I created a new, empty, hosted Git repository:

Apr 29 2016, 1:49 PM · Bug Report
epriestley closed T10897: Recovering a lost room in Conpherence as Resolved.

If you know the ID/monogram of the room (should be in the subject of any email you received, looks like Z123), I think you can also bin/policy unlock Zxxx it, which should make it public. Then you should be able to rejoin it.

Apr 29 2016, 1:39 PM · Conpherence, Bug Report
epriestley added a comment to T10898: testing.

@benjumanji, I added you to Community so you should have some new powers to abuse.

Apr 29 2016, 1:33 PM · Feature Request
epriestley added a member for Community: benjumanji.
Apr 29 2016, 1:32 PM
epriestley closed T10898: testing as Spite.
Apr 29 2016, 1:32 PM · Feature Request
jayvdb awarded T10747: Import and export ICS from Calendar a Mountain of Wealth token.
Apr 29 2016, 2:58 AM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7789: Support Git Large File Storage.

Great, I'm glad to hear things are working for you. Thanks for your help testing this out!

Apr 29 2016, 1:14 AM · Customer Impact, Restricted Project, Files, Diffusion

Apr 28 2016

epriestley updated the task description for T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 28 2016, 8:49 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 8:35 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10366: General support for multiple URIs for a repository: Unknown Object (Differential Revision).
Apr 28 2016, 8:35 PM · Diffusion (v3), Restricted Project, Feature Request
epriestley added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

Oh, the actual implementation would be --revision (with a short option), I was just using --the-revision-for for clarity (or extra confusion?) in discussing the meaning/behavior of the flag.

Apr 28 2016, 6:52 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

Some earlier discussion in T5781, although I didn't really have a clear way forward at the time and still don't.

Apr 28 2016, 6:38 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 5:45 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T10894: Arc patch fails when a symlink is replaced with a file into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 28 2016, 5:43 PM · Arcanist
epriestley merged task T10894: Arc patch fails when a symlink is replaced with a file into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 28 2016, 5:43 PM · Bug Report
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 4:25 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10366: General support for multiple URIs for a repository: Unknown Object (Differential Revision).
Apr 28 2016, 4:25 PM · Diffusion (v3), Restricted Project, Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 11:31 AM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10889: 测试test as Spite.
Apr 28 2016, 10:17 AM · Arcanist
epriestley closed T10888: 123 as Spite.
Apr 28 2016, 10:17 AM · Bug Report
epriestley closed T10887: [feed] Missing avatar for Herald authored feed entries as Invalid.

This should be fixed in Week 17. See T8952 / D15773. Let us know if you're still seeing issues after upgrading, or can reproduce the problem on this install.

Apr 28 2016, 10:17 AM · Bug Report

Apr 27 2016

epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

we'll get to it when we feel like it (ok not a totally fair paraphrase, but it's one way to read it)

Apr 27 2016, 11:45 PM · Restricted Project, User Delight, Maniphest
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

Perhaps helpful for context is T6027, which was open for longer than this (about 18 months).

Apr 27 2016, 11:13 PM · Restricted Project, User Delight, Maniphest
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

What isn't helpful about it? I believe it has a complete answer to your question, and a great deal of detail explaining why that's the answer. How could it be more helpful? Did I misunderstand what you're asking?

Apr 27 2016, 11:05 PM · Restricted Project, User Delight, Maniphest
epriestley closed T7177: Peculiar Authorization Issue in cloned repositories as Invalid.

I suspect this isn't a bug -- diffs have repository associations, and you must be able to see a repository to see associated diffs. You must be able to see the active diff to see a revision. So andy caused the active diff to belong to a repository that nuno can not see, which prevents nuno from seeing the revision.

Apr 27 2016, 10:58 PM
epriestley updated the task description for T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:51 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 10:47 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:46 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:46 PM · Diffusion
epriestley added a comment to T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard.

I'm going to merge this into T10748, which is now more clearly the way forward.

Apr 27 2016, 10:46 PM · Diffusion
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

See Planning for information on timelines and progress.

Apr 27 2016, 10:38 PM · Restricted Project, User Delight, Maniphest
epriestley edited this Badge.
Apr 27 2016, 10:04 PM
epriestley added a member for Community: jparise.
Apr 27 2016, 10:04 PM
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 5:52 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 5:34 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T9604: Creating an imported repository via Conduit results in filesystem error into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:58 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T9604: Creating an imported repository via Conduit results in filesystem error into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:58 PM · Restricted Project, Phacility Support, Diffusion, Conduit
epriestley added a comment to T9604: Creating an imported repository via Conduit results in filesystem error.

I'm going to merge this into T10748, since that's now clearly the way forward.

Apr 27 2016, 1:57 PM · Restricted Project, Phacility Support, Diffusion, Conduit
epriestley merged T6848: It should be possible to view a repository's policies without necessarily being able to edit it into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:54 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T6848: It should be possible to view a repository's policies without necessarily being able to edit it into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:54 PM · Diffusion (v3)
epriestley added a comment to T6848: It should be possible to view a repository's policies without necessarily being able to edit it.

I'm going to merge this into T10748 because that's clearly the pathway forward now. You can view the new UI at /diffusion/X/manage/, although it mostly doesn't work yet and there are no links to it in the UI.

Apr 27 2016, 1:53 PM · Diffusion (v3)
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

T10751 and T4292 are reaching a steadier state now and have some indirect/soft dependencies on this (for example, the new panel for monitoring the cluster status of a particular repository is part of this new UI) so I expect to drive this forward at least somewhat in the next few days. I'm not sure how ambitious I'll feel about meddling with the URI code before the release cut, but there's a good chunk of basic work remaining before that becomes an issue.

Apr 27 2016, 1:49 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10843: Don't write Celerity resources which aren't defined in the local map to cache: Unknown Object (Differential Revision).
Apr 27 2016, 1:46 PM · Infrastructure
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

See also Contributing Bug Reports:

Apr 27 2016, 1:39 PM · Documentation, Bug Report
epriestley closed T10885: Arcanist Windows install docs - adding in additional php extensions as Wontfix.

The instructions are correct as written, and are aimed at being as simple as possible for users who may not be familiar with PHP. We can not possibly include instructions for every imaginable installer, see also T4200.

Apr 27 2016, 1:37 PM · Documentation, Bug Report
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

In particular, the install instructions tell you to:

Apr 27 2016, 1:09 PM · Documentation, Bug Report
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

How did you install PHP, exactly?

Apr 27 2016, 1:08 PM · Documentation, Bug Report
epriestley renamed T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge from Inline comments in Pholio are not visible anymore to Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Apr 27 2016, 1:06 PM · Pholio, Bug Report
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Yeah, measuring latency and using it as a signal is tricky. If there's a long disruption and Oregon measures faster than N. California for "a while", we probably legitimately want to use it. If N. California completely goes down, we almost certainly want to keep things alive and send writes to Mars, even if Mars is at a huge network distance, since "slow write" is probably almost always better than "complete failure" (although maybe Mars bandwith is so much more expensive that we don't want to fail over to it, or the size of the link is small enough that it simply can't accommodate the failover traffic).

Apr 27 2016, 11:47 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Ah, link speed vs latency is interesting.

Apr 27 2016, 11:36 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Is "use measured latency" probably always the correct rule in your (hypothetical) cluster setup? Or do you have any cases offhand where it isn't the desired result, and you really want to send traffic to a more distant node on the network?

Apr 27 2016, 11:33 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

I don't currently expect anyone to be deploying multi-region clusters in the first iteration of real clustering, so this isn't high on my list of things to fix in this round.

Apr 27 2016, 11:23 AM · Clusters
epriestley added a comment to T10883: Allow repository cluster nodes to be read-only.

See also T10884 for related work: ranking similar nodes more intelligently.

Apr 27 2016, 11:17 AM · Restricted Project, Diffusion, Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

See also T10883 for related work: making some nodes read-only.

Apr 27 2016, 11:17 AM · Clusters
epriestley created T10884: Sort repository, database and notification services better (by network distance).
Apr 27 2016, 11:16 AM · Clusters
epriestley created T10883: Allow repository cluster nodes to be read-only.
Apr 27 2016, 11:13 AM · Restricted Project, Diffusion, Clusters
epriestley added Q379: notification.servers (Answer 370).
Apr 27 2016, 10:45 AM
epriestley closed T10882: test as Spite.
Apr 27 2016, 10:03 AM · Bug Report

Apr 26 2016

epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 11:11 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 10:55 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
robertkraig awarded T10778: ${NAMESPACE}_search is missing an edge and edgedata table a Like token.
Apr 26 2016, 6:34 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10880: Cannot persist changes of visibility of Form Template.

Thanks -- T10778 had instructions which I was more successful with. This should be fixed in HEAD.

Apr 26 2016, 6:31 PM · Bug Report
epriestley closed T10778: ${NAMESPACE}_search is missing an edge and edgedata table as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 6:26 PM · ApplicationEditor, Bug Report
epriestley added a revision to T10778: ${NAMESPACE}_search is missing an edge and edgedata table: Unknown Object (Differential Revision).
Apr 26 2016, 6:22 PM · ApplicationEditor, Bug Report
epriestley claimed T10778: ${NAMESPACE}_search is missing an edge and edgedata table.
Apr 26 2016, 6:16 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10778: ${NAMESPACE}_search is missing an edge and edgedata table.

Oh, thanks. I can reproduce this variant of things. I thought I remembered seeing this...

Apr 26 2016, 6:15 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10880: Cannot persist changes of visibility of Form Template.

Do you have a stack trace in your webserver error log? (Often /var/log/apache2/error.log or similar.) I can't immediately reproduce this myself, but that might help narrow down the cause.

Apr 26 2016, 6:14 PM · Bug Report
epriestley closed T10386: HTTP instructions in "Diffusion User Guide: Repository Hosting" are incomplete as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 5:07 PM · Documentation, Bug Report
epriestley closed T10876: Make the setup warning count cache database-backed, a subtask of T10751: Make Phabricator Highly Available, as Resolved.
Apr 26 2016, 5:03 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10876: Make the setup warning count cache database-backed as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 5:03 PM · Clusters
epriestley added Q378: Read-only access on hosted Phabricator for non-login users (Answer 369).
Apr 26 2016, 3:05 PM
epriestley added a comment to T10877: Large sized GIF is not animated properly..

The GIF data is set to repeat the animation only once (see circled control in footer):

Apr 26 2016, 2:57 PM · Bug Report
epriestley added a revision to T10876: Make the setup warning count cache database-backed: Unknown Object (Differential Revision).
Apr 26 2016, 2:44 PM · Clusters
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Restricted Differential Revision.
Apr 26 2016, 2:00 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request