Page MenuHomePhabricator
Feed Advanced Search

Sep 30 2015

epriestley merged task T9484: Attempting to undo deletion of inline comments in a differential after starting to write a new inline comment results in 'Unhandled Exception ("InvalidArgumentException")' into T9269: Undoing multiple inline comments on the same line will restore the comment out of position..
Sep 30 2015, 1:07 AM · Differential

Sep 29 2015

epriestley added a comment to T9123: Build Phabricator in Harbormaster (v2).

We're kinda-sort doing builds for commits now:

Sep 29 2015, 9:16 PM · Prioritized, Harbormaster
cinek awarded T9378: Build Projects v3 a Love token.
Sep 29 2015, 9:16 PM · Projects (v3), Prioritized
epriestley closed T2015: Implement Drydock as Resolved.

I'm going to close this out since I think everything here is now reasonably represented elsewhere:

Sep 29 2015, 3:01 PM · Drydock
epriestley closed T2015: Implement Drydock, a subtask of T1049: Implement Harbormaster, as Resolved.
Sep 29 2015, 3:01 PM · Harbormaster
epriestley closed T2015: Implement Drydock, a subtask of T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag, as Resolved.
Sep 29 2015, 3:01 PM · Drydock, Diffusion
epriestley added a comment to T9269: Undoing multiple inline comments on the same line will restore the comment out of position..

Here's a similar failure case:

Sep 29 2015, 2:45 PM · Inline Comments, Differential
epriestley added a comment to T7870: List of cases where ghost comments end up somewhere confusing or unexpected.

It's possible, but I'd guess they're probably not related if I had to.

Sep 29 2015, 2:42 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster: Unknown Object (Differential Revision).
Sep 29 2015, 2:32 PM · Restricted Project, Harbormaster (v3)
epriestley closed T9476: No way to skip rule arc:prompt as Resolved by committing Restricted Diffusion Commit.
Sep 29 2015, 2:09 PM · Arcanist
epriestley closed T9481: Allow 'revision' section in history to be hidden when differential is uninstalled as Resolved by committing Restricted Diffusion Commit.
Sep 29 2015, 2:09 PM · Differential, Diffusion
epriestley closed T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention as Resolved by committing Restricted Diffusion Commit.
Sep 29 2015, 1:43 PM · Remarkup
epriestley added a comment to T9482: Problems in the "Commits in this Package that Need Attention" view.

D14189 should fix the button.

Sep 29 2015, 1:43 PM · Restricted Project, Restricted Project, Audit
epriestley added a revision to T9482: Problems in the "Commits in this Package that Need Attention" view: Unknown Object (Differential Revision).
Sep 29 2015, 1:40 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9482: Problems in the "Commits in this Package that Need Attention" view.

Oh, never mind -- pretty sure I figured it out.

Sep 29 2015, 1:38 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9482: Problems in the "Commits in this Package that Need Attention" view.

I'm not immediately able to reproduce that status icon issue, what does the icon say when you hover over it?

Sep 29 2015, 1:37 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9482: Problems in the "Commits in this Package that Need Attention" view.

For the first half of this, see T9430 / D14013 / T9372.

Sep 29 2015, 1:33 PM · Restricted Project, Restricted Project, Audit
epriestley claimed T9481: Allow 'revision' section in history to be hidden when differential is uninstalled.
Sep 29 2015, 1:22 PM · Differential, Diffusion
epriestley added a revision to T9481: Allow 'revision' section in history to be hidden when differential is uninstalled: Unknown Object (Differential Revision).
Sep 29 2015, 1:22 PM · Differential, Diffusion
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Sep 29 2015, 11:47 AM
epriestley added a comment to T9476: No way to skip rule arc:prompt.

After D14187, we will continue evaluation if you enter no text (i.e., just hit enter at the prompt).

Sep 29 2015, 11:46 AM · Arcanist
epriestley added a revision to T9476: No way to skip rule arc:prompt: Unknown Object (Differential Revision).
Sep 29 2015, 11:45 AM · Arcanist
epriestley claimed T9476: No way to skip rule arc:prompt.
Sep 29 2015, 11:42 AM · Arcanist
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Sep 29 2015, 11:39 AM
epriestley claimed T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.
Sep 29 2015, 11:38 AM · Remarkup
epriestley added a comment to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

Also note that remarkup has a parser cache, so older mentions won't automatically be fixed right away (the bad parse is cached).

Sep 29 2015, 11:29 AM · Remarkup
epriestley added a comment to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

I think D14186 will fix this. Let me know if you catch anything else wonky after that lands -- I got some indirect test coverage on this, but might need to go beef things up a bit if I missed something.

Sep 29 2015, 11:23 AM · Remarkup
epriestley renamed T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention from If username only has one letter it will not be automatically linked by @mention to If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.
Sep 29 2015, 11:11 AM · Remarkup
epriestley added a revision to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention: Unknown Object (Differential Revision).
Sep 29 2015, 11:10 AM · Remarkup
epriestley added a comment to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

Ah, I think that's parsing as K4 (Passphrase Credential #4) plus some other stuff. We allow hyphens after an object reference (like "T9479-should be fixed ASAP").

Sep 29 2015, 11:10 AM · Remarkup
epriestley added a comment to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

Oh, it may be a little more involved than that. I think the user in the original report (C933103) is conflicting with the Countdown rule.

Sep 29 2015, 10:59 AM · Remarkup
epriestley added a comment to T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

I think the actual rule is "if a username is at least 8 characters long and contains only [a-fA-F0-9]".

Sep 29 2015, 10:52 AM · Remarkup
epriestley added a comment to T9123: Build Phabricator in Harbormaster (v2).

We technically have builds now:

Sep 29 2015, 2:13 AM · Prioritized, Harbormaster
epriestley added a revision to T9123: Build Phabricator in Harbormaster (v2): Unknown Object (Differential Revision).
Sep 29 2015, 2:10 AM · Prioritized, Harbormaster
epriestley added a revision to T9123: Build Phabricator in Harbormaster (v2): Unknown Object (Differential Revision).
Sep 29 2015, 1:04 AM · Prioritized, Harbormaster
epriestley added a comment to T9478: Working with harbormaster.sendmessage.

What response are you expecting? The method returns void (meaning "no data") and that's a "success" response (no error occurred).

Sep 29 2015, 12:17 AM · Arcanist, Herald, Harbormaster

Sep 28 2015

epriestley added a revision to T9123: Build Phabricator in Harbormaster (v2): Unknown Object (Differential Revision).
Sep 28 2015, 11:39 PM · Prioritized, Harbormaster
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Sep 28 2015, 9:28 PM · Inline Comments, Restricted Project, Differential
20after4 awarded T7475: Reset umask explicitly in daemons a Like token.
Sep 28 2015, 8:07 PM · Wikimedia, Daemons
epriestley added a comment to T9352: Write some custom Herald glue for driving builds through Owners.

Quick progress update here: Owners packages now have configurable custom fields, so you can add one like this:

Sep 28 2015, 7:05 PM · Harbormaster, Herald, Owners, Prioritized
epriestley edited P1860 CustomDifferentialRunPackageBuildsHeraldAction.php.
Sep 28 2015, 7:03 PM
epriestley added a comment to T9252: Unprototype Drydock (v1).

Resources still do not have expiration behaviors.

Sep 28 2015, 6:37 PM · Prioritized, Drydock
epriestley closed T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work as Resolved by committing Restricted Diffusion Commit.
Sep 28 2015, 6:17 PM · Diffusion
epriestley added a revision to T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work: Unknown Object (Differential Revision).
Sep 28 2015, 6:02 PM · Diffusion
epriestley added a comment to T7639: Figure out MFA in the cluster.

One idea is that we could let you designate peers (either explicitly, or implicitly by sharing administrative control with them? -- but probably explicitly) who are permitted to strip your MFA tokens.

Sep 28 2015, 5:48 PM · Phacility
epriestley closed T6569: Implement proper expiry mechanism for Drydock resources as Resolved by committing Restricted Diffusion Commit.
Sep 28 2015, 4:35 PM · Drydock
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Sep 28 2015, 3:41 PM · Prioritized, Drydock
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Sep 28 2015, 2:28 PM · Prioritized, Drydock
epriestley closed T9475: "Readme.md"-Display does not render inline HTML as Wontfix.

There's no way to do this. It would allow anyone with commit access to XSS other users and take over their accounts.

Sep 28 2015, 2:19 PM · Diffusion
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Sep 28 2015, 1:34 PM · Prioritized, Drydock
epriestley added a revision to T6569: Implement proper expiry mechanism for Drydock resources: Unknown Object (Differential Revision).
Sep 28 2015, 1:06 PM · Drydock
joshuaspence added a comment to T9073: The "PHPCS" linter gets out of memory error on large files.

Pretty sure this was only possible after the introduction of .arclint.

Sep 28 2015, 9:53 AM · Lint

Sep 27 2015

epriestley added a comment to T2383: Run PHP environment checks from CLI.

T7248 was a case of a user with neither the mysql nor mysqli extensions installed.

Sep 27 2015, 9:14 PM · Setup
epriestley updated subscribers of T2383: Run PHP environment checks from CLI.
Sep 27 2015, 9:14 PM · Setup
epriestley merged task T7248: Phabricator mysql.implementation into T2383: Run PHP environment checks from CLI.
Sep 27 2015, 9:14 PM · Database
epriestley closed T7264: In differential, it would be interesting to know which commit affected a given line as Wontfix.

We don't plan to accommodate this particular workflow in the upstream, per se. Beyond @chad's links, see also T1508.

Sep 27 2015, 9:13 PM · Differential
epriestley added a comment to T6643: Conduit method for adding SSH keys to a user's account.

If users have MFA configured, I think it's important that we not let an attacker avoid MFA checks on operations (including adding SSH keys) by using Conduit. So if we had a method for adding SSH keys we'd either have to deactivate it when we hit an MFA block, or implement CLI MFA somehow (seems tricky/complex?) or have it add a "request" and then require the user to confirm that they want to add the key via MFA from the web UI after passing MFA, maybe (this feels bad to me for a bunch of reasons, though).

Sep 27 2015, 9:10 PM · Restricted Project, Conduit
epriestley added a comment to T8975: Reference variable for the current user on Conduit Method Call page.

It would be easier to implement this if we say the second form is required (enter JSON -> parse JSON -> interpolate the variable in stirings), but I think it's not intuitive that you can't just type {$me.phid} into a field like authorPHID. Certainly, I'd expect that if the console supported variables they'd be proper-value-variables, not string-interpolation-variables, since string interpolation is completely useless except that it's easier to implement.

Sep 27 2015, 9:07 PM · Conduit
joshuaspence added a comment to T9073: The "PHPCS" linter gets out of memory error on large files.

I can't remember off the top of my head, but I thought we had a way to pass flags to external linters. Something like this:

Sep 27 2015, 9:05 PM · Lint
joshuaspence added a comment to T8975: Reference variable for the current user on Conduit Method Call page.

We haven't seen other requests for this and I don't think it's very straightforward. Consider these JSON values:

[{$me.phid}]
["{$me.phid}"]

The former value is not valid JSON though?

Sep 27 2015, 9:00 PM · Conduit
epriestley added a comment to T6643: Conduit method for adding SSH keys to a user's account.

Aha, so the users are also different, and they're real users (not bots)?

Sep 27 2015, 8:46 PM · Restricted Project, Conduit
epriestley added a comment to T6643: Conduit method for adding SSH keys to a user's account.

I don't understand this use case. Why do you have unique keys per-VM?

Sep 27 2015, 8:27 PM · Restricted Project, Conduit
epriestley closed T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered as Resolved.

Pretty sure this was fixed during T2769. I can't reproduce it at HEAD:

Sep 27 2015, 8:24 PM · Herald
epriestley added a project to T7026: Add "Run build plan" to commit hooks: Harbormaster.
Sep 27 2015, 8:17 PM · Harbormaster, Herald
epriestley closed T5991: `bin/search index` returns 0 on failure as Resolved by committing Restricted Diffusion Commit.
Sep 27 2015, 8:11 PM · Search
epriestley added a comment to T5991: `bin/search index` returns 0 on failure.

D14173 explains upstream attitudes toward exit codes in greater detail.

Sep 27 2015, 5:54 PM · Search
epriestley added a revision to T5991: `bin/search index` returns 0 on failure: Unknown Object (Differential Revision).
Sep 27 2015, 5:50 PM · Search
epriestley added a revision to T5991: `bin/search index` returns 0 on failure: Unknown Object (Differential Revision).
Sep 27 2015, 5:32 PM · Search
epriestley closed T5133: Show "Hide Query" button in Maniphest even for custom queries as Resolved.

All result pages have a "Hide Query" button now, I think since the last redesign.

Sep 27 2015, 2:04 PM · Applications
epriestley closed T5098: Code review comment thread status: done vs pending` as Resolved.

I'm just going to close this, I think T1460 has similar discussion already.

Sep 27 2015, 2:00 PM · Differential
epriestley closed T3848: PhabricatorTaskmasterDaemon using fabulous amounts of RAM as Invalid.

We haven't seen reports about this from other installs or experienced it ourselves, and we've run an instanced production cluster with a mixture of workloads for more than 6 months now. All the daemon stuff has also changed a lot over the course of the last two years since this was originally reported.

Sep 27 2015, 1:59 PM · Daemons
epriestley changed the visibility for T2383: Run PHP environment checks from CLI.
Sep 27 2015, 1:51 PM · Setup
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T8818 was a specific example of a user hitting open_basedir issues.

Sep 27 2015, 1:51 PM · Setup
epriestley updated subscribers of T2383: Run PHP environment checks from CLI.
Sep 27 2015, 1:51 PM · Setup
epriestley merged task T8818: Getting "ERROR 2: is_link(): open_basedir restriction in effect" using arc diff after an update into T2383: Run PHP environment checks from CLI.
Sep 27 2015, 1:51 PM · Setup, Arcanist
epriestley triaged T8818: Getting "ERROR 2: is_link(): open_basedir restriction in effect" using arc diff after an update as Wishlist priority.
Sep 27 2015, 1:51 PM · Setup, Arcanist
epriestley closed T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause) as Resolved.

I think this is a duplicate of T9260, and was likely resolved by D14169.

Sep 27 2015, 1:50 PM · Herald
epriestley added a comment to T8865: Automatically compact storage.

bin/files compact shouldn't normally do much of anything; the better fix might be to identify what's causing these files to be written despite being compactable and stop it from doing that. My expectation is that all file writing callsites should automatically reuse storage if possible in modern code.

Sep 27 2015, 1:41 PM · Files
epriestley closed T8894: `differential.generated-paths` doesn't actually prevent code from being shown in Differential as Invalid.

Never mind, there's already such a note.

Sep 27 2015, 1:38 PM · Differential
epriestley added a comment to T8894: `differential.generated-paths` doesn't actually prevent code from being shown in Differential.

I can't reproduce this. Here's what I did:

Sep 27 2015, 1:36 PM · Differential
epriestley closed T8932: Failing Git commit / message parsers block the queue, even though they shouldn't as Invalid.

From discussion on IRC, I think this was a UI issue (these parsers do not block the queue, it just isn't clear that "Leased" includes tasks being actively worked on and tasks waiting on lease expiry), not a queue issue? We can improve this UI but I'm probably not going to touch it until I can collect some more stuff there (cf T7307).

Sep 27 2015, 1:27 PM · Daemons
epriestley closed T8975: Reference variable for the current user on Conduit Method Call page as Wontfix.

We haven't seen other requests for this and I don't think it's very straightforward. Consider these JSON values:

Sep 27 2015, 1:23 PM · Conduit
epriestley closed T9067: phabricator daemon fails when updating repository (possibly due to attempting to email a user without access) as Resolved.

Oh, I didn't look at the stack trace carefully when dealing with T9458. I think the fix for that (D14142) almost certainly resolved this, too.

Sep 27 2015, 1:15 PM · Herald, Differential, Daemons
epriestley closed T9073: The "PHPCS" linter gets out of memory error on large files as Wontfix.

I think this isn't our responsibility.

Sep 27 2015, 1:08 PM · Lint
epriestley added a comment to T8298: Fix Windows Escaping.

I think the way forward here is likely:

Sep 27 2015, 12:57 PM · Windows
epriestley closed T8720: files created from dot via remarkup in phriction should follow phriction view policy and not default view policy as Invalid.

We've removed the dot rules from the upstream for security reasons (see T9408) so this is no longer relevant, although it is a concern we might want to address in T4190.

Sep 27 2015, 12:04 PM · Policy, Phriction, Files
epriestley moved T9294: Phriction document-created email notifications do not include Edit Notes from Backlog to Next on the Phriction board.
Sep 27 2015, 12:03 PM · Phriction

Sep 26 2015

epriestley added a comment to T9123: Build Phabricator in Harbormaster (v2).

There's some relevant information on the progress on the Drydock side of this here: T9252#138215

Sep 26 2015, 4:00 PM · Prioritized, Harbormaster
epriestley added a comment to T9252: Unprototype Drydock (v1).

These things are now complete:

Sep 26 2015, 3:59 PM · Prioritized, Drydock
epriestley added a comment to T7399: Fully separate live credentials from development repositories.

API keys are now all cycled (except ReCAPTCHA, which doesn't seem to be cyclable and is a ~zero-value target anyway) and everything seems to have swapped over cleanly.

Sep 26 2015, 3:03 PM · Phacility
epriestley added a comment to T7399: Fully separate live credentials from development repositories.

(Testing inbound mail...)

Sep 26 2015, 2:00 PM · Phacility
epriestley added a comment to T7399: Fully separate live credentials from development repositories.

(Testing S3 / SES keys on this host...)

Sep 26 2015, 1:58 PM · Phacility
epriestley edited the content of Changelog.
Sep 26 2015, 1:37 PM
epriestley created 2015 Week 39 (Very Late September).
Sep 26 2015, 1:35 PM
epriestley closed T9473: teste as Invalid.
Sep 26 2015, 1:29 PM · Roadmap
epriestley closed T9471: New cowsay implementation renders .cow escape sequences as Resolved.
Sep 26 2015, 12:31 PM · Remarkup
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Sep 26 2015, 4:11 AM

Sep 25 2015

epriestley added a comment to T9331: Configure test-plan per repository.

Oh, I guess there isn't actually a "test plan" Herald field. We could add one easily enough. I was thinking:

Sep 25 2015, 11:28 PM · Diffusion, Differential
joshuaspence added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

Either Phabricator should allow pulling from Inactive repositories (I see no reason to prevent pulls, but preventing pushes is probably reasonable),

Sep 25 2015, 11:25 PM · Diffusion
joshuaspence added a comment to T9331: Configure test-plan per repository.

Workarounds like the one above (or just writing similar Herald rules) seem reasonable to me, if not ideal.

Sep 25 2015, 11:23 PM · Diffusion, Differential