HeraldAdapter throws exception on empty user custom field.
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	wmatusiak
	Aug 25 2015, 11:49 AM

Description

Steps to reproduce:

Create custom filed (Maniphest) with type user
Create herald rule (Maniphest task) on this filed with "include any of"
Try to create task

Argument 1 passed to array_fuse() must be of the type array, null given, called in /phabricator/src/applications/herald/adapter/HeraldAdapter.php on line 382 and defined

I think this also "works" with other PHID based fields and other applications.

Simplest resolution is to overide method getFieldVlaue in PhabricatorStandardCustomFieldPHIDS to return array if parent return null.

public function getFieldValue()                                                                                                                      
{                                                                                                                                                    
  $value = parent::getFieldValue();                                                                                                                
  if ($value) {                                                                                                                                    
    return $value;                                                                                                                               
  }                                                                                                                                                

  return array();                                                                                                                                  
}