Page MenuHomePhabricator

Putting project to CCs as a condition of Herald Rule doesn't get triggered
Closed, ResolvedPublic

Assigned To
Authored By
nickz
Feb 4 2015, 7:56 PM
Referenced Files
F838318: Screen Shot 2015-09-27 at 1.23.31 PM.png
Sep 27 2015, 8:24 PM
F838321: Screen Shot 2015-09-27 at 1.23.56 PM.png
Sep 27 2015, 8:24 PM
F289460: pasted_file
Feb 9 2015, 6:45 PM
F289445: pasted_file
Feb 9 2015, 6:37 PM
F289441: Screen_Shot_2015-02-09_at_10.26.27_AM.png
Feb 9 2015, 6:37 PM
F289443: pasted_file
Feb 9 2015, 6:37 PM
F283031: pasted_file
Feb 4 2015, 7:56 PM
F283027: pasted_file
Feb 4 2015, 7:56 PM

Description

I set up a Herald Rule using the following conditions:

pasted_file (195×729 px, 24 KB)

"sterling" is a project. But when I put "sterling" as a subscriber during arc diff and created the diff, the Herald Rule didn't get trigger due to the condition not matched:

pasted_file (70×310 px, 12 KB)

I checked the review page which does show the "sterling" project included in subscribers:

pasted_file (28×255 px, 4 KB)

Any ideas?

Event Timeline

nickz assigned this task to epriestley.
nickz raised the priority of this task from to Needs Triage.
nickz updated the task description. (Show Details)
nickz added a project: Phabot.
nickz added a subscriber: nickz.
chad edited projects, added Herald; removed Phabot.

sterling matches a user in remarkup, while #sterling matches a project. Did you verify the sterling in the subscribers section clicks through to the project and not some user also named sterling? (Or said differently, did you type sterling as initially reported (not a bug and probably due to the issue I am describing) or #sterling (a bug)?)

sterling matches a user in remarkup, while #sterling matches a project. Did you verify the sterling in the subscribers section clicks through to the project and not some user also named sterling? (Or said differently, did you type sterling as initially reported (not a bug and probably due to the issue I am describing) or #sterling (a bug)?)

@btrahan, I verified the "sterling" is a project, I clicked through it. Initially when I did the arc diff, I typed "#sterling".

Anything I can do to faster the process to fix the bug?

Oops, there was an error in my rule (match all vs match any) so I reran it. Still looks like a bug:

pasted_file (108×178 px, 12 KB)

Oddly, the dry run on D11721 works as expected, so something is getting lost coming up from arc.

@chad, I am glad you can reproduce it.

@chad, have you found the root cause?

This issue isn't triaged or assigned. See T4778 for how we prioritize our time.

Is this issue critical to your organization? That is, is your company at a standstill until this resolves or is work able to move forward around it?

Hi Chad, Yes, without this fixed, we are not able to move forward for all tasks which need putting a project to CCs as a condition of the Herald Rule. Yes, it's up to your guys' priority list. But I hope this can be address very soon. Thanks!

Is this the same as the herald based replacement for project mentions + email (T6819) ?

Is this the same as the herald based replacement for project mentions + email (T6819) ?

I don't think so. @chad, what do you think?

It would be great if we know the ETA for the fix no matter soon or not soon.

It would be great if we know the ETA for the fix no matter soon or not soon.

If you'd like solid ETAs, shoot us an email at contact@phacility.com and we can talk about setting up a service contract so you can pay us to prioritize your requests. Otherwise, see the task @chad linked (T4778) for a very detailed discussion of why we can't give you (or anyone else) an ETA (on anything).

epriestley claimed this task.

Pretty sure this was fixed during T2769. I can't reproduce it at HEAD:

Screen Shot 2015-09-27 at 1.23.31 PM.png (1×1 px, 158 KB)

Screen Shot 2015-09-27 at 1.23.56 PM.png (157×487 px, 28 KB)