Attempting to undo deletion of inline comments in a differential after starting to write a new inline comment results in 'Unhandled Exception ("InvalidArgumentException")'
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	kojik1010
	Sep 30 2015, 12:55 AM

Description

Steps to reproduce:

Open a diff.
Write an inline comment
Delete the inline comment
Start writing another inline comment
(Optionally) Cancel writing the second inline comment
Click on "Changes discarded. Undo"

Popup says

Argument 2 passed to DifferentialInlineCommentEditController::canEditInlineComment() must be an instance of DifferentialInlineComment, boolean given, called in /core/lib/phabricator/src/applications/differential/controller/DifferentialInlineCommentEditController.php on line 63 and defined

Event Timeline

kojik1010 created this task.Sep 30 2015, 12:55 AM

kojik1010 updated the task description. (Show Details)

kojik1010 added a subscriber: kojik1010.

epriestley closed this task as a duplicate of T9269: Undoing multiple inline comments on the same line will restore the comment out of position..Sep 30 2015, 1:07 AM

joshuaspence added a project: Differential.Oct 2 2015, 8:56 AM

joshuaspence added a subscriber: joshuaspence.

Herald added a subscriber: cspeckmim. · View Herald TranscriptOct 2 2015, 8:56 AM

Attempting to undo deletion of inline comments in a differential after starting to write a new inline comment results in 'Unhandled Exception ("InvalidArgumentException")'Closed, DuplicatePublicActions

Description

Event Timeline

Attempting to undo deletion of inline comments in a differential after starting to write a new inline comment results in 'Unhandled Exception ("InvalidArgumentException")'
Closed, DuplicatePublic
Actions