Page MenuHomePhabricator
Feed Advanced Search

Aug 4 2015

epriestley added a revision to T7419: Provide a straightforward way to create and update CI test statuses for a revision: Unknown Object (Differential Revision).
Aug 4 2015, 7:30 PM · Differential, Harbormaster
epriestley added a revision to T8973: Encoding JSON for presentation could use more human-friendly escaping rules: Unknown Object (Differential Revision).
Aug 4 2015, 7:28 PM · Customer Impact
epriestley added a revision to T7419: Provide a straightforward way to create and update CI test statuses for a revision: Unknown Object (Differential Revision).
Aug 4 2015, 7:28 PM · Differential, Harbormaster
epriestley added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

See also:

Aug 4 2015, 7:19 PM · Aphront
epriestley closed T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type as Invalid.

Sorry, we do not support third-party application development. See T5447 for discussion.

Aug 4 2015, 7:18 PM · Aphront
epriestley added a comment to T8531: Duplicate column name "spacePHID".

Comcastic!

Aug 4 2015, 6:46 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

(If you immediately get another error, there's some more serious problem with state tracking. This usually means you imported/exported awkwardly or mucked with the data somehow, and recovery depends on exactly what state you're in and how you got there.)

Aug 4 2015, 6:44 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

(If you immediately get another error, there's some more serious problem with state tracking. This usually means you imported/exported awkwardly or mucked with the data somehow, and recovery depends on exactly what state you're in and how you got there.)

Aug 4 2015, 6:43 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

Delete all the text in 20150609.spaces.1.pholio.sql (but not the file itself), then run bin/storage upgrade again.

Aug 4 2015, 6:41 PM
epriestley added a comment to T7419: Provide a straightforward way to create and update CI test statuses for a revision.

Ah, thanks! I think we're probably in fairly good shape once everything is properly documented so I'll plan to close this out and we can look at placeholder results in the future if there's a compelling need for it from somewhere else.

Aug 4 2015, 5:44 PM · Differential, Harbormaster
epriestley added a comment to T7419: Provide a straightforward way to create and update CI test statuses for a revision.

I'll add one thing to Evan's comments there, which is that it would be useful to be able to create a test before the results are available. That way reviewers can see that such and such tests are still running and their results are pending.

Aug 4 2015, 4:57 PM · Differential, Harbormaster
epriestley merged task T9061: Can't change view in UIExamples into T5752: Navigation menus should work correctly on mobile by default.
Aug 4 2015, 4:39 PM · Mobile, PHUI
epriestley merged T9061: Can't change view in UIExamples into T5752: Navigation menus should work correctly on mobile by default.
Aug 4 2015, 4:39 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley closed T9060: Herald Transcript error after updating Phabricator as Resolved by committing Restricted Diffusion Commit.
Aug 4 2015, 2:32 PM · Herald
joshuaspence created T9065: Show Changes dialog isn't mobile friendly.
Aug 4 2015, 11:05 AM · Mobile, Transactions
joshuaspence created T9064: Daemon console isn't mobile friendly.
Aug 4 2015, 9:24 AM · Mobile, Daemons
joshuaspence created T9063: Conduit application search.
Aug 4 2015, 9:17 AM · Contributor Onboarding, Restricted Project, Conduit
joshuaspence created T9062: Generalize PHPAST application.
Aug 4 2015, 9:12 AM · XHPAST
joshuaspence created T9061: Can't change view in UIExamples.
Aug 4 2015, 9:10 AM · Mobile, PHUI
epriestley added a revision to T9060: Herald Transcript error after updating Phabricator: Unknown Object (Differential Revision).
Aug 4 2015, 8:20 AM · Herald
epriestley added a comment to T9057: Searching the wiki takes too many clicks.

See T4213 for "we change CSS all the time and your stuff will break every few months if you mess with it".

Aug 4 2015, 2:32 AM · Phriction, Restricted Project
joshuaspence added a comment to T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.

We have roughly 10 of these in our queue.

Aug 4 2015, 2:30 AM · Policy, Differential, Daemons
epriestley added a comment to T9056: Project templates.

Can you give me a better idea of what these huge, extremely similar projects are? I can't come up with any guesses from my experience, and the categories don't precisely sound like operations or software engineering. I've never heard the term "Fitout" before and Google is only giving me hits in the context of interior design.

Aug 4 2015, 2:25 AM · FreeBSD, Restricted Project
joshuaspence created T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.
Aug 4 2015, 2:25 AM · Policy, Differential, Daemons
epriestley added a comment to T9054: Undefined class constant ACTION_BLOCK.

I pushed this host, should be all set now?

Aug 4 2015, 2:07 AM · Herald
epriestley added a comment to T9056: Project templates.

Broadly, we're much more able to solve problems if you describing the problem you're facing rather than just the solution you're interested in:

Aug 4 2015, 12:39 AM · FreeBSD, Restricted Project
epriestley added a comment to T9056: Project templates.

There's some prior discussion of something similar in T7190. Is your use case a lot like that, or a lot different, or somewhere in between?

Aug 4 2015, 12:33 AM · FreeBSD, Restricted Project
epriestley closed T9054: Undefined class constant ACTION_BLOCK as Resolved by committing Restricted Diffusion Commit.
Aug 4 2015, 12:05 AM · Herald
epriestley closed T9054: Undefined class constant ACTION_BLOCK, a subtask of T8726: Modularize Herald fields and actions, as Resolved.
Aug 4 2015, 12:05 AM · Herald
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Put another way, there is no scenario where running bin/remove destroy is desirable:

Aug 4 2015, 12:00 AM · Infrastructure, Restricted Project

Aug 3 2015

epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

It is difficult to concisely communicate what bin/remove destroy does.

Aug 3 2015, 11:43 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Whoops, that's half a draft. Ignore that, I'll write a proper version...

Aug 3 2015, 11:15 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.
Aug 3 2015, 11:14 PM · Infrastructure, Restricted Project
epriestley closed T9055: Weird Herald spacing, a subtask of T8726: Modularize Herald fields and actions, as Resolved.
Aug 3 2015, 10:49 PM · Herald
epriestley closed T9055: Weird Herald spacing as Resolved by committing Restricted Diffusion Commit.
Aug 3 2015, 10:49 PM · Herald
epriestley added subtasks for T8726: Modularize Herald fields and actions: T9055: Weird Herald spacing, T9054: Undefined class constant ACTION_BLOCK.
Aug 3 2015, 10:46 PM · Herald
epriestley added a parent task for T9054: Undefined class constant ACTION_BLOCK: T8726: Modularize Herald fields and actions.
Aug 3 2015, 10:46 PM · Herald
epriestley added a revision to T9054: Undefined class constant ACTION_BLOCK: Unknown Object (Differential Revision).
Aug 3 2015, 10:45 PM · Herald
epriestley claimed T9054: Undefined class constant ACTION_BLOCK.
Aug 3 2015, 10:44 PM · Herald
epriestley added a revision to T9055: Weird Herald spacing: Unknown Object (Differential Revision).
Aug 3 2015, 10:36 PM · Herald
epriestley claimed T9055: Weird Herald spacing.
Aug 3 2015, 10:34 PM · Herald
joshuaspence created T9055: Weird Herald spacing.
Aug 3 2015, 10:32 PM · Herald
joshuaspence created T9054: Undefined class constant ACTION_BLOCK.
Aug 3 2015, 10:31 PM · Herald
epriestley updated subscribers of T731: Allow revisions to have alternate acceptance conditions.
Aug 3 2015, 10:21 PM · Restricted Project, Restricted Project, Differential
epriestley merged task T9053: Fix asymmetry between Project Reviewers and normal Reviewers into T731: Allow revisions to have alternate acceptance conditions.
Aug 3 2015, 10:21 PM · Differential, Restricted Project
epriestley added a comment to T8957: Upgrading: HeraldCustomAction is now HeraldAction.

This stuff is now in HEAD, and HEAD no longer loads (or even contains) HeraldCustomAction.

Aug 3 2015, 10:05 PM · Installing & Upgrading, Herald
epriestley added a comment to T8726: Modularize Herald fields and actions.

I've deployed this to this server, let me know if anyone catches anything suspicious with Herald.

Aug 3 2015, 10:05 PM · Herald
epriestley added a comment to T9052: "close as duplicate" workflow should allow me to close the task I'm looking at as a dupe of another.

See also T7819.

Aug 3 2015, 10:03 PM · Maniphest, Restricted Project
epriestley updated subscribers of T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
Aug 3 2015, 10:02 PM · Restricted Project, User Delight, Maniphest
epriestley merged task T9052: "close as duplicate" workflow should allow me to close the task I'm looking at as a dupe of another into T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
Aug 3 2015, 10:02 PM · Maniphest, Restricted Project
joshuaspence added a comment to T9051: Add subscribers/CCs to Phame Blog.

thumbsup

Aug 3 2015, 9:08 PM · Phame
joshuaspence added a comment to T9051: Add subscribers/CCs to Phame Blog.

Should I be using Phame?

Aug 3 2015, 9:07 PM · Phame
epriestley closed T8812: Herald Rule does not send mails as Resolved.

For the original issue: when a change is blocked, we do not send email about it. There is no way to be alerted to blocked pushes right now, and I generally don't think this is useful enough to include in the upstream. This interaction could possibly be more clear, but feels like something we just stick in the documentation to me.

Aug 3 2015, 9:04 PM · Herald
joshuaspence created T9051: Add subscribers/CCs to Phame Blog.
Aug 3 2015, 8:47 PM · Phame
joshuaspence created T9050: Ability to turn an email thread into a Maniphest task.
Aug 3 2015, 8:45 PM · Mail, Maniphest
epriestley added a comment to T9003: Herald rule not working.

Just to follow up on this, the transcript will show this at HEAD once T8726 lands:

Aug 3 2015, 8:42 PM · Herald, Phacility Support
epriestley closed T5194: Create documentation on how to implement a custom Herald action as Wontfix.

This has been in the update notes for a while, but just for completeness: T8726 is changing this substantially. After those change land, you must extend HeraldAction instead of HeraldCustomAction. The API is similar, but doesn't directly map to the old class.

Aug 3 2015, 8:11 PM · Documentation, Herald
epriestley added a parent task for T8726: Modularize Herald fields and actions: T6919: Add Herald support to Ponder.
Aug 3 2015, 7:41 PM · Herald
epriestley added a subtask for T6919: Add Herald support to Ponder: T8726: Modularize Herald fields and actions.
Aug 3 2015, 7:41 PM · Herald, Ponder
epriestley added a comment to T6919: Add Herald support to Ponder.

This should wait for T8726 since the API for actions is completely changed in unlanded work.

Aug 3 2015, 7:40 PM · Herald, Ponder
epriestley edited the content of Changelog.
Aug 3 2015, 5:07 PM
epriestley created 2015 Week 31 (Early August).
Aug 3 2015, 5:06 PM
epriestley closed T9046: "Forgot password" functionality is broken as Resolved by committing Restricted Diffusion Commit.
Aug 3 2015, 3:01 PM · Auth
epriestley renamed T9041: Control access to administrator capabilities with custom policies from Administrator capabilities are not customizable to Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:21 PM · FreeBSD, Policy, People
epriestley updated subscribers of T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:20 PM · FreeBSD, Policy, People
epriestley merged task T9015: Allow user account enable/disable to be a delegatable to non admins into T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:20 PM · People
epriestley renamed T9041: Control access to administrator capabilities with custom policies from "Create New Users" policy does not work to Administrator capabilities are not customizable.
Aug 3 2015, 1:20 PM · FreeBSD, Policy, People
epriestley added a comment to T9041: Control access to administrator capabilities with custom policies.

See some discussion in D13777.

Aug 3 2015, 1:17 PM · FreeBSD, Policy, People
epriestley added a revision to T9046: "Forgot password" functionality is broken: Unknown Object (Differential Revision).
Aug 3 2015, 1:06 PM · Auth
epriestley claimed T9046: "Forgot password" functionality is broken.
Aug 3 2015, 1:05 PM · Auth
epriestley updated subscribers of T9046: "Forgot password" functionality is broken.
Aug 3 2015, 1:05 PM · Auth
epriestley merged task T9038: Unable to Login into T9046: "Forgot password" functionality is broken.
Aug 3 2015, 1:05 PM · Auth
epriestley added a comment to T9038: Unable to Login.

Sorry, I made a mistake and didn't update my local copy properly before trying to reproduce this. This is an error on our side.

Aug 3 2015, 1:05 PM · Auth
joshuaspence added a project to T9047: arc lint can not find php and phpcs: Lint.
Aug 3 2015, 9:15 AM · Windows, Lint, Arcanist
joshuaspence created T9046: "Forgot password" functionality is broken.
Aug 3 2015, 6:42 AM · Auth
joshuaspence created T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 2:52 AM · FreeBSD, Policy, People
epriestley merged task T9040: Google SSO fails if `auth.email-domains` is set and you're not logged into the correct Google account into T5591: Add default domain to Google auth.
Aug 3 2015, 2:19 AM · Auth, Restricted Project
epriestley updated subscribers of T5591: Add default domain to Google auth.
Aug 3 2015, 2:19 AM · Restricted Project, Restricted Project, Auth

Aug 2 2015

joshuaspence edited P1836 bulk_move_workboard.php.
Aug 2 2015, 9:54 PM
epriestley closed T9038: Unable to Login as Invalid.

I can't reproduce this. When I follow these steps, the workflow completes successfully.

Aug 2 2015, 7:59 PM · Auth
epriestley closed T9038: Unable to Login as Invalid.

I can't reproduce this (resetting my own password works fine), and this report doesn't include enough information to allow us to help you.

Aug 2 2015, 12:38 PM · Auth

Aug 1 2015

epriestley closed T9037: Inconsistent status icon between commit audit status and audit request status as Invalid.
Aug 1 2015, 10:45 PM · Audit
epriestley added a comment to T9037: Inconsistent status icon between commit audit status and audit request status.

Currently nowhere. However I've created custom code

Aug 1 2015, 10:45 PM · Audit
epriestley added a comment to T8405: Making lint easier to use.

This might be sort of a copy of T7617.

Aug 1 2015, 10:32 PM · Lint, Restricted Project
epriestley added a comment to T7610: provide sitemap[.xml] [for search engines].

I can't reproduce this issue. For example, here's an index of this task:

Aug 1 2015, 11:29 AM
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Have a daemon that processes deleted commits/branches and deletes associated (incomplete?) audits

I think we probably don't want to do this. If someone accidentally deletes master and no one realizes for a little while, it would be bad to potentially destroy years worth of history, state and discussion contained in audits. Even just auto-closing them (without actually removing any comments/discussion) seems a bit bad.

Aug 1 2015, 10:55 AM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley closed T9035: Import database from custom installation of phabricator into phacility's hosted service. as Resolved.

Looks like this is in good shape now.

Aug 1 2015, 1:40 AM · Phacility Support
epriestley added a comment to T9035: Import database from custom installation of phabricator into phacility's hosted service..

Ah, perfect. Yeah, either contact@ or support@ will work fine. Thanks!

Aug 1 2015, 12:16 AM · Phacility Support
epriestley added a comment to T9035: Import database from custom installation of phabricator into phacility's hosted service..

Cool, I'll get this importing. Do you want to shoot us an email at support@phacility.com to coordinate the rest of the import? There might be some private questions later on in the process about data specifics in case we run into any issues.

Aug 1 2015, 12:16 AM · Phacility Support

Jul 31 2015

epriestley added a comment to T9025: burnup charts unclear.

When they occasionally break people complain, so I think some users find them useful.

Jul 31 2015, 3:17 AM · Maniphest
epriestley added a comment to T9025: burnup charts unclear.

They're supposed to show open tasks.

Jul 31 2015, 2:28 AM · Maniphest
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Improve the error message and provide a button to close the audit

Jul 31 2015, 1:30 AM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9026: arc land might identify wrong revision if branch is missing revision.

I do this routinely (roughly every day) without encountering this problem, so I'm surprised by this behavior.

Jul 31 2015, 1:04 AM · Restricted Project, Arcanist
epriestley added a comment to T7333: Empty commits get same revision as parent.

Specifically: empty commits and commits which strictly undo some of the work on a branch (e.g., revert HEAD, or revert HEAD + the prior commit, etc) produce a new commit with the same tree hash as an older commit.

Jul 31 2015, 1:01 AM · Differential
epriestley updated subscribers of T7333: Empty commits get same revision as parent.
Jul 31 2015, 12:59 AM · Differential
epriestley merged task T9027: Diffusion wrongly attached a Differential revision to a commit following arc backout into T7333: Empty commits get same revision as parent.
Jul 31 2015, 12:59 AM · Diffusion

Jul 30 2015

epriestley triaged T9023: phabot leaks memory as Wishlist priority.
Jul 30 2015, 6:51 PM · Phabot
epriestley added a comment to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.

See also T4411, although I expect to get to this before that.

Jul 30 2015, 2:53 PM · Wikimedia, Notifications
epriestley added a comment to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.

"Mark All Read" should remove them, but only if you have another newer notification than any of the phantom notifications.

Jul 30 2015, 2:50 PM · Wikimedia, Notifications
epriestley added a comment to T9019: Create a "Project Members" object policy for Projects.

It's not difficult to implement.

Jul 30 2015, 2:44 PM · Projects, Policy