| aik099 | |
| Aug 1 2015, 1:15 PM |
| F682458: Phabricator_FlaggedCommitStatusIcon.png | |
| Aug 1 2015, 7:55 PM |
The PhabricatorAuditCommitStatusConstants::getStatusIcon method has icon names hardcoded (e.g. fa-exclamation-triangle), while the PhabricatorAuditStatusConstants::getStatusIcon is using nice status icon constants (e.g. PHUIStatusItemView::ICON_WARNING, which maps to circle).
This results in same Concern Raised status using triangle icon in one case and circle icon in another case.
That I see.
What I don't understand if both should be triangles (I saw commit where commit audit status was triangle once, but then was changed to circle) or circles? They both share same color and symbol on the icon (exclamation mark), so why they are of different shapes.
I don't even know in what case the triangle should show up. Mostly, I don't think the triangle itself is the issue, but more why we have two different "audit item views". There should only be one if possible. (I admit I don't know the history here).
I don't even know in what case the triangle should show up.
Currently nowhere. However I've created custom code, that in flags list shows audit status of flagged item (if it was a commit). This way there is no need to go to each commit, that was flagged to see if it was audited or not.
And in that custom code I can't use circle icons because methods, that produce them expect status in "audit request format" (e.g. "concern-raised"), but commit itself has it as number and not word.
It's flag list for sure. The "Author: ..." part on the right is also custom-coded to show author of flagged commit.
Currently nowhere. However I've created custom code
We don't support third-party development.
https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#supported-issues
I'm just saying that if status icons are there, then maybe circles should be used in PhabricatorAuditCommitStatusConstants::getStatusIcon method as well.