Page MenuHomePhabricator

Allow Merge Duplicates to work in either direction
Closed, DuplicatePublic

Description

Since we're looking at having the Blocking dialogs go both directions on tasks (T4788), we can also extend a similar design solution to the Merge Duplicates dialog.

Event Timeline

carmandrew raised the priority of this task from to Needs Triage.
carmandrew updated the task description. (Show Details)
carmandrew added a project: Maniphest.
carmandrew added a subscriber: paulshen.
carmandrew added a subscriber: carmandrew.

I agree. The first many times I had to do this I kept trying to do something like
ActionChange StatusClose As Duplicate

It's not bad once you train yourself, but still feels a little odd.

chad added a subscriber: chad.Apr 14 2015, 1:07 AM

Please see https://secure.phabricator.com/book/phabcontrib/article/feature_requests/ regarding requesting features, specifically we just want to know the problem you are having with Phabricator.

chad renamed this task from "Merge Duplicates In" always feels like it's the wrong direction to Allow Merge Duplicates to work in either direction.Apr 14 2015, 1:09 AM
chad updated the task description. (Show Details)

@sshannin, I would also consider just having the Close As Duplicate pop a dialog to select the master task.

Yeah, that seems like the most intuitive thing to me.

chad added a comment.Apr 14 2015, 1:16 AM

Basically I agree that the triaging workflow of duplicates could be better, maybe this is two different tasks.

chad added a comment.Apr 14 2015, 1:53 AM

Filed T7820 as a separate task.

I don't think this makes sense separate from T7820.

The current dialog is a multi-select dialog, because it makes sense to merge multiple duplicates into a single destination at once. It doesn't make sense to go the other way (close one task as a duplicate of multiple other tasks), so there's no sensible way to adjust this dialog in a minor way to make it a "merge into" dialog: it's fundamentally a "merge here" dialog.

If we have to present the user with a modal choice anyway, the workflow described in T7820 seems preferable.

dgoldstein added a project: Restricted Project.Aug 3 2015, 10:28 PM
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 14 2015, 8:37 PM
urzds added a subscriber: urzds.Jul 12 2017, 11:09 AM