Page MenuHomePhabricator
Feed Advanced Search

Jul 30 2015

epriestley added a comment to T9021: Put User accounts in Spaces so some users can not see one another.

This isn't a priority, which means I don't want to spend time planning, reviewing, merging, or supporting it right now, not just developing it.

Jul 30 2015, 2:34 PM · Spaces
epriestley added a comment to T9019: Create a "Project Members" object policy for Projects.

Yes, but "Project Members" is not the same as "Members of associated projects", and I think we are unlikely to implement that in the upstream. You can implement it as an extension if you want that behavior.

Jul 30 2015, 2:30 PM · Projects, Policy
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

No, there's no overlap.

Jul 30 2015, 2:29 PM · People
epriestley added a comment to T9019: Create a "Project Members" object policy for Projects.

They're fairly recent (last couple of months).

Jul 30 2015, 2:22 PM · Projects, Policy
epriestley renamed T9021: Put User accounts in Spaces so some users can not see one another from Filter user lists by visible spaces to Put User accounts in Spaces so some users can not see one another.
Jul 30 2015, 2:20 PM · Spaces
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

It sounds like we could possibly resolve this by letting you change application edit policies instead, which I intend to do eventually. That said, I don't think adding an enable/disable policy is necessarily unreasonable, and it's generally in the vein of other similar policies.

Jul 30 2015, 2:19 PM · People
epriestley triaged T9019: Create a "Project Members" object policy for Projects as Low priority.
Jul 30 2015, 2:18 PM · Projects, Policy
epriestley renamed T9019: Create a "Project Members" object policy for Projects from Create a "members" object policy to Create a "Project Members" object policy for Projects.
Jul 30 2015, 2:17 PM · Projects, Policy
epriestley added a comment to T9019: Create a "Project Members" object policy for Projects.

A similar policy elsewhere is the Conpherence "Room Participants" object policy:

Jul 30 2015, 2:16 PM · Projects, Policy
epriestley added a comment to T9019: Create a "Project Members" object policy for Projects.

The "Subscribers" object policy is PhabricatorSubscriptionsSubscribersPolicyRule, which adds this thing:

Jul 30 2015, 2:16 PM · Projects, Policy
epriestley triaged T9021: Put User accounts in Spaces so some users can not see one another as Wishlist priority.
Jul 30 2015, 2:13 PM · Spaces
epriestley added a comment to T9021: Put User accounts in Spaces so some users can not see one another.

It's vaguely possible we may implement this eventually, but it's not going to happen any time soon and almost certainly not this year.

Jul 30 2015, 2:13 PM · Spaces
epriestley closed T9009: Cannot comment on Phurl links as Invalid.
Jul 30 2015, 2:10 PM · Phurl
epriestley added a comment to T9009: Cannot comment on Phurl links.

See T9022 / https://secure.phabricator.com/book/phabricator/article/prototypes/

Jul 30 2015, 2:10 PM · Phurl
epriestley closed T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route as Invalid.

I'm just going to close this and T9009 out under the "we know prototypes are super broken, wait until they unprototype before reporting bugs" rule, I think @lpriestley has a handle on it.

Jul 30 2015, 2:10 PM · Phurl
epriestley closed T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route, a subtask of T9009: Cannot comment on Phurl links, as Invalid.
Jul 30 2015, 2:10 PM · Phurl
joshuaspence created T9020: Clicking history button causes 404.
Jul 30 2015, 1:29 PM · Herald
joshuaspence created T9019: Create a "Project Members" object policy for Projects.
Jul 30 2015, 1:21 PM · Projects, Policy
joshuaspence added a project to T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets: Lint.
Jul 30 2015, 1:17 PM · Lint, Arcanist
joshuaspence awarded T9010: Allow badges to have any Font Awesome icon a Piece of Eight token.
Jul 30 2015, 1:14 PM · Badges
joshuaspence added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

A couple of things offhand:

Jul 30 2015, 1:10 PM · People
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

What specific administrator abilities are you concerned about them having?

Jul 30 2015, 12:19 PM · People
joshuaspence added a comment to T9018: "Highlight as" crashes Chrome on mobile devices.

The same thing happens when trying to select a different encoding.

Jul 30 2015, 10:36 AM · Mobile, Differential
joshuaspence created T9018: "Highlight as" crashes Chrome on mobile devices.
Jul 30 2015, 10:36 AM · Mobile, Differential
joshuaspence created T9017: "View options" menu not usable on mobile.
Jul 30 2015, 10:29 AM · PHUI, Differential, Mobile
joshuaspence created T9016: Weird CSS issue with inline comments.
Jul 30 2015, 10:26 AM · Badge Awarded, Differential, PHUI, Mobile
joshuaspence added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

I'd rather not. We have a lot of staff who manage access and most of them I don't want poking around as an admin.

Jul 30 2015, 8:04 AM · People
epriestley added a comment to T9012: Nag users who reply-all.

Notably, with metamta.one-mail-per-recipient, "Reply All" is the same as "Reply" (other recipients are not included on the mail). This is the default setting, is more secure, better respects policies, and better respects user preferences. A large class of problems are intractable if this setting is disabled.

Jul 30 2015, 5:55 AM · llvm, Mail, Restricted Project
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

Can you just give more users admin permissions?

Jul 30 2015, 5:50 AM · People
joshuaspence created T9015: Allow user account enable/disable to be a delegatable to non admins.
Jul 30 2015, 5:14 AM · People
sharwell awarded T731: Allow revisions to have alternate acceptance conditions a Love token.
Jul 30 2015, 3:09 AM · Restricted Project, Restricted Project, Differential
sharwell awarded T1279: Show per-reviewer status in Differential revision reviewer list a Like token.
Jul 30 2015, 3:09 AM · Restricted Project, Differential
sharwell awarded T4887: Extend the blocking reviewers functionality universally a Like token.
Jul 30 2015, 3:08 AM · Restricted Project, Differential, Herald

Jul 29 2015

epriestley closed T9003: Herald rule not working as Resolved.

In any case, glad to hear this is working now! I think the UI should improve pretty soon (next week or two-ish) for this specific class of problem, at least. Let us know if you run into anything else.

Jul 29 2015, 11:41 PM · Herald, Phacility Support
epriestley added a comment to T9003: Herald rule not working.

Upcoming changes related to T5791 and T8726 should increase debug-ability, but giving web users access to mail is tricky while still respecting policies (e.g., administrators shouldn't be able to violate policies by just reading other users mail) and limiting the ability for an attacker to escalate access (e.g., an attacker who gets an admin account shouldn't have a blank check to access every other account by reading other users' "Welcome" or "Password Reset" mail).

Jul 29 2015, 11:39 PM · Herald, Phacility Support
epriestley added a comment to T9005: Accessing Files via links should be more like the @userx mouseover dialog.

What kind of files are you downloading? Are these PDFs? Text files? Something else?

Jul 29 2015, 11:21 PM · Files
epriestley added a comment to T9009: Cannot comment on Phurl links.

Probably a getApplicationURI('phurl/x/') which should be getApplicationURI('x/').

Jul 29 2015, 11:20 PM · Phurl
epriestley updated subscribers of T9009: Cannot comment on Phurl links.
Jul 29 2015, 11:20 PM · Phurl
epriestley added a comment to T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.

char in Arcanist means "byte". If your linter works in UTF8-character offsets, you should convert them to byte offsets before passing messages up to Arcanist.

Jul 29 2015, 11:18 PM · Lint, Arcanist
epriestley added a comment to T9003: Herald rule not working.

Specifically, you could get the behavior you want by changing the visibility policy of the task (so the user can see it) or adding the user to the project (so they satisfy the current visibility policy).

Jul 29 2015, 11:03 PM · Herald, Phacility Support
epriestley added a comment to T9003: Herald rule not working.

It looks like T1603 on your install has a project visibility policy (i.e., the task is visible to members of a specific project). However, I think the user customer_support_pagerduty is not a member of the project, so they can not see the task. (I'm just looking at the database here, so it's possible I got the WHERE clauses wrong.)

Jul 29 2015, 11:02 PM · Herald, Phacility Support
marklu awarded T8089: Unprototype Harbormaster (v1) a Love token.
Jul 29 2015, 10:46 PM · Prioritized, Harbormaster
epriestley added a comment to T9004: Ability to differentiate differential comments.

(And using only color to convey intent may create difficulty for users with low vision or colorblindness.)

Jul 29 2015, 8:07 PM · Differential
epriestley added a comment to T9004: Ability to differentiate differential comments.

Yeah, something generally in that vein seems like a good approach to me. It's much more flexible in terms of conveying intent (you can pick as many different emoji as your team needs/wants) and in terms of process (you don't need to explicitly fiddle with anything if your comment is unambiguous, like maybe pointing out a typo on a documentation change submitted by someone you know well and regularly work closely with).

Jul 29 2015, 8:06 PM · Differential
epriestley added a comment to T9004: Ability to differentiate differential comments.

Can you provide some more context, or examples of the kinds of comments that are ambiguous?

Jul 29 2015, 7:56 PM · Differential
epriestley added a comment to T9003: Herald rule not working.

Here's why you didn't receive the mail:

Jul 29 2015, 7:44 PM · Herald, Phacility Support
epriestley added a comment to T9003: Herald rule not working.

I can't reproduce this. I made this rule:

Jul 29 2015, 7:40 PM · Herald, Phacility Support
epriestley closed T9001: test as Invalid.
Jul 29 2015, 10:48 AM · Conpherence
epriestley closed T9001: test, a subtask of T9000: Not entering a Name for a room loses the First Message section, as Invalid.
Jul 29 2015, 10:48 AM · Conpherence
epriestley added a comment to T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given.

(See D13739.)

Jul 29 2015, 1:24 AM · People
epriestley closed T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given as Resolved.

Fixed in HEAD.

Jul 29 2015, 1:23 AM · People
epriestley updated subscribers of T5258: Memes use older image transform code without modern error handling.
Jul 29 2015, 1:23 AM · Restricted Project, Macros, Files
epriestley merged task T8997: Duplicate entry for key 'originalPHID' into T5258: Memes use older image transform code without modern error handling.
Jul 29 2015, 1:23 AM · Macros
joshuaspence created T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given.
Jul 29 2015, 1:23 AM · People
joshuaspence created T8998: array_flip(): Can only flip STRING and INTEGER values!.
Jul 29 2015, 1:21 AM · Differential
joshuaspence created T8997: Duplicate entry for key 'originalPHID'.
Jul 29 2015, 1:20 AM · Macros

Jul 28 2015

joshuaspence added a comment to T8590: Send outbound email when task is created via inbound email.

Yeah, I guess that works.

Jul 28 2015, 9:57 PM · Maniphest, Mail
joshuaspence added a comment to T8590: Send outbound email when task is created via inbound email.

Ah yeah... I have self emails disabled. I dislike self-emails when creating a task through the web UI, but I would see value in having self-emails when I create a task via email (because otherwise I have no idea if it actually worked)

Jul 28 2015, 9:43 PM · Maniphest, Mail
epriestley closed T8988: Test Email Bug as Resolved.
Jul 28 2015, 7:56 PM
epriestley added a comment to T8590: Send outbound email when task is created via inbound email.

Yeah, here's an example email I receive when sending mail to bugs@phabricator.com:

Jul 28 2015, 7:56 PM · Maniphest, Mail
epriestley created T8988: Test Email Bug.
Jul 28 2015, 7:55 PM
epriestley created T8987: Make "Contact Name" and "Contact Email" more clear in Legalpad corporate documents.
Jul 28 2015, 7:50 PM · Restricted Project, Restricted Project
epriestley closed T8984: Text files containing string "code" aren't allowed to upload via drag-n-drop as Resolved by committing Restricted Diffusion Commit.
Jul 28 2015, 3:04 PM · Files
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Jul 28 2015, 2:45 PM
epriestley added a revision to T8984: Text files containing string "code" aren't allowed to upload via drag-n-drop: Unknown Object (Differential Revision).
Jul 28 2015, 2:45 PM · Files
epriestley added a comment to T8984: Text files containing string "code" aren't allowed to upload via drag-n-drop.

(Removing Security since this isn't a security vulnerability.)

Jul 28 2015, 2:36 PM · Files
epriestley removed a project from T8984: Text files containing string "code" aren't allowed to upload via drag-n-drop: Security.
Jul 28 2015, 2:35 PM · Files
epriestley renamed T8980: Make hovecards activate for standard handle lists from Hover text explaining what the meaning of a red/grey dot next to a username to Make hovecards activate for standard handle lists.
Jul 28 2015, 2:15 PM · Hovercards, Calendar
epriestley added a comment to T8980: Make hovecards activate for standard handle lists.

We should probably just get hovercards activating in more places; I think there's a task for that (or at least some discussion) somewhere. For example, they don't activate for "Author" / "Subscribers" here in Maniphest, but I think there's no technical reason they couldn't.

Jul 28 2015, 2:14 PM · Hovercards, Calendar
epriestley placed T8983: Tickboxes are unavailable within tables up for grabs.
Jul 28 2015, 2:13 PM · Remarkup
epriestley added a comment to T8983: Tickboxes are unavailable within tables.

See some prior discussion in T3945.

Jul 28 2015, 2:13 PM · Remarkup
joshuaspence added a project to T8978: cslint, used by CSharpArcanistLinter, will be deprecated and replaced in the future: Lint.
Jul 28 2015, 8:39 AM · Lint, Arcanist
epriestley awarded C141: My Birthday a Piece of Eight token.
Jul 28 2015, 12:15 AM
epriestley added a comment to C141: My Birthday.

hahaha

Jul 28 2015, 12:15 AM

Jul 27 2015

epriestley added a comment to T8977: Unable to push to repo on Phacility due to pre-receive hook failing because of Herald exception.

I think this should be fixed now, let me know if you're still seeing issues?

Jul 27 2015, 11:34 PM · Diffusion, Herald, Phacility Support
epriestley added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

I cherry-picked this to stable and upgraded the cluster.

Jul 27 2015, 10:18 PM · People
epriestley added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

Do we have a "helpful bug report" badge?

Jul 27 2015, 10:15 PM · People
epriestley closed T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist) as Resolved by committing Restricted Diffusion Commit.
Jul 27 2015, 10:08 PM · Mailing Lists, Herald, Installing & Upgrading
epriestley renamed T8973: Encoding JSON for presentation could use more human-friendly escaping rules from Instance Configuration Improperly Escapes Characters to Encoding JSON for presentation could use more human-friendly escaping rules.
Jul 27 2015, 9:28 PM · Customer Impact
epriestley added a comment to T8973: Encoding JSON for presentation could use more human-friendly escaping rules.

This is a valid, compliant JSON-encoding of the string, which allows / to be escaped -- here's the grammar diagram from json.org:

Jul 27 2015, 9:27 PM · Customer Impact
epriestley added a revision to T8921: arc diff failing due to "invalid type" error: Unknown Object (Differential Revision).
Jul 27 2015, 4:41 PM · Arcanist
epriestley added a comment to T8921: arc diff failing due to "invalid type" error.

Aha! That's a different error:

Jul 27 2015, 4:31 PM · Arcanist
epriestley added a revision to T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist): Unknown Object (Differential Revision).
Jul 27 2015, 2:54 PM · Mailing Lists, Herald, Installing & Upgrading
epriestley claimed T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist).
Jul 27 2015, 2:46 PM · Mailing Lists, Herald, Installing & Upgrading
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Okay, so suppose we decide this represents a flaw in the linter and a user does accidentally write two linters which are "flawed" by suggesting strictly conflicting patches. Maybe they just made a mistake, or maybe they enabled two different linters which they didn't realize have conflicting behaviors, or maybe they intuitively think the rules for deciding which message wins should be different (for example: use the stronger severity; or use the first message raised; or use the message from the first declared linter; or use the message with the shorter replacement text). Or we add a special priority field for this and both messages have the same priority. What should the behavior be?

Jul 27 2015, 1:52 PM · Restricted Project, Arcanist
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Suppose the patches literally suggest changing "A" to "B":

Jul 27 2015, 1:38 PM · Restricted Project, Arcanist
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

When a linter emits two strictly conflicting patches ("Change A to B", "Change A to C"), what behavior do you expect as a user?

Jul 27 2015, 1:28 PM · Restricted Project, Arcanist
joshuaspence added a comment to T8970: Ability to draft/archive Phriction documents.

That would work but I guess.

Jul 27 2015, 7:44 AM · Phriction
joshuaspence created T8970: Ability to draft/archive Phriction documents.
Jul 27 2015, 12:20 AM · Phriction

Jul 26 2015

epriestley added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

See T7962 and T8054 for previous requests to describe problems.

Jul 26 2015, 8:06 PM · FreeBSD, Phriction, Herald
epriestley closed T8965: Task1 as Invalid.
Jul 26 2015, 1:19 PM
joshuaspence added projects to T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist): Herald, Mailing Lists.
Jul 26 2015, 9:58 AM · Mailing Lists, Herald, Installing & Upgrading
joshuaspence added a member for Phurl: joshuaspence.
Jul 26 2015, 3:48 AM
joshuaspence created T8964: Alignment issue with long titles.
Jul 26 2015, 3:46 AM · Mobile, PHUI
joshuaspence added a comment to Elite Contributor.

Oh cool, I haz badge.

Jul 26 2015, 1:40 AM

Jul 25 2015

joshuaspence awarded T8726: Modularize Herald fields and actions a Mountain of Wealth token.
Jul 25 2015, 11:29 PM · Herald
joshuaspence added a revision to T8929: Arcanist glitch for `arc help ---full`: Unknown Object (Differential Revision).
Jul 25 2015, 11:27 PM · Arcanist
epriestley closed T8960: Unhandled exception prevents viewing instance member list on Phacility as Resolved.

This was fixed in master, I just missed promoting it to stable since the release schedule has been out of whack recently. Should be fixed now.

Jul 25 2015, 6:13 PM · People, Phacility
epriestley edited the content of Phacility Cluster CLI Tools.
Jul 25 2015, 6:11 PM
epriestley added a comment to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.

Yeah, I don't think it's terrible since it should happen very rarely if we do "don't generate" too, and no matter how clever we are it's unavoidable in some cases (even if we policy filter, we might send down a "3", and then by the time the user actually opens the menu or clicks the bell they can no longer see one of them).

Jul 25 2015, 2:43 PM · Wikimedia, Notifications