Page MenuHomePhabricator
Create Task
Maniphest T8976

InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false
Closed, ResolvedPublic
Actions

Description

By default, policy.allow-public is set to false. Based on what I'm seeing here, the value for $note would be null when it's passed to the view on line 87, resulting in this stack trace:

stack_trace.log2 KBDownload

Steps to reproduce:

  1. Set policy.allow-public to false (as it is out of the box)
  2. Attempt to edit your profile

Assigned this to the author of the offending commit. Apologies if that's against protocol.

Revisions and Commits

rP Phabricator
D13739rP535c1a5f255e (stable) Fix public/private profile edit note
D13739rP84049e6d075b Fix public/private profile edit note

Event Timeline

cjoslin created this task.Jul 27 2015, 9:49 PM
cjoslin assigned this task to chad.
cjoslin raised the priority of this task from to Needs Triage.
cjoslin updated the task description. (Show Details)
cjoslin added a project: People.
cjoslin added a subscriber: cjoslin.
Herald added a subscriber: eadler. · View Herald TranscriptJul 27 2015, 9:49 PM
chad added a revision: D13739: Fix public/private profile edit note.Jul 27 2015, 10:04 PM
chad closed this task as Resolved by committing rP84049e6d075b: Fix public/private profile edit note.Jul 27 2015, 10:12 PM
chad added a commit: rP84049e6d075b: Fix public/private profile edit note.
chad added a comment.Jul 27 2015, 10:12 PM

33dcfda6c3439a1ab9fbcbaa4280edaf.jpg (360×600 px, 26 KB)

epriestley added a commit: rP535c1a5f255e: (stable) Fix public/private profile edit note.Jul 27 2015, 10:12 PM
epriestley added a subscriber: epriestley.Jul 27 2015, 10:15 PM

Do we have a "helpful bug report" badge?

epriestley added a comment.Jul 27 2015, 10:18 PM

I cherry-picked this to stable and upgraded the cluster.

cjoslin added a comment.Jul 27 2015, 10:24 PM
In T8976#128505, @epriestley wrote:

Do we have a "helpful bug report" badge?

I'm a software developer myself, so I did my best to provide the kind of report I'd want to receive. If I weren't so totally clueless as a PHP developer, I'd have done this is a pull request within GitHub instead.

Thanks for the great product and speedy turnaround, guys! Keep up the great work.

chad added a comment.Jul 27 2015, 10:25 PM

You have been anointed "Bug Meister"

Phabricator · Built by Phacility