Page MenuHomePhabricator
Feed Advanced Search

Mar 3 2017

cspeckmim renamed T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Relative links to Phriction pages mis-encode URL-encoded characters to Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:15 AM · Phriction, Remarkup, Bug Report
cspeckmim created T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:13 AM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

Workaround is to URL-encode the parenthesis (%29) or use the remarkup style

[Back to the Future](https://en.wikipedia.org/wiki/Starship_Troopers_(film%29)
[[ https://en.wikipedia.org/wiki/Starship_Troopers_(film) | Jurassic Park ]]

Results in:
[Back to the Future](https://en.wikipedia.org/wiki/Starship_Troopers_(film%29)
Jurassic Park

Mar 3 2017, 2:58 AM · Remarkup, Bug Report
cspeckmim added a comment to T12335: Ability to lock a task to prevent further edits.

One use case for "locking" a task could be:

  1. For a release of the software product all tasks which represent the software changes on the version being released require review
  2. Reviewer looks over task form fields and if everything looks good, "signs" (locks) the task in a "reviewed" state
  3. Tasks can be unsigned prior to release of the version, allowing updates to tasks as necessary but also requiring another review
  4. Upon release of the version, tasks can no longer be unsigned
Mar 3 2017, 2:38 AM · Maniphest, Feature Request
chad added Q581: How do you install and set up Phabricator on a existing, hosted website? (Answer 521).
Mar 3 2017, 2:02 AM
ssapp updated Q581: How do you install and set up Phabricator on a existing, hosted website? from to How do you install and set up Phabricator on a existing, hosted website?.
Mar 3 2017, 1:40 AM
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

We've implemented a basic version of this, roughly along the lines of the recommendation above. Here's how it works:

Mar 3 2017, 1:23 AM · Maniphest, Feature Request
epriestley closed T11207: User can change properties on the task, even when not having edit policy rights as Resolved by committing Restricted Diffusion Commit.
Mar 3 2017, 12:57 AM · Restricted Project, Policy, Bug Report

Mar 2 2017

eliaspro created T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.
Mar 2 2017, 10:48 PM · Remarkup, Bug Report
ofbeaton created T12342: conduit project.search by slug, and return image.
Mar 2 2017, 10:44 PM · Feature Request
eliaspro added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

Ok, then feel free to dismiss this one… I didn't expect those kind of complexities behind this :)

Mar 2 2017, 10:39 PM · Feature Request (Needs Information)
chad added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

Yeah any typeahead dialog now that I think about it.

Mar 2 2017, 10:08 PM · Feature Request (Needs Information)
epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

(I think I've used this workflow fewer than 5 times outside of testing, and although similar workflows like "Award Badge" and "Add Project Members" have the same issue, I think they're similarly rare.)

Mar 2 2017, 9:49 PM · Feature Request (Needs Information)
epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

This is also nontrivial: when we display a dialog, we already attempt to focus the first input. But the first input here is a tokenizer, not a real input, and naively focusing it fails because it hasn't activated or rendered yet.

Mar 2 2017, 9:48 PM · Feature Request (Needs Information)
chad updated the task description for T12270: Unbeta Badges.
Mar 2 2017, 9:47 PM · Badges (v0)
chad edited projects for T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown, added: Feature Request (Needs Information); removed Feature Request.
Mar 2 2017, 9:41 PM · Feature Request (Needs Information)
chad added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

Specifically, I've never used this workflow. So I don't see any obvious benefit to spending upstream time on it, and the task will sit here until others maybe chime in and we can get a sense of it's impact. This seems like an obvious request, but maybe tools like Nuance (help desk) make the workflow you use today, obsolete, so then we'd also not worry about implementing this at all.

Mar 2 2017, 9:40 PM · Feature Request (Needs Information)
chad added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

We'll take a patch if you like, but if you're filing a feature request, you still need to follow Contributing Feature Requests and Describing Root Problems.

Mar 2 2017, 9:35 PM · Feature Request (Needs Information)
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 2 2017, 9:27 PM · Maniphest, Feature Request
eliaspro created T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.
Mar 2 2017, 9:12 PM · Feature Request (Needs Information)
epriestley added a comment to T11207: User can change properties on the task, even when not having edit policy rights.

D17452 marks this as resolved and makes these changes:

Mar 2 2017, 8:38 PM · Restricted Project, Policy, Bug Report
epriestley added a revision to T11207: User can change properties on the task, even when not having edit policy rights: Unknown Object (Differential Revision).
Mar 2 2017, 8:33 PM · Restricted Project, Policy, Bug Report
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 2 2017, 8:33 PM · Maniphest, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

A basic version of this is now available in HEAD of master. Here's a walkthrough of what we've implemented and a discussion of some areas where we'd like feedback.

Mar 2 2017, 7:19 PM · EditEngine, Maniphest, Custom Fields, Feature Request
remusvrm closed Q580: Is there a way to have a button for sending messages in the Room chat, not through Enter? as resolved.
Mar 2 2017, 6:00 PM
epriestley closed T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed") as Resolved.

Closing this since there doesn't seem to be any thing left that's actionable for us.

Mar 2 2017, 5:29 PM · Guides, Security
jasongilanfarr awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Mar 2 2017, 4:11 PM · Restricted Project, Restricted Project, Differential
chad added Q580: Is there a way to have a button for sending messages in the Room chat, not through Enter? (Answer 520).
Mar 2 2017, 3:30 PM
remusvrm updated Q580: Is there a way to have a button for sending messages in the Room chat, not through Enter? from to Is there a way to have a button for sending messages in the Room chat, not through Enter?.
Mar 2 2017, 3:25 PM
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:09 PM · EditEngine, Maniphest, Custom Fields, Feature Request
urzds added a comment to T12174: Home Menu Errata.
In T12174#213854, @chad wrote:

It's not hard to add, just curious what the use case is. Most requests have been to "rename" the applications (Differential -> Code Review"), so pulling in built-in tooltips didn't make sense. Maybe we should add tooltip to the "Link" menu type for best flexibility.

Mar 2 2017, 12:44 PM · Dashboards (v2), Profile Menu Item
remusvrm added a comment to Q579: Way there are not configuration in "Email Preferences" for "Rooms"? (Answer 519).

Thanks for the answer! I didn't expected to be in a different location.

Mar 2 2017, 10:56 AM
remusvrm closed Q579: Way there are not configuration in "Email Preferences" for "Rooms"? as resolved.
Mar 2 2017, 10:55 AM
MZMcBride added a comment to T11989: Wage an endless war against HP Printer Fax Support.

Press F to pay respects.

Mar 2 2017, 5:50 AM · Abuse
cspeckmim added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

I like the idea of a feed/panel that shows recently active objects and not the individual events, but I don't know that I have a specific use case for it now. For how I use feed I think being able to filter out commits would be a nifty plus, as those tend to pollute the feed during arc land activity (and comments in tow). I don't think I feel too strongly about it right now though, as most of my work is driven via email activity and I primarily use Feed as a means of discoverability so I can poke my head in if something sounds interesting~

Mar 2 2017, 5:49 AM · Dashboards, Bug Report
chad updated Participant flavor text from Flimsy Cardboard to Thin Cardboard.
Mar 2 2017, 3:30 AM
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 2 2017, 3:21 AM · Badges (v0)
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 2 2017, 3:08 AM · Badges (v0)
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 2 2017, 3:06 AM · Badges (v0)
epriestley merged T12340: Exclude refs/pull/* from being tracked in observed repo into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Mar 2 2017, 2:51 AM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley merged task T12340: Exclude refs/pull/* from being tracked in observed repo into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Mar 2 2017, 2:51 AM · Diffusion, Feature Request
chad added a revision to T10798: Limit, order recipients list in BadgeView: Unknown Object (Differential Revision).
Mar 2 2017, 2:25 AM · Badges (v0), Contributor Onboarding, Restricted Project
Mnkras created T12340: Exclude refs/pull/* from being tracked in observed repo.
Mar 2 2017, 1:59 AM · Diffusion, Feature Request
epriestley added a revision to T6064: One-Click Add Task on Workboard Columns: Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · Restricted Project, Workboards
epriestley added a revision to T11580: Tasks created from workboards frequently have to be edited to add properties common to all tasks on the workboard: Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · Workboards, EditEngine, Projects, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:04 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:52 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:40 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:08 AM · EditEngine, Maniphest, Custom Fields, Feature Request

Mar 1 2017

epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:42 PM · EditEngine, Maniphest, Custom Fields, Feature Request
ejbevenour added a watcher for Phortune: ejbevenour.
Mar 1 2017, 11:27 PM
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:24 PM · EditEngine, Maniphest, Custom Fields, Feature Request
monufer added a comment to T12334: Arc land is not enforcing Herald Rule.

Thanks for the information @epriestley.

Mar 1 2017, 11:03 PM · Bug Report
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:01 PM · EditEngine, Maniphest, Custom Fields, Feature Request
rphl added a comment to T12174: Home Menu Errata.

thanks for the hint

Mar 1 2017, 10:50 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T10319: Generate unique? profile images for each new user.

Yeah everywhere I look at doing this seems exceedingly hacky. Writing a profile image the first time PhabricatorUser->getDefaultPictureURI doesn't seem right, but I don't seen any other lazy way of doing this outside of user creation.

Mar 1 2017, 10:49 PM · Feature Request, People
chad added a comment to T12174: Home Menu Errata.

Though I guess we need the icon typeahead there.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Alternatively, use "Link" and make whatever you want.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

That's the default behavior, and you can achieve it by deleting "Name":

Mar 1 2017, 10:47 PM · Dashboards (v2), Profile Menu Item
rphl added a comment to T12174: Home Menu Errata.

It would be nice if we could have tooltips for Apps, etc. too

Mar 1 2017, 10:45 PM · Dashboards (v2), Profile Menu Item
cos added a comment to T12335: Ability to lock a task to prevent further edits.

I can confirm that advisory locking is acceptable. Locking the whole task is preferable, but we can live with comments not being locked. Thanks!

Mar 1 2017, 10:38 PM · Maniphest, Feature Request
cos added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

sure, I'm fine with letting the dust settle after these changes and deciding then. The edge.search approach would be totally fine since I'm writing a custom client, also, the attachment approach would work since our set of related tasks will be small for the foreseeable future.

Mar 1 2017, 10:37 PM · Feature Request
chad merged task T12339: Dashboard show odd header at the bottom of the screen into T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Bug Report
chad merged T12339: Dashboard show odd header at the bottom of the screen into T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
chad updated the task description for T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
faulconbridge closed T12338: Paste line counts incorrect if content is more than 1024 characters as Resolved by committing Restricted Diffusion Commit.
Mar 1 2017, 10:30 PM · Bug Report
epriestley added a comment to T12334: Arc land is not enforcing Herald Rule.

You can set history.immutable to true in your repository to prevent arc from performing mutation operations (amends, squash-merges).

Mar 1 2017, 10:30 PM · Bug Report
chad closed T12339: Dashboard show odd header at the bottom of the screen as Invalid.

Not a bug.

Mar 1 2017, 10:30 PM · Bug Report
jcarrillo7 created T12339: Dashboard show odd header at the bottom of the screen.
Mar 1 2017, 10:10 PM · Bug Report
faulconbridge added a revision to T12338: Paste line counts incorrect if content is more than 1024 characters: Unknown Object (Differential Revision).
Mar 1 2017, 9:27 PM · Bug Report
faulconbridge created T12338: Paste line counts incorrect if content is more than 1024 characters.
Mar 1 2017, 9:18 PM · Bug Report
avivey added a comment to T12334: Arc land is not enforcing Herald Rule.

I don't think there's any way to check for that via Herald. There's the Land Revision button( T182), which I ❤, but it's still a prototype and has some surprising behavior built into it (If you're doing anything complex, it can sometime land stuff you didn't want it to).

Mar 1 2017, 9:03 PM · Bug Report
chad added a comment to T12174: Home Menu Errata.

You can now add tooltips adhoc to "Link" menu items.

Mar 1 2017, 7:58 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T10319: Generate unique? profile images for each new user.
  • Generate the image in the Query, not when the user is created (helps with old users and not having to update a ton of different ways users can get created, and not generating these as side effects during unit tests).
Mar 1 2017, 7:31 PM · Feature Request, People
chad added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Mar 1 2017, 7:07 PM · Dashboards (v2), Profile Menu Item
nicolas17 added a member for KDE: nicolas17.
Mar 1 2017, 6:36 PM
chad added Q579: Way there are not configuration in "Email Preferences" for "Rooms"? (Answer 519).
Mar 1 2017, 6:30 PM
chad added a comment to T12334: Arc land is not enforcing Herald Rule.

arc land mutates the code (adds details, squashes), so it's not possible. I'd recommend restricting who can land code and have the accepted reviewers manually land with "Land Revision" from the web ui. In general we expect people to trust co-workers, or use Audit for post-commit coverage.

Mar 1 2017, 6:11 PM · Bug Report
remusvrm updated Q579: Way there are not configuration in "Email Preferences" for "Rooms"? from to Way there are not configuration in "Email Preferences" for "Rooms"?.
Mar 1 2017, 6:05 PM
chad added a comment to Q575: Why the Project Bar in Maniphest can't be hidden anymore? (Answer 516).

We plan to let you bookmark / shortcut the fullscreen version of the workboard.

Mar 1 2017, 6:04 PM
remusvrm added a comment to Q574: How to add large files into Phabricator? (Answer 517).

Thanks for the answer! I need to check all the configuration and get back to you if still doesn't work.

Mar 1 2017, 6:00 PM
remusvrm closed Q575: Why the Project Bar in Maniphest can't be hidden anymore? as resolved.
Mar 1 2017, 5:59 PM
remusvrm added a comment to Q575: Why the Project Bar in Maniphest can't be hidden anymore? (Answer 516).

hhhmmm, not too many keyboard shortcuts ...
I used the full-screen option all day, but I think it's more time consuming... was better before when you hide it. In any case 99% of the time you look at the workboard.

Mar 1 2017, 5:59 PM
chad closed T12334: Arc land is not enforcing Herald Rule as Invalid.

(Going to close since this isn't a bug report. My mistake on reading the reproduction steps, @avivey has better eyes than I)

Mar 1 2017, 5:55 PM · Bug Report
monufer added a comment to T12334: Arc land is not enforcing Herald Rule.

@avivey Thank you for the explanation!

Mar 1 2017, 5:44 PM · Bug Report
chad closed T12330: Subprojects link not grayed out in dark background of project workboards. as Resolved by committing Restricted Diffusion Commit.
Mar 1 2017, 5:20 PM · Workboards, Projects, Bug Report
chad added a comment to T10319: Generate unique? profile images for each new user.

Macro psyduck: RIP PSYDUCK NEVER FORGET

Mar 1 2017, 5:17 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

Yeah I think having some bin/profileimage script for pre-generation would be good for admins like here so you can pre-run the migration separate from enabling.

Mar 1 2017, 5:16 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

Yeah, I just want to find a way product side to always ensure good profile images are used. I'm fine having some fallback, if 100% needed, but it makes me really uncomfortable having different experiences or lessened experiences if avoidable.

Mar 1 2017, 5:13 PM · Feature Request, People
mavit awarded T8783: Unprototype Nuance (v1) a Like token.
Mar 1 2017, 5:04 PM · Nuance, Restricted Project
epriestley added a comment to T10319: Generate unique? profile images for each new user.

(And, if our behavior is "confusing fatal", that could prevent new installs from getting far enough to even see the setup warning saying "install gd".)

Mar 1 2017, 5:00 PM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think all the other requirements are usually builtin (we "require" them only because it's possible to remove them, and some distros occasionally do for kind-of-maybe-questionable reasons) but I think it's basically like requiring your car to have tires.

Mar 1 2017, 4:58 PM · Feature Request, People
johnny-bit awarded T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users a Like token.
Mar 1 2017, 4:50 PM · Profile
chad added a comment to T10319: Generate unique? profile images for each new user.

Why not require GD outright? Seems like a drop in the bucket with all other requirements and leads to confusion later like with projects or macros

Mar 1 2017, 4:47 PM · Feature Request, People
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

This runs into T5873, which is a large task. The very short version is:

Mar 1 2017, 4:44 PM · Feature Request
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think the NUX case is fairly tricky. I need to look at the code, but I'm thinking something like:

Mar 1 2017, 4:31 PM · Feature Request, People
cos created T12337: Provide conduit access to related tasks and in particular 'mentions'.
Mar 1 2017, 4:16 PM · Feature Request
epriestley closed T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website as Wontfix.

Cool, sounds good.

Mar 1 2017, 4:02 PM · Auth, Feature Request
cos added a comment to T12335: Ability to lock a task to prevent further edits.

Q. Common or rare?
A. Common - we'd lock all tasks before a release.
Q. Lock comments? Do you need to lock comments too, or just other types of edits (like status, priority, title, description, etc)?
A. I'm ambivalent about this, if the lock is mandatory then being able to add comments seems reasonable since someone can point out that the task needs to be unlocked for some reason or other.
Q. In particular, could a solution where anyone could unlock the task be acceptable, as long as they had to explicitly unlock it? Or is it a hard regulatory requirement that unlocking requires some sort of administrator/oversight step?
A. Unclear, I'll ask, but it's probably fine since there's also a 'process' that states how people use the system. (And you'd be surprised how much drama there is inside private companies:-) That is, our conventions are formally documented and people expected (and expect) to follow them.
Q. Lock other objects?
A. Possibly, but I've been pushing back on it for things like code reviews by arguing that 'everything is logged and there's an audit trail' so what does a lock by us? Obviously locking git doesn't really make sense and new comments can't hide old ones so I don't see what the problem is. For tasks, I don't feel I can make that argument since people will naturally just look at the current state of the task unlike code reviews where the history is 'in your face' as it were.

Mar 1 2017, 3:54 PM · Maniphest, Feature Request