Page MenuHomePhabricator
Create Task
Maniphest T12330

Subprojects link not grayed out in dark background of project workboards.
Closed, ResolvedPublic
Actions

Description

This is a minor aesthetics bug.

If a project does not utilize Sub-projects, it is normally grayed out.
However if a work-board is created for that project with a dark background, all links look the same.

As seen in pictures below. This work-board is using "Depths "

pasted_file (168×212 px, 8 KB)
pasted_file (175×210 px, 20 KB)

Versions: (Latest Stable as of Today (2/27/2017) )

phabricatorc8f5fb120573f6b1a001ba78f4f8f5bc1c453e43 (Fri, Feb 24)(branched from c15501fc9b06f46a699bcded6d2e14c5c48af2db on origin)
arcanist822bc53ca306e06314560d8a76f68771d732e8e0 (Fri, Feb 24)(branched from 3b6b523c2b236e3724a1e115f126cb6fd05fa128 on origin)
phutile3381770af0fa8a01ca1e1078b041c00c7baab5a (Sat, Feb 25)(branched from 0625e4d28b16cba8b0154e49dc31845559b4e704 on origin)

Revisions and Commits

rP Phabricator
D17436rPbf0a7cbec692 Remove "disabled" look to subprojects/workboard nav items

Related Objects

Event Timeline

borna.emami created this task.Feb 28 2017, 6:42 AM
Herald added a subscriber: eadler. · View Herald TranscriptFeb 28 2017, 6:42 AM
chad added a subscriber: chad.Feb 28 2017, 6:52 AM

Do you think it makes sense to grey out "Subprojects" at all or have a tab for it when there are no subprojects?

borna.emami added a comment.EditedFeb 28 2017, 7:20 AM
In T12330#213674, @chad wrote:

Do you think it makes sense to grey out "Subprojects" at all or have a tab for it when there are no subprojects?

Well, generally grayed out implies the tab not being clickable which is not the case here.
I'd be in favor of removing the tab if no subprojects/milestones exists. This is the case for the majority of the projects on my instance.
Now how would one add a subproject when the tab is not there? Could be placed under the manage section maybe?

chad added a subscriber: epriestley.Feb 28 2017, 8:44 PM

@epriestley any objection to removing the "disabled" look here for workboards and subprojects? It's not a consistent pattern with "no permission" we usually use.

epriestley added a comment.Feb 28 2017, 8:49 PM

Go for it.

chad added a revision: D17436: Remove "disabled" look to subprojects/workboard nav items.Mar 1 2017, 1:14 AM
chad closed this task as Resolved by committing rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items.Mar 1 2017, 5:20 PM
chad added a commit: rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items.
Phabricator · Built by Phacility