Page MenuHomePhabricator
Feed Advanced Search

Nov 29 2016

hach-que added a comment to T11925: Set niceity levels of background processes: git diff sometimes appears to thrash disk I/O and CPU from background worker.

Separately I managed to grab this output from top at an impacted time, but this looks to be a different issue now since the CPU time is being reported against the taskmasters themselves:

Nov 29 2016, 11:34 PM · Feature Request
epriestley edited the content of Phacility Cluster Devices.
Nov 29 2016, 9:55 PM
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

That didn't seem to be the case. It might have been because we only enforced Google authentication around one year ago, before that users could use a password for authentication. I can check later today, but perhaps the users that ended up with duplicate accounts never setup Google Auth.

Nov 29 2016, 9:42 PM · NUX, Auth
epriestley added a comment to T11930: Users don't realise that they must link their account.

If the only way to register is Google, it should be impossible to create more than one account per Google account.

Nov 29 2016, 9:37 PM · NUX, Auth
epriestley added a comment to T11930: Users don't realise that they must link their account.

Why is registration disabled?

Nov 29 2016, 9:36 PM · NUX, Auth
joshuaspence added a project to T11930: Users don't realise that they must link their account: NUX.
Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

To provide some additional context, we originally allowed users to register their own accounts, but we eventually disabled this because we ended up with around 30 duplicate accounts (users with more than one account). I think that this happened because users had listed an alias address in their Phabricator settings, but Google was using a canonical email address to authenticate, which didn't map to any existing user accounts (we have a lot of users that have aliases set up. For example, abraham@mycompany.com would be an alias for the canonical alincoln@mycompany.com address).

Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence created T11930: Users don't realise that they must link their account.
Nov 29 2016, 9:32 PM · NUX, Auth
chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 8:44 PM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

This one is fine, I'm still going to fiddle with "in" too.

Nov 29 2016, 8:36 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
aklapper added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

In https://phabricator.wikimedia.org/T76732#2803813 ksmith brings up that

In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option.
When editing a task and entering tags, autocomplete does bring up Maps and Discovery as the first items.

but that could be a separate (unprioritized) task I guess.

Nov 29 2016, 8:35 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T11929: Merge in duplicates doesn't contain latest tasks as Resolved by committing Restricted Diffusion Commit.
Nov 29 2016, 8:15 PM · Bug Report, Maniphest
rsolomon added a comment to T9262: Community and Upstream interests for a flowtype linter.

I know this is more than a year old but...

Nov 29 2016, 7:36 PM · Lint
chad added a revision to T3612: Lightbox v2: Unknown Object (Differential Revision).
Nov 29 2016, 7:01 PM · Lightbox, Restricted Project, Files, Pholio
epriestley added a revision to T11929: Merge in duplicates doesn't contain latest tasks: Unknown Object (Differential Revision).
Nov 29 2016, 6:40 PM · Bug Report, Maniphest
faulconbridge edited P2020 create repo via conduit.
Nov 29 2016, 5:53 PM
faulconbridge edited P2020 create repo via conduit.
Nov 29 2016, 5:35 PM
faulconbridge edited P2020 create repo via conduit.
Nov 29 2016, 5:31 PM
faulconbridge created P2020 create repo via conduit.
Nov 29 2016, 5:30 PM
chad added a comment to T11928: Risk of losing work when creating a new document while editing a Phriction page .

(Also, I can't reproduce this.)

Nov 29 2016, 5:24 PM · Phriction, Bug Report
chad added a revision to T3612: Lightbox v2: Unknown Object (Differential Revision).
Nov 29 2016, 5:21 PM · Lightbox, Restricted Project, Files, Pholio
MarcDufresne awarded T10612: Editing a panel causes it to duplicate in dashboard a Like token.
Nov 29 2016, 4:08 PM · Dashboards (v2), Bug Report
chad added a comment to T11928: Risk of losing work when creating a new document while editing a Phriction page .

Generally there shouldn't bee a "New <object>" on edit object pages. I think this goes away with EditEngine.

Nov 29 2016, 3:26 PM · Phriction, Bug Report
chad created T11929: Merge in duplicates doesn't contain latest tasks.
Nov 29 2016, 3:22 PM · Bug Report, Maniphest
chad merged task T11928: Risk of losing work when creating a new document while editing a Phriction page into T11440: Drafts for unsaved objects.
Nov 29 2016, 3:16 PM · Phriction, Bug Report
chad merged T11928: Risk of losing work when creating a new document while editing a Phriction page into T11440: Drafts for unsaved objects.
Nov 29 2016, 3:16 PM · EditEngine, Feature Request
timor created T11928: Risk of losing work when creating a new document while editing a Phriction page .
Nov 29 2016, 2:45 PM · Phriction, Bug Report
ioeric added a comment to T11921: Set mail sender name as "<User> via <Configurable name>"..

Sorry for not getting back sooner.

Nov 29 2016, 1:43 PM · Feature Request
epriestley closed T11921: Set mail sender name as "<User> via <Configurable name>". as Invalid.

We haven't received more information about this in a few days, so I'm going to close it. Feel free to file a new request in the future, we just prefer not to keep requests open if they're outside of our control to move forward with.

Nov 29 2016, 1:36 PM · Feature Request
epriestley closed T11925: Set niceity levels of background processes: git diff sometimes appears to thrash disk I/O and CPU from background worker as Invalid.

We haven't ever experienced this, nor have we seen reports of users other than you experiencing it. This ("basically prevent the server from doing any other work") doesn't sound like a description of how properly configured servers are generally expected to work. My expectation of modern systems is that they have sophisticated schedulers which are largely fair in allocating resources and produce generally reasonable behavior, and this is consistent with my experience.

Nov 29 2016, 1:22 PM · Feature Request
epriestley closed T11926: Implement a Work Can Wait as Invalid.

If this feature is valuable for you, I think you should implement it in your mail client rather than pursue implementation in every piece of software you use for work. A client-side solution could give you complete coverage with one implementation, and would be more powerful because it could perform additional filtering (e.g., allow important emails through even during off times, or deliver messages but not play an audio alert during off times, or ironically block family communication during work hours instead).

Nov 29 2016, 1:05 PM · Feature Request
epriestley closed T11927: HTML no escaped in Diffusion as Invalid.
  • Please report security issues via HackerOne.
  • This isn't a valid bug report: it is missing required information. See Contributing Bug Reports.
  • I can't reproduce this. Here's an HTML file which is properly escaped:
Nov 29 2016, 12:37 PM · Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Feel free to file a new task when you encounter actual problems with real text and we can look at adjusting the limit, adding an additional block-level difference phase, rewriting PhutilEditDistanceMatrix in C (see T2312), or other approaches. We can make a better decision based on concrete examples of where the current solution is falling short than by guessing where issues might arise.

Nov 29 2016, 12:09 PM · Prioritized, Transactions
• Pbutcher created T11927: HTML no escaped in Diffusion.
Nov 29 2016, 11:07 AM · Bug Report
aik099 added a comment to F1966662: AutoTransitionJiraIssueBasedOnPhabricator.png.

This is custom code.

Nov 29 2016, 7:59 AM
aik099 added a comment to T3837: Support updating JIRA custom field when revisions change status.

That's why I said In my fork. This is custom code.

Nov 29 2016, 7:50 AM · Restricted Project, Differential, Doorkeeper
dseifert added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

@epriestley thank you very much for the fast update and fix. It is working now with my example, and should be much better with a lot of pages.

Nov 29 2016, 6:16 AM · Prioritized, Transactions
• Justin_Lee added a comment to T3837: Support updating JIRA custom field when revisions change status.

how could you do this?
i cant find this configuration in my phabricator application

Nov 29 2016, 3:37 AM · Restricted Project, Differential, Doorkeeper
• Justin_Lee added a comment to F1966662: AutoTransitionJiraIssueBasedOnPhabricator.png.

how could u do this?
i can't find this configuration in my phabricator

Nov 29 2016, 3:35 AM
hach-que added a comment to T11925: Set niceity levels of background processes: git diff sometimes appears to thrash disk I/O and CPU from background worker.

For users of the Docker container, there is now a workaround available (enabled by default), which ensures that Git processes are automatically killed if the CPU wait averages above 50% in the last minute. The commit that enables this functionality is available to view here: https://github.com/hach-que-docker/phabricator/commit/0e77c36f694605371e85d420c4aecfbd3023ec5a

Nov 29 2016, 3:06 AM · Feature Request
chad added a comment to T11926: Implement a Work Can Wait.

We don't take hypothetical feature requests, unfortunately. See Contributing Feature Requests for what information we require. General Chat and Ponder are also available to discuss Phabricator in general as well.

Nov 29 2016, 2:31 AM · Feature Request
chad changed the visibility for T2477: Email notifications scheduler.
Nov 29 2016, 2:30 AM
chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 1:33 AM · Lightbox, Restricted Project, Files, Pholio
• shaneonabike created T11926: Implement a Work Can Wait.
Nov 29 2016, 1:33 AM · Feature Request
chad added a comment to T3612: Lightbox v2.

https://mozilla.github.io/pdf.js/

Nov 29 2016, 1:30 AM · Lightbox, Restricted Project, Files, Pholio
hach-que created T11925: Set niceity levels of background processes: git diff sometimes appears to thrash disk I/O and CPU from background worker.
Nov 29 2016, 1:28 AM · Feature Request
cspeckmim added a comment to T3612: Lightbox v2.

Ah I totally missed the F1234 being in the lightbox already. And I did figure that using 3rd party code to render PDF would be out of the question. I don't really know what the current state of PDFs in browsers is so I had my project manager hat on for that question~

Nov 29 2016, 1:27 AM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T3612: Lightbox v2.
  • I don't think that's a lightbox bug, just a general blog bug.
  • To be fixed.
  • If it's native? We won't be adding third party code for this.
  • We added F1234 to the header of the lightbox for resharing.
Nov 29 2016, 1:24 AM · Lightbox, Restricted Project, Files, Pholio
cguenther awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 29 2016, 1:10 AM · Calendar
cguenther awarded T10604: Allow application code to stream request data a Like token.
Nov 29 2016, 1:07 AM · Diffusion (v3), Restricted Project
cspeckmim added a comment to T3612: Lightbox v2.

Woo came here from the blog. Just a few notes so far:

  1. The lightbox on the blog doesn't seem to show anything under the Comment pane even though I should be logged in (to admin.phacility.com). Or is the blog.phacility.com completely isolated/separate? These were errors I got in Firefox console, which I don't get when using lightbox on this instance.
    • Error: JX.$('phabricator-help-menu') call matched no nodes.
    • XHR POST https://blog.phacility.com/file/thread/PHID-FILE-3ittlvgojn2326tbg22z/ [HTTP/1.1 404 Not Found 338ms]
  2. I'm very used to "click anywhere that isn't the image to close the lightbox" behavior. My personal preference would be to maintain that when clicking on any empty space outside the image/file. I think this is due to where my mouse is located when I click the image (towards center of screen usually) and where I would go to click to close (in most cases just slightly down vs. top right corner). But then I use a trackball so...
  3. Is PDF preview considered? PDFs were specifically mentioned in the blog so I have to ask~
  4. (Maybe not totally related) Some way to easily reference the same file instance from different areas. Most users I see will continue to drag/drop the same file in different areas and not use the same file reference object {F1234} - which I'm assuming would mean two separate comment chains, etc. Maybe somewhere in the lightbox listing the tasks/diffs/etc. where the file is referenced would help understanding. Or a way to view/copy the file remarkup to be used elsewhere. Or maybe this is all T11543.
Nov 29 2016, 1:07 AM · Lightbox, Restricted Project, Files, Pholio
joshuaspence added a project to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done": Differential.
Nov 29 2016, 12:32 AM · Inline Comments, Differential, Restricted Project, Feature Request
joshuaspence renamed T11495: Drydock doesn't delete working copies from DryDock doesn't delete working copies to Drydock doesn't delete working copies.
Nov 29 2016, 12:30 AM · Bug Report (Needs Information), Drydock

Nov 28 2016

chad awarded T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext) a Party Time token.
Nov 28 2016, 11:55 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley updated the task description for T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).
Nov 28 2016, 11:25 PM · FreeBSD, Restricted Project, Installing & Upgrading
eadler added projects to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext): Restricted Project, FreeBSD.
Nov 28 2016, 11:23 PM · FreeBSD, Restricted Project, Installing & Upgrading
joshuaspence added a project to T11900: Create bot reviewers that do code analysis and post findings as inline comments.: Differential.
Nov 28 2016, 7:21 PM · Differential, Feature Request
chad added a revision to T3612: Lightbox v2: Unknown Object (Differential Revision).
Nov 28 2016, 7:16 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 28 2016, 7:13 PM · Lightbox, Restricted Project, Files, Pholio
brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Thank you! The new dialog looks excellent, it would have prevented my error.

Nov 28 2016, 7:09 PM · Wikimedia, Calendar, Bug Report
epriestley closed T11909: Recurring Events: "Edit all Future Events" edits past instances as well as Resolved by committing Restricted Diffusion Commit.
Nov 28 2016, 6:48 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Here's the revised dialog after D16956:

Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 5:50 PM · Restricted Project, Calendar
epriestley added a revision to T11909: Recurring Events: "Edit all Future Events" edits past instances as well: Unknown Object (Differential Revision).
Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

I don't think that edit is always invalid: offhand, one reason you might want to make such an edit is so that you can add a tag to all events in a series, allowing you to query them so they can be exported to another calendar. Another case I could imagine is wanting to correct a mistake in the description of an event when you know nothing will be lost by editing future events (e.g., because you are the only user who can edit the event).

Nov 28 2016, 5:49 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 4:53 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 4:28 PM · Restricted Project, Calendar
epriestley added a comment to M10: Workphlow.

No.

Nov 28 2016, 3:11 PM
urzds added a comment to M10: Workphlow.

Is anything remotely like this already available somewhere? I would love to be able to see all my currently active tasks in currently active milestones to get an overview over the work I have to do during the next days. Right now I am using multiple workboards to achieve this: One "project X - week N" milestone for each project I am involved in and another "week N" milestone for myself, to be able to see all tasks I have to finish this week. If this could be simplified, that would be awesome!

Nov 28 2016, 3:01 PM
urzds added a comment to T11924: Non-numeric maniphest.points values.

Thanks for the explanation!

Nov 28 2016, 2:55 PM · Maniphest, Feature Request
epriestley added a comment to T3612: Lightbox v2.

(To answer your question more directly: yeah, no way to do pht() with variables in Javascript. We can build that without TOO much trouble, but I'd like to wait for a really good use case first.)

Nov 28 2016, 2:44 PM · Lightbox, Restricted Project, Files, Pholio
epriestley closed T11924: Non-numeric maniphest.points values as Wontfix.

I do not plan to pursue any variation on points which can not be summed in a linear way. You can find some discussion under "Quantitative" in T4427#157820.

Nov 28 2016, 2:40 PM · Maniphest, Feature Request
urzds created T11924: Non-numeric maniphest.points values.
Nov 28 2016, 1:32 PM · Maniphest, Feature Request
tiagolarafranca awarded T5447: How do I write my own Phabricator applications? a Yellow Medal token.
Nov 28 2016, 2:13 AM · Guides, Applications
chad added a revision to T3612: Lightbox v2: Unknown Object (Differential Revision).
Nov 28 2016, 1:59 AM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T3612: Lightbox v2.

I'd say just get rid of it, or render "X / Y" without pht()?

Nov 28 2016, 1:14 AM · Lightbox, Restricted Project, Files, Pholio

Nov 27 2016

chad added a comment to T3612: Lightbox v2.

Doesn't look possible to do "Image x of y" in current phtize from JS... Worth adding or just changing the language? I don't have any great ideas on updating the language. Unsure x of y is useful though.

Nov 27 2016, 11:09 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: Unknown Object (Differential Revision).
Nov 27 2016, 11:08 PM · Lightbox, Restricted Project, Files, Pholio
avivey added a project to T11923: Unhandled Exception - Cant import columns for new workboard: Projects.
Nov 27 2016, 8:29 PM · Projects, Bug Report
avivey updated the question details for Q255: Error when using HTTPS for Phabricator.
Nov 27 2016, 7:51 PM
rphl created T11923: Unhandled Exception - Cant import columns for new workboard.
Nov 27 2016, 3:12 PM · Projects, Bug Report
jimh updated the answer details for Q255: Error when using HTTPS for Phabricator (Answer 482).
Nov 27 2016, 9:05 AM
jimh updated the answer details for Q255: Error when using HTTPS for Phabricator (Answer 482).
Nov 27 2016, 8:48 AM
jimh added Q255: Error when using HTTPS for Phabricator (Answer 482).
Nov 27 2016, 8:44 AM
constantx added a comment to Q523: How to display Related Objects panel?.

Thanks Chad! Will update it frequently :)

Nov 27 2016, 5:22 AM · Maniphest

Nov 26 2016

brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Maybe it would also be sensible to not allow mass-edits to be triggered by past events. While it may be useful to tweak a single past event, I don't see much of a use case of updating all events starting from some past date. I'd argue that that is nearly always unintended.

Nov 26 2016, 9:01 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • Availability cache build on All-Day events may be off, I didn't pick up a dot for E1222.
Nov 26 2016, 5:11 PM · Restricted Project, Calendar
epriestley created E1222: Pup Duty.
Nov 26 2016, 5:10 PM
chad added a comment to Q523: How to display Related Objects panel?.

Generally recommend updating weekly to stable. Also, if you have questions / need help, we always assume you're on the latest stable release. Updating frequently / before asking questions helps reduce support costs for us. Thanks!

Nov 26 2016, 3:47 PM · Maniphest
epriestley added a comment to Q523: How to display Related Objects panel?.

The panel was updated in D16806, on Nov 6. Upgrade Phabricator to see these changes.

Nov 26 2016, 1:09 PM · Maniphest
constantx added a comment to Q523: How to display Related Objects panel?.

We're using this version:

phabricator 111c63955155046bbd57c3836c78d460ebe13dfb (Sat, Nov 5) 
arcanist e17fe43ca3fe6dc6dd0b5ce056f56310ea1d3d51 (Oct 22 2016) 
phutil 40e473e057885dab5de4fb42901f7fff2d340a6a (Sat, Nov 5)
Nov 26 2016, 11:56 AM · Maniphest
rabahmeradi added a comment to Q523: How to display Related Objects panel?.

In /config/version/

Nov 26 2016, 11:33 AM · Maniphest
constantx added a comment to Q523: How to display Related Objects panel?.

how do I find out which version I have?

Nov 26 2016, 8:23 AM · Maniphest

Nov 25 2016

epriestley created T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).
Nov 25 2016, 11:31 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley edited the content of Changelog.
Nov 25 2016, 11:08 PM
epriestley created 2016 Week 48 (Very Late November).
Nov 25 2016, 11:07 PM
epriestley closed T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS as Resolved by committing Restricted Diffusion Commit.
Nov 25 2016, 10:46 PM · Search, Bug Report
epriestley added a revision to T6740: Put some kind of stemmer on the MySQL search index: Unknown Object (Differential Revision).
Nov 25 2016, 10:44 PM · Search
chad updated the task description for T3612: Lightbox v2.
Nov 25 2016, 10:21 PM · Lightbox, Restricted Project, Files, Pholio