Page MenuHomePhabricator
Feed Advanced Search

Apr 10 2018

epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:15 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:15 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 11:51 AM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 11:51 AM · Plans
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I think "run weekly with the deploy" already works pretty well for normal log rotation with logs on local disk, and in a perfect world logs would be buffering on disk only briefly before being sent over the network to dedicated log service so we wouldn't need cron there either.

Apr 10 2018, 11:36 AM · Plans, Ops, Infrastructure, Phacility
EddieGP added a member for Wikimedia: EddieGP.
Apr 10 2018, 9:33 AM
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

i feel unethical

Apr 10 2018, 3:22 AM · Phacility

Apr 9 2018

amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

How often does the size directive in a logrotate script get evaluated?

Apr 9 2018, 11:48 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a revision to T13118: Code block headers wrap in the dumbest way in Safari: Unknown Object (Differential Revision).
Apr 9 2018, 11:34 PM · Remarkup
cteffetalor added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

Maybe vertical-align: top? Or display: inline-flex?

Apr 9 2018, 10:27 PM · Remarkup
epriestley added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

yikes

Apr 9 2018, 10:05 PM · Remarkup
cteffetalor added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

FYI Chrome/Windows after the change (extra whitespace added?)

Apr 9 2018, 10:04 PM · Remarkup
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 9:20 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 9:20 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 9:10 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 9:10 PM · Plans
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

Yeah, I think "solve it forever" is probably "first-party Sentry-like application", this just seems like a problem that should have a 15-minute "solve it for now" solution in the form of something that gives us "a thing that looks like a disk but never fills up" that will hold for a year or two until we build "Phentry".

Apr 9 2018, 9:01 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

That makes sense. I was coming at it more from the direction of “if we’re going to touch logs, lets solve it forever”. How about we make everything log locally through syslog and use logrotate to avoid filling disks? Then we can come back and point syslog at something more elaborate later without having to touch all the things that currently generate logs.

Apr 9 2018, 8:40 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I believe there are zero or nearly-zero actionable errors in the log today and that if we had a perfect Sentry-like system it wouldn't actually help us identify or fix any errors -- we'd just ignore it after a week like we currently ignore all the other production error logs.

Apr 9 2018, 7:49 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

There's some flavor of bin/remote ssh <some-host> -- tail -f <some-log_location>.

Apr 9 2018, 7:33 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

The "logs fill up disks" problem is more "sudden bursts of unusual error/activity that cause log rates to increase 1000x+ fill up disks", not "logs don't rotate / normal log volumes fill up disks". Most logs do already rotate today, I think with the exception of the aphlict log being a bit of a weird case, maybe.

Apr 9 2018, 7:14 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

phage tail <some-instance-name> <some-log-type>

Apr 9 2018, 7:10 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

But I don't think this is too valuable if it doesn't solve the "logs fill up disks" problem -- does the agent rotate/reap the logs?

Apr 9 2018, 7:00 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

In my mind, the only real problem here is...

Apr 9 2018, 6:54 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

Possibly something dumb like "mount an EFS volume on /mnt/logs/ on every host" is another AWS-only approach. That feels really dumb but maybe it's only somewhat dumb?

Apr 9 2018, 6:35 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I'm fine with CloudWatch logs, I didn't realize it had a logging thing. I'm currently not terribly warm on investing a ton in CloudWatch alarms or log analysis, but if we can get logs reliably streaming into some storage service so they can't fill up the disk I think that's quite valuable on its own. We can always replace that with something we control directly in the future if we want to invest more here. I can't imagine ever really caring about old logs no matter what happens in the future.

Apr 9 2018, 6:30 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I definitely don't want to send logs to a third-party service.

Apr 9 2018, 6:26 PM · Plans, Ops, Infrastructure, Phacility
amckinley claimed T12857: Temporary directory fullness can cause daemon issues?.
Apr 9 2018, 6:08 PM · Diffusion, Ops, Daemons, Phacility
amckinley claimed T12611: Write Phabricator HTTP and SSH logs in the production cluster.
Apr 9 2018, 6:08 PM · Phacility, Ops
amckinley claimed T12999: Replace cluster magnetic volumes with SSD volumes.
Apr 9 2018, 6:06 PM · Phacility, Ops
amckinley claimed T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.
Apr 9 2018, 6:05 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T12847: A Pathway Towards Private Clusters.

In the modern era: I think we generally understand what private clusters will look like now, but I'd like to take a much more iterative approach to getting there than we have in the past. I had this concern above (circa June 2017):

Apr 9 2018, 6:03 PM · Plans, Ops, Phacility
amckinley moved T12847: A Pathway Towards Private Clusters from Backlog to Soon on the Plans board.
Apr 9 2018, 5:31 PM · Plans, Ops, Phacility
amckinley added a project to T12847: A Pathway Towards Private Clusters: Plans.
Apr 9 2018, 5:31 PM · Plans, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 5:11 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 5:11 PM · Plans
epriestley added a comment to T13120: Plans: 2018 Week 15 Bonus Content.

Multiple installs would like API access to edit Almanac bindings.

Apr 9 2018, 4:48 PM · Plans
epriestley moved T13120: Plans: 2018 Week 15 Bonus Content from Backlog to Soon on the Plans board.
Apr 9 2018, 4:11 PM · Plans
epriestley moved T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions from Backlog to Soon on the Plans board.
Apr 9 2018, 4:11 PM · Plans, Differential
epriestley closed T13015: Improve color readability for change age in Diffusion blame view as Resolved by committing Restricted Diffusion Commit.
Apr 9 2018, 1:11 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 1:09 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13015: Improve color readability for change age in Diffusion blame view: Unknown Object (Differential Revision).
Apr 9 2018, 1:09 PM · Design, Diffusion
epriestley added a comment to T13015: Improve color readability for change age in Diffusion blame view.

This feels a bit like a return to the era of "epriestley design", but I think it's an improvement overall:

Apr 9 2018, 1:05 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:40 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:26 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:20 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:16 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Still needs work:

Apr 9 2018, 12:15 PM · Plans, Files, Differential, Diffusion

Apr 8 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 7:53 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 4:34 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Apr 8 2018, 4:34 PM · Plans, Symbols
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 3:13 PM · Plans, Files, Differential, Diffusion
epriestley closed T7895: Make HIGHLIGHT_BYTE_LIMIT configurable as Wontfix.

I don't currently plan to pursue this. We haven't seen interest from other installs and I think the upstream behavior is reasonably good most of the time and not a huge issue even when we get it wrong (you can still review the file without doing anything, and can get highlighting with a few clicks -- plus, the file and page render much faster).

Apr 8 2018, 3:05 PM · Restricted Project, Restricted Project, Differential
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 1:33 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • The secret $1-2,7-9 syntax for highlighting multiple noncontiguous blocks of lines in Diffusion is no longer supported.
Apr 8 2018, 1:31 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 8 2018, 1:18 PM · Plans, Differential
epriestley closed T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources as Resolved by committing Restricted Diffusion Commit.
Apr 8 2018, 1:17 PM · Typeahead
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 1:16 PM · Plans
epriestley closed T13118: Code block headers wrap in the dumbest way in Safari as Resolved by committing Restricted Diffusion Commit.
Apr 8 2018, 1:16 PM · Remarkup
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 8 2018, 1:12 PM · Plans
epriestley added a revision to T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources: Restricted Differential Revision.
Apr 8 2018, 1:12 PM · Typeahead
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 8 2018, 1:07 PM · Plans
epriestley added a revision to T13118: Code block headers wrap in the dumbest way in Safari: Unknown Object (Differential Revision).
Apr 8 2018, 1:06 PM · Remarkup
epriestley added a parent task for T13117: `patch` just runs any command?: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Apr 8 2018, 12:59 PM · Security
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13117: `patch` just runs any command?.
Apr 8 2018, 12:59 PM · Arcanist, Differential
epriestley closed T13116: Plans: 2018 Week 14 Bonus Content as Resolved.
Apr 8 2018, 12:55 AM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:54 AM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:54 AM · Plans
epriestley edited the content of Changelog.
Apr 8 2018, 12:30 AM
epriestley created 2018 Week 14 (Early April).
Apr 8 2018, 12:29 AM
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:10 AM · Plans
epriestley renamed T13120: Plans: 2018 Week 15 Bonus Content from Week 15 to Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:05 AM · Plans

Apr 7 2018

NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

im super ethical https://github.com/PoE-Profile/poe-profile/pull/20

Apr 7 2018, 5:52 PM · Phacility
epriestley created T13120: Plans: 2018 Week 15 Bonus Content.
Apr 7 2018, 4:00 PM · Plans
epriestley triaged T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources as Normal priority.
Apr 7 2018, 1:24 PM · Typeahead
epriestley added a comment to T13117: `patch` just runs any command?.

A related attack is a bare whatever.patch file which writes to .git/config or .hg/hgconfig or whatever.

Apr 7 2018, 12:54 PM · Security
avivey added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

image.png (237×209 px, 5 KB)

Chrome Windows

Apr 7 2018, 2:26 AM · Remarkup
epriestley added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

In Safari we get this marvel:

Apr 7 2018, 2:26 AM · Remarkup
epriestley triaged T13118: Code block headers wrap in the dumbest way in Safari as Normal priority.
Apr 7 2018, 2:25 AM · Remarkup

Apr 6 2018

avivey changed the visibility for T1349: Warning about commenting on older diffs.
Apr 6 2018, 3:18 AM · Phabricator
epriestley created P2088 nuker.php.
Apr 6 2018, 12:03 AM

Apr 5 2018

arend.danielek awarded T550: Build an SSH conduit client a Love token.
Apr 5 2018, 11:07 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
arend.danielek awarded T7303: Provide OAuth access to Conduit a Love token.
Apr 5 2018, 11:05 PM · Restricted Project, Conduit, Restricted Project
epriestley triaged T13117: `patch` just runs any command? as Normal priority.
Apr 5 2018, 6:46 PM · Security
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 6:40 PM · Plans, Files, Differential, Diffusion
epriestley closed T2442: Show images in Diffusion diffs as Resolved.

This will ultimately be covered by T13105.

Apr 5 2018, 5:54 PM · Wikimedia, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T5698: Github-style Remarkup previews on a checked-in resource, as Resolved.
Apr 5 2018, 5:52 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T12824: Redesign Diffusion, as Resolved.
Apr 5 2018, 5:52 PM · Design, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting as Resolved.

Effectively now covered by T13105.

Apr 5 2018, 5:52 PM · Diffusion
epriestley closed T3788: Improve encoding management in Diffusion, a subtask of T4045: Store diffs as binary, not UTF-8, as Resolved.
Apr 5 2018, 5:51 PM · Restricted Project, Support Impact, Differential
epriestley closed T3788: Improve encoding management in Diffusion as Resolved.

See T13105 for browse cases (and perhaps diff cases, eventually).

Apr 5 2018, 5:51 PM · Restricted Project, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • If a file is non-UTF8, we should try the repository's "Encoding" as a default (or maybe just remove this feature).
Apr 5 2018, 5:50 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Junk I'm about to break in Diffusion (but plan to restore):

Apr 5 2018, 5:38 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 4:17 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 2:33 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:34 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:29 PM · Plans, Differential

Apr 4 2018

epriestley closed T3965: Better indentation and tab handling in remarkup editor as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 3:45 PM · Remarkup
epriestley closed T8430: Support emoticons as Wontfix.

We now support emoji; we might support stickers at some point. If we did, I'd expect them to use the autocomplete element (which I think is in a relatively good place for emoji), not actually be invoked with :P, ^-^, etc.

Apr 4 2018, 3:44 PM · Restricted Project, Remarkup
epriestley closed T10398: Phabricator UI uses deprecated <tt> tag as Wontfix.

Since there's no known actual problem with this today, I don't plan to fix it.

Apr 4 2018, 2:11 PM · Remarkup, Bug Report