Page MenuHomePhabricator
Feed Advanced Search

Apr 13 2018

epriestley added a comment to T5024: Provide a dedicated page for viewing a single workboard column.

D19366 adds a "View as Query" option to the dropdown on workboard columns. This will take you to the Maniphest query results page with a query that selects exactly what was shown in the column when you selected the item.

Apr 13 2018, 1:33 PM · Restricted Project, Workboards
epriestley added a revision to T5024: Provide a dedicated page for viewing a single workboard column: Unknown Object (Differential Revision).
Apr 13 2018, 1:28 PM · Restricted Project, Workboards
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 13 2018, 1:28 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 13 2018, 12:20 PM · Plans
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

We can also get a "Something something won't allocate a terminal because something something pseudo-tty." warning without -q. I'm 100% confident this is the exact text of the error.

Apr 13 2018, 11:56 AM · Phacility, Ops

Apr 12 2018

amckinley added a revision to T12857: Temporary directory fullness can cause daemon issues?: Unknown Object (Differential Revision).
Apr 12 2018, 11:25 PM · Diffusion, Ops, Daemons, Phacility
amckinley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Apr 12 2018, 11:25 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T10883: Allow repository cluster nodes to be read-only, a subtask of T10751: Make Phabricator Highly Available, as Resolved.
Apr 12 2018, 11:10 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10883: Allow repository cluster nodes to be read-only as Resolved by committing Restricted Diffusion Commit.
Apr 12 2018, 11:10 PM · Restricted Project, Diffusion, Clusters
amckinley created P2094 (An Untitled Masterwork).
Apr 12 2018, 10:45 PM
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 12 2018, 10:08 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 10:03 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 12 2018, 10:00 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 9:50 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 12 2018, 9:47 PM · Plans
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 9:09 PM · Restricted Project, Diffusion, Clusters
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 9:09 PM · Plans
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

@epriestley where's the countdown for the unnamed league 6/1 ? :p

Apr 12 2018, 9:01 PM · Phacility
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 9:00 PM · Restricted Project, Diffusion, Clusters
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 8:59 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 8:38 PM · Plans
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 8:38 PM · Restricted Project, Diffusion, Clusters
epriestley triaged T13122: "Continue on missing fields" in Bulk Edit allows removal of required fields as Normal priority.
Apr 12 2018, 6:42 PM · ApplicationEditor
epriestley added a comment to T3626: Detection of language for some file types isn't good.

Yeah, this is a combination of a bulk editor bug (which lets you delete task titles) and legacy compatibility code for transaction title rendering (which treats null -> anything transactions as "created this thing.").

Apr 12 2018, 3:30 PM · Customer Impact, Restricted Project, Differential
avivey added a comment to T3626: Detection of language for some file types isn't good.

Oh, good, it's about time this task be created!

image.png (141×844 px, 18 KB)

Apr 12 2018, 3:04 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T3626: Detection of language for some file types isn't good from to Detection of language for some file types isn't good.
Apr 12 2018, 2:30 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from to In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected.
Apr 12 2018, 2:29 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from to Allow Show Raw File for updated added files.
Apr 12 2018, 2:29 PM · Differential
epriestley renamed T3626: Detection of language for some file types isn't good from Detection of language for some file types isn't good to .
Apr 12 2018, 2:28 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected to .
Apr 12 2018, 2:28 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from Allow Show Raw File for updated added files to .
Apr 12 2018, 2:28 PM · Differential
n3v3rf411 added a comment to T4190: Rebuild remarkup image proxying.

I think https://secure.phabricator.com/book/phabricator/article/remarkup/ needs update to include this.

Apr 12 2018, 8:43 AM · Contributor Onboarding, Remarkup
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

I'm leaning toward:

Apr 12 2018, 12:11 AM · Phacility, Ops
epriestley triaged T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands as Low priority.
Apr 12 2018, 12:08 AM · Phacility, Ops

Apr 11 2018

amckinley created P2093 (An Untitled Masterwork).
Apr 11 2018, 11:25 PM
amckinley created P2092 (An Untitled Masterwork).
Apr 11 2018, 11:20 PM
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Apr 11 2018, 9:48 PM · Quicksand
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:47 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:30 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:15 PM · Plans, Files, Differential, Diffusion
amckinley created P2091 (An Untitled Masterwork).
Apr 11 2018, 8:45 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 8:45 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to P2090 (An Untitled Masterwork).

Hmm, I can't reproduce the issue. Here's pre-comment:

Apr 11 2018, 7:09 PM
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • Source view rendering in Paste has a missing background color.
Apr 11 2018, 7:06 PM · Plans, Files, Differential, Diffusion
amckinley created P2090 (An Untitled Masterwork).
Apr 11 2018, 7:04 PM
amckinley created P2089 (An Untitled Masterwork).
Apr 11 2018, 6:04 PM
epriestley closed T12414: Implement Almanac edit endpoints in Conduit, a subtask of T12218: Reduce the operational cost of a larger Phacility cluster, as Resolved.
Apr 11 2018, 5:54 PM · Ops, Phacility
epriestley closed T12414: Implement Almanac edit endpoints in Conduit as Resolved.

I think that's pretty much everything. There will be a little followup work in T10883 and maybe T13076 / T13120.

Apr 11 2018, 5:54 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 4:44 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 11 2018, 4:44 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 4:28 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 4:28 PM · Plans
amckinley closed T11476: Record transaction histories when users edit application capabilities as Resolved by committing Restricted Diffusion Commit.
Apr 11 2018, 3:55 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 3:41 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 3:41 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 2:17 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 2:17 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

Everything here should pretty much work except:

Apr 11 2018, 2:08 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 1:40 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 1:40 PM · Plans
DanielO added a comment to T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>=.

Actually turns out that the work around isn't reliable - I still get that error occasionally (I'm using SSH)

Apr 11 2018, 2:48 AM · Mercurial
DanielO added a comment to T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>=.

The same problem occurred on my site with the latest Phabricator and the latest Mercurial 3.7.2 installed on both sides.

Interestingly, it can be cured setting a special development debug flag for in the Mercurial configuration file:
in /etc/mercurial/hgrc or in vcs-user's ${HOME}/.hgrc adding the following snippet

[devel]
bundle2.debug = true

caused a hg push to a hosted Phabricator repository to work without a problem. But do not ask me, why.

Apr 11 2018, 2:14 AM · Mercurial

Apr 10 2018

amckinley added a revision to T11476: Record transaction histories when users edit application capabilities: Restricted Differential Revision.
Apr 10 2018, 11:02 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

I think all the T13076 stuff is blocked on me for now unless you're feeling especially ambitious about trying to get bin/host download working on 2GB+ files (T12907 / D19011). That might be a bit of a mess of a task though since I think I have a lot of secret cURL knowledge from over the years that is only somewhat-documented in HTTPSFuture.

Apr 10 2018, 10:47 PM · Phacility, Ops
amckinley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

Oh, I'm happy to kick this down the road until we go through the Big Compaction. I just saw this task as a dependency for T13076, which is on this week's planning board and figured I'd tackle it. Is there a different task you think I should work on instead to move T13076 forward?

Apr 10 2018, 7:47 PM · Phacility, Ops
amckinley reassigned T12414: Implement Almanac edit endpoints in Conduit from amckinley to epriestley.
Apr 10 2018, 7:32 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

Backups should run continuously (starting 12 hours after the instance launches, then every 24 hours after that):

Apr 10 2018, 7:30 PM · Phacility, Ops
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 7:22 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 7:22 PM · Conduit, Almanac, Ops, Phacility
amckinley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

I'm going to go through the volumes type-by-type instead of host-by-host, starting with the backup volumes (because those should be fine to detach as long as the backup isn't running). It looks like backups run daily at 2300, so that should give me plenty of time.

Apr 10 2018, 7:05 PM · Phacility, Ops
amckinley moved T12847: A Pathway Towards Private Clusters from Soon to Future on the Plans board.
Apr 10 2018, 6:45 PM · Plans, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:41 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:41 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:22 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:22 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:19 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:19 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:03 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:03 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 5:10 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 5:10 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 5:08 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 5:08 PM · Plans
amckinley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

Hmmm, then maybe the narrowest way to solve this is to just setup disk space alarms. That's a thing we'd want independent of how we eventually build the One True Logging System. The CloudWatch agent collects disk stats out of the box, and takes a list of mountpoints to track. Details here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Agent-Configuration-File-Details.html

Apr 10 2018, 4:09 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 3:43 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 3:43 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 3:27 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 3:27 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 2:24 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 1:38 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

Before I can get rid of AlmanacDeviceTransaction::TYPE_INTERFACE, we have two meaningful callsites in rSERVICES and one unit test in rSAAS to clean up.

Apr 10 2018, 1:30 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 1:28 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 1:28 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 1:17 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 1:17 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:57 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:57 PM · Plans
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

There's a bit of a mess with AlmanacInterface and AlmanacDevice. Currently, AlmanacInterface does not use transactions, and is edited purely as a side effect of INTERFACE transactions applying to AlmanacDevice. I'm going to change how this works so that AlmanacInterface is a normal transactional object and can use the same rules and infrastructure as everything else.

Apr 10 2018, 12:34 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:21 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:21 PM · Plans