Page MenuHomePhabricator

Warning about commenting on older diffs
Closed, DuplicatePublic

Description

It would be nice if Phabricator had a big fat warning near the comment box on any diff that was not the newest revision. Something to warn us if we accidentally end up on anything-but-the-newest page and try to make a comment.

I still want the ability to comment on old diffs, just don't want to comment on an old one by mistake.

Event Timeline

epriestley triaged this task as Wishlist priority.Jun 20 2012, 2:11 PM

Can you explain the context a little more? How did you end up on an old revision?

The large comment box at the bottom doesn't attach to a diff -- was the problem that you made comments which didn't make sense on the newest revision?

Solving this problem in general is tricky because inline comments do attach to a specific diff, so we'd have to put the warning on every inline comment dialog. This seems like it might be overkill.

If possible, I'd rather just fix whatever it was that led you to the wrong version of the revision in the first place. Is there somewhere in the UI that we point you at the wrong place without giving you enough context?

@epriestley the notification feed is probably the solution to this issue...

The problem was that the diff got updated after the page was loaded... without refreshing there was no way to know that he was commenting on the old code. Notifications about changes to the current revision would solve the whole problem.

Ah, yeah. You should get a real-time notification once that stuff is a little more robust and configured.

✘ Merged into T974.

avivey changed the visibility from "All Users" to "Public (No Login Required)".Apr 6 2018, 3:18 AM