Page MenuHomePhabricator

Plans: 2018 Week 15 Bonus Content
Closed, ResolvedPublic

Description

See T13119, which has a fatal that should get fixed.

See T13118 for a Safari UI issue.

See PHI473. See PHI145. See T12414. Multiple installs would like API access to edit Almanac bindings.

See PHI474. See T10883. An install would like support for a "Read Only" mode for repository cluster nodes, primarily to support maintenance operations.

See PHI568. If you make the filetree UI element really wide so that the page gets a horizontal scrollbar, then scroll the page, the page content can show through the filetree UI.

See PHI573. Some of the new draft behavior is interacting poorly with --draft when prototypes are off.

See PHI574. This is a real sketchy issue that wants better internal APIs. <_< >_>

See PHI571. An install would like to query tasks per-workboard column. There's a task for this somewhere (T5024), and then 11 tasks where people want it based on the column name and I say "no, never ever" (also T5024; T7907, etc).

See PHI565. Legacy Harbormaster build logs and the new "build generation" feature are interacting poorly.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley renamed this task from Week 15 to Plans: 2018 Week 15 Bonus Content.Apr 8 2018, 12:05 AM
epriestley claimed this task.
epriestley triaged this task as Normal priority.
epriestley updated the task description. (Show Details)
epriestley added a project: Plans.
epriestley added a revision: Restricted Differential Revision.Apr 8 2018, 1:07 PM
epriestley added a revision: Restricted Differential Revision.Apr 8 2018, 1:12 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 8 2018, 1:16 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 8 2018, 1:17 PM

Multiple installs would like API access to edit Almanac bindings.

PHI145 discusses almanac.service.edit not working because of the "objects which require an implementation" issue described in D18849 and linked objects. That dealt with this problem in Drydock blueprints. The fix there wasn't completely satisfying but seems generally reasonable. This is likely straightforward but just fixes the endpoint in the web UI and allows service creation, neither of which anyone actually cares about too much.

PHI145 and PHI473 both ultimately want API access to bindings. The major wrench in the gears here is that bindings aren't particularly modern internally.

A lurking issue is that properties both aren't modern and are defined in a very informal, fairly ad-hoc way. But a saving grace is that the upstream only defines one actual service property and zero binding properties -- even though it uses binding properties -- so this is possibly mostly a fix-forward.

This probably looks something like:

  • Implement the "thing that requires another thing" support for Services.
  • Move Bindings to EditEngine and ModularTransactions.
  • Figure out what's going on with Properties.
epriestley added a revision: Restricted Differential Revision.Apr 9 2018, 5:11 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 9 2018, 6:38 PM
epriestley added a revision: Restricted Differential Revision.Apr 9 2018, 9:10 PM
epriestley added a revision: Restricted Differential Revision.Apr 9 2018, 9:20 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 11:51 AM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 12:15 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 12:21 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 12:57 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 1:17 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 1:28 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 3:27 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 3:43 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 5:08 PM
epriestley added a revision: Restricted Differential Revision.
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 6:03 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 6:19 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 6:22 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 6:41 PM
epriestley added a revision: Restricted Differential Revision.Apr 10 2018, 7:22 PM
epriestley added a revision: Restricted Differential Revision.Apr 11 2018, 1:40 PM
epriestley added a revision: Restricted Differential Revision.Apr 11 2018, 2:17 PM
epriestley added a revision: Restricted Differential Revision.Apr 11 2018, 3:41 PM
epriestley added a revision: Restricted Differential Revision.Apr 11 2018, 4:28 PM
epriestley added a revision: Restricted Differential Revision.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:22 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:28 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:31 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:33 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:37 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 11 2018, 5:42 PM
epriestley added a revision: Restricted Differential Revision.Apr 12 2018, 8:38 PM
epriestley added a revision: Restricted Differential Revision.Apr 12 2018, 8:59 PM
epriestley added a revision: Restricted Differential Revision.Apr 12 2018, 9:08 PM
epriestley added a revision: Restricted Differential Revision.Apr 12 2018, 9:50 PM
epriestley added a revision: Restricted Differential Revision.Apr 12 2018, 10:03 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 12 2018, 11:08 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 12 2018, 11:10 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Apr 13 2018, 1:28 PM
epriestley added a revision: Restricted Differential Revision.Apr 13 2018, 1:50 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 13 2018, 6:55 PM
epriestley added a revision: Restricted Differential Revision.Apr 13 2018, 8:27 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 13 2018, 11:07 PM
epriestley updated the task description. (Show Details)

A couple of things rolled forward into T13124.

epriestley added a commit: Restricted Diffusion Commit.Apr 16 2018, 7:26 PM