Page MenuHomePhabricator
Feed Advanced Search

Feb 6 2018

epriestley added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

Yeah, the only reason I pursued this was for giant emoji. I was just going to do {huge 馃惐} or something first, but then I figured {drop-cap 馃惐} was a little more defensible as a general feature while still solving the huge emoji problem.

Feb 6 2018, 6:48 PM 路 Remarkup
cspeckmim added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

I've been wanting to make a "giant emoji" task since emoji were added but was too afraid...

Feb 6 2018, 6:45 PM 路 Remarkup
epriestley added a member for Community: reed.
Feb 6 2018, 6:26 PM
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 5:44 PM 路 Phacility, Mail
epriestley updated the task description for T12677: Support multiple mail delivery services for automatic failover.
Feb 6 2018, 5:21 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 5:17 PM 路 Plans, Must Encrypt Mail, Mail
arrowd added a comment to T5726: Add more information to story POSTs during the feed.http-hooks hook.

One concern about this is that this information is policy-bypassing.

Feb 6 2018, 4:57 PM 路 Feed
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:43 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:43 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:16 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:16 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:52 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:52 PM 路 Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:23 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:23 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:06 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:06 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 1:09 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 1:09 PM 路 Phacility, Mail
epriestley added a revision to T12101: Phabricator PHP 7 Compatibility: Unknown Object (Differential Revision).
Feb 6 2018, 1:00 PM 路 Infrastructure, Guides
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 12:34 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 12:19 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

I'd either want to pay some service to deal with this or run an open source server that I was confident it was possible to fix, but one option is definitely to run Postfix/Dovecot/Exim/whatever the kids use these days.

Feb 6 2018, 11:58 AM 路 Phacility, Ops
avivey added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

If all you're going for are emails, why not spin up your own Exchange server (or whatever the kids use these days)? With maybe forwarding to a epriestley-phacility@gmail.com so you remain compliant?

Feb 6 2018, 2:01 AM 路 Phacility, Ops
avivey awarded T13063: Maybe render all text with IMPRESSIVE illuminated drop caps a Manufacturing Defect? token.
Feb 6 2018, 1:49 AM 路 Remarkup

Feb 5 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The "From" address should also probably be anonymized for flagged mail.

Feb 5 2018, 11:59 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Who knows what the Bad People would have one if they'd intercepted it!

Feb 5 2018, 11:39 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

When an object is updated via an "inverse edge" change (normally: when it is mentioned, or when another object is linked to it) we currently do not fire Herald rules. The corresponding block in the code has this comment:

Feb 5 2018, 11:38 PM 路 Plans, Must Encrypt Mail, Mail
alexmv added a comment to T13053: Plans: Mail Tags and Failover.

Hrrrm...

Feb 5 2018, 11:37 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Hrrrm...

Feb 5 2018, 11:33 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 5 2018, 10:44 PM 路 Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 10:44 PM 路 Plans, Must Encrypt Mail, Mail
epriestley closed T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS as Resolved by committing Restricted Diffusion Commit.
Feb 5 2018, 8:26 PM 路 Documentation, Arcanist
epriestley closed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Resolved by committing Restricted Diffusion Commit.
Feb 5 2018, 8:23 PM 路 Diffusion
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 8:06 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 7:23 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 7:03 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 6:40 PM 路 Plans, Must Encrypt Mail, Mail
epriestley renamed T13063: Maybe render all text with IMPRESSIVE illuminated drop caps from Maybe render all text with illuminated drop caps to Maybe render all text with IMPRESSIVE illuminated drop caps.
Feb 5 2018, 6:23 PM 路 Remarkup
epriestley triaged T13063: Maybe render all text with IMPRESSIVE illuminated drop caps as Wishlist priority.
Feb 5 2018, 6:23 PM 路 Remarkup
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

馃帀馃帀馃帀 I RECEIVED AN EMAIL AND CLICKED A LINK CONTAINED INSIDE IT 馃帀馃帀馃帀

Feb 5 2018, 4:21 PM 路 Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Ah, it looks like Google Groups spam filtered some of the Twitter verification mail!

Feb 5 2018, 4:18 PM 路 Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Some of this seems to be that messages sent from my @phacility.com address are sometimes eaten entirely (?) or just not delivered to me (?), presumably because I'm a recipient. I still haven't been able to get the confirmation link from Twitter, but it's possible that's on Twitter's end.

Feb 5 2018, 4:15 PM 路 Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

I figured some of this might be Safari vs Chrome, even though there's no obvious indication that Safari is having issues (e.g., I didn't catch any JS errors in the console).

Feb 5 2018, 3:59 PM 路 Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

There's an hourglass icon in the header menu. I don't know what this is for. When I click this, I get a "Loading..." menu which never loads. I reloaded the page, too. There's nothing pertinent in the console error log.

Feb 5 2018, 3:53 PM 路 Phacility, Ops
epriestley triaged T13062: Trying to manage anything in Gsuite is kind of not great? as Wishlist priority.
Feb 5 2018, 3:51 PM 路 Phacility, Ops
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We received our first credit card dispute on January 31st.

Feb 5 2018, 2:51 PM 路 Phacility
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Feb 5 2018, 2:05 PM 路 Herald
Twilight added a member for Space Test Users: Twilight.
Feb 5 2018, 6:22 AM

Feb 4 2018

epriestley added a revision to T10448: Modularize mail tags: Unknown Object (Differential Revision).
Feb 4 2018, 5:40 PM 路 Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a revision to T5554: arc fails with svn/git/hg non english locales: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM 路 Arcanist
epriestley added a revision to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM 路 Diffusion (v3)
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM 路 Diffusion
epriestley added a comment to T5554: arc fails with svn/git/hg non english locales.

See some additional discussion in T13060 and T7339. Pretty much everything here remains unchanged, but those tasks discover an additional constrain: a parent process has LANG=POSIX (or similar, some non-UTF8 locale), it can not pass UTF8 to subprocesses in argument lists.

Feb 4 2018, 3:11 PM 路 Arcanist
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM 路 Diffusion, Bug Report
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

D18988 addresses the issue from D18105 (git grep 馃悜 fails) more directly by calling @setlocale(LC_ALL, 'en_US.UTF-8') unconditionally during startup. The motivating case in T13060 is:

Feb 4 2018, 2:59 PM 路 Diffusion (v3)
epriestley added a revision to T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS: Unknown Object (Differential Revision).
Feb 4 2018, 2:24 PM 路 Documentation, Arcanist
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:09 PM 路 Diffusion
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:01 PM 路 Diffusion
epriestley triaged T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS as Low priority.
Feb 4 2018, 1:45 PM 路 Documentation, Arcanist

Feb 3 2018

epriestley added a comment to T10817: Allow more characters for built-in `filename` linter.

(Future me, see also PHI343.)

Feb 3 2018, 8:09 PM 路 Lint, Feature Request
swisspol added a comment to T10817: Allow more characters for built-in `filename` linter.

The above workaround is not reliable since it skips the files entirely vs checking the remaining characters.

Feb 3 2018, 7:58 PM 路 Lint, Feature Request
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I think I didn't kick Apache hard enough since I eventually rammed this through with setlocale().

Feb 3 2018, 4:20 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

setlocale(...) doesn't (?) appear to work from within Apache (?).

Feb 3 2018, 4:15 PM 路 Diffusion
epriestley renamed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails from Commits may partially fail to import when affecting files with UTF8 characters to When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.
Feb 3 2018, 4:07 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Thankfully, it seems that setlocale(LC_ALL, 'en_US.UTF-8'); from within PHP does work, so we don't need to figure out what PAM initialization cache file Ubuntu is actually reading LANG settings from.

Feb 3 2018, 4:02 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 also does not work, although this is apparently just a Perl script that rewrites /etc/default/locale for you.

Feb 3 2018, 3:54 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Setting LANG in /etc/environment had no effect on anything.

Feb 3 2018, 3:50 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I now strongly believe this is some kind of terminal environment problem. This script has different behavior in production and on my laptop:

Feb 3 2018, 3:39 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

No luck, I don't even see any bugs in Differential locally with that change (the en-dash decodes and renders properly). So this might be in the realm of T7339.

Feb 3 2018, 2:04 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same result.

Feb 3 2018, 1:57 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same results for spaces.

Feb 3 2018, 1:54 PM 路 Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

To try to reproduce this, I did this:

Feb 3 2018, 1:53 PM 路 Diffusion
epriestley triaged T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Normal priority.
Feb 3 2018, 1:47 PM 路 Diffusion
ekubischta edited the content of Organizations Using Phabricator.
Feb 3 2018, 5:02 AM

Feb 2 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Vaguely related, the subject line for this mail is currently something like:

Feb 2 2018, 11:07 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

馃惐 馃悷

Feb 2 2018, 11:03 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a project to T13053: Plans: Mail Tags and Failover: Must Encrypt Mail.
Feb 2 2018, 11:02 PM 路 Plans, Must Encrypt Mail, Mail
epriestley created Must Encrypt Mail.
Feb 2 2018, 10:56 PM
epriestley edited the content of Changelog.
Feb 2 2018, 9:29 PM
epriestley created 2018 Week 5 (Very Early February).
Feb 2 2018, 9:28 PM
ofbeaton added a comment to T12359: Registration does not accept valid email addresses.

We have also found legitimate users who have valid email addresses (Irish users) that are not accepted.

Feb 2 2018, 8:35 PM 路 Bug Report
ofbeaton added a comment to T12718: Local email validation with apostrophe.

For those visiting from the future via search, I have decided to publish an unofficial bug patch in a github repo, as it breaks once in awhile due to upstream changes.

Feb 2 2018, 8:31 PM 路 Bug Report
ofbeaton added a comment to T10598: Options to display Real Name instead of username everywhere.

For those visiting from the future via search, I have decided to publish the unofficial patch in a github repo, as it breaks once in awhile due to upstream changes.

Feb 2 2018, 6:40 PM 路 Feature Request
epriestley updated the task description for T13059: Write a lint rule for detecting unreachable blocks.
Feb 2 2018, 5:12 PM 路 Arcanist, Lint
epriestley triaged T13059: Write a lint rule for detecting unreachable blocks as Normal priority.
Feb 2 2018, 5:07 PM 路 Arcanist, Lint
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

Thanks @mcorteel, I'll take a look.

Feb 2 2018, 5:01 PM 路 Arcanist, Bug Report
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

contains complex HTML elements (like inline comments) which would also need to be stored in a structured way and then rendered just-in-time

Feb 2 2018, 4:30 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

While it's on my mind -- these messages link to /mail/whatever/123/ right now, but that page doesn't hyperlink links in the mail body, which is a fairly significant usability issue since the workflow is: click the link to go to the mail, read the mail body, copy paste the link in the mail body into your address bar.

Feb 2 2018, 4:25 PM 路 Plans, Must Encrypt Mail, Mail

Feb 1 2018

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Feb 1 2018, 10:58 PM 路 Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Feb 1 2018, 10:54 PM 路 Mail, Bug Report
epriestley closed T13037: An attacker gained staff access to Mailgun and was able to read customer API keys as Resolved.

My call with Mailgun was generally reassuring. Based on an uncharitable reading of the January 5th disclosure, my major concern was that they might be starting from a cultural position which was blind to internal actors as threats and everyone just used root / hunter2 written on a sticky note to log in to everything or something like that.

Feb 1 2018, 9:42 PM 路 Phacility, Security, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 8:04 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 7:37 PM 路 Plans, Must Encrypt Mail, Mail
jbrownEP added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

I am also interested in this; it's not uncommon that an engineer is testing a regression somewhere and wants to trigger a full CI build of an old revision. Today, their options are (a) have admin access to the Harbormaster Build Plan, which requires a large amount of trust or (b) bother someone who does have admin access to press buttons.

Feb 1 2018, 7:31 PM 路 Restricted Project, Harbormaster, Feature Request
jbrownEP added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

I would also be interested in this feature; here's our use-case if you possibly find it more persuasive than OP's:

Feb 1 2018, 7:23 PM 路 Restricted Project, Harbormaster
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 5:34 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

I suppose another reasonable attacker is "laptop thieves", but deleting any locally stored mail which was accidentally transmitted in the open seems like a reasonable way to recover from any confusion that arises until we figure out how foolproof the behavior needs to be.

Feb 1 2018, 5:05 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The intended trigger for "Must Encrypt" is Herald rules like this:

Feb 1 2018, 5:03 PM 路 Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Restricted Differential Revision.
Feb 1 2018, 4:39 PM 路 Plans, Must Encrypt Mail, Mail