Page MenuHomePhabricator
Feed Advanced Search

Jun 21 2018

avivey created T13155: Empty commit causes diffusion error output (but doesn't fail).
Jun 21 2018, 4:27 AMDiffusion
avivey committed rGITTEST75cff161bdc4: empty commit! (authored by avivey).
empty commit!
Jun 21 2018, 4:24 AM

Jun 4 2018

avivey committed rPdbe72df55726: minor: fix translation error in exception (authored by avivey).
minor: fix translation error in exception
Jun 4 2018, 5:46 PM
avivey closed D19463: minor: fix translation error in exception.
Jun 4 2018, 5:46 PM
avivey added a comment to Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).

Also, Support has basically moved to Discourse now.

Jun 4 2018, 6:25 AM
avivey requested review of D19463: minor: fix translation error in exception.
Jun 4 2018, 6:24 AM
avivey added Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).
Jun 4 2018, 6:24 AM

Jun 2 2018

avivey added a comment to T418: Integrate CustomField into more interfaces.

From https://discourse.phabricator-community.org/t/how-to-get-custom-field-of-transactiontype/1532 (and my followup research), there doesn't appear to be a way to extract custom field information using conduit (or Herald Web Hooks).
transaction.search actually lists type as null and no fields.

Jun 2 2018, 6:12 PMRestricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields

Jun 1 2018

avivey accepted D19456: Fix Javascript busy loop when trying to delete tokens from an empty tokenizer.

馃憤
Javascript is !!fun!!.

Jun 1 2018, 8:27 PM
avivey accepted D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.

lgtm

Jun 1 2018, 8:24 PM

May 31 2018

avivey changed the visibility for T3071: add support for OpenSearch to phabricator.
May 31 2018, 11:49 PM
avivey added a comment to T12963: Aggregate similar stories in Feed, Notifications and Timelines.

See also long chatter in https://discourse.phabricator-community.org/t/request-less-obtrusive-status-updates/1530.

May 31 2018, 5:19 PMTransactions

May 24 2018

avivey triaged T13148: css: ginormous images go over preview panel in Files as Low priority.
May 24 2018, 10:00 PMFiles
avivey renamed T13147: tab freeze when hitting backspace in empty tokenizer from tab freeze when hitting backspace in empty picker to tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 9:51 PMTypeahead
avivey created T13147: tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 6:55 PMTypeahead

May 22 2018

avivey added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

Very soon now, git is getting an exciting new wire protocol. Highlights are improving performance on repos with unholy amount of refs, and being "easier to expand".

May 22 2018, 11:37 PMRestricted Project, Harbormaster

May 15 2018

avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PMLint

May 11 2018

avivey committed rP728130044652: Allow number in generated clone uri (authored by avivey).
Allow number in generated clone uri
May 11 2018, 4:18 PM
avivey closed D19447: Allow number in generated clone uri.
May 11 2018, 4:18 PM
avivey requested review of D19447: Allow number in generated clone uri.
May 11 2018, 5:07 AM

May 2 2018

avivey edited the content of 2018 Week 17 (Very Late April).
May 2 2018, 2:53 AM

Apr 30 2018

avivey updated the task description for T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AMConduit, Files
avivey created T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AMConduit, Files

Apr 24 2018

avivey accepted D19404: Fix a typo in the Diffusion importing user guide.

This is probably much clearer now.

Apr 24 2018, 11:08 PM

Apr 22 2018

avivey added a comment to rP15e6e2adea61: Update install_ubuntu.sh to the new age.

Want to counter-diff, @eadler?

Apr 22 2018, 9:26 PM
avivey added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

See PHI251. This requests an "Ignore generated changes." option for Owners.

Historically, an issue with this was my hesitance to add more "Add Owner As Reviewer If Moon is Full" builtin rules to Owners: Herald already allows you to implement arbitrary rules with Owners, and an implementation of Herald where every possible rule is a dropdown option obviously isn't very good.

Apr 22 2018, 6:40 PMPlans

Apr 21 2018

avivey committed rP15e6e2adea61: Update install_ubuntu.sh to the new age (authored by avivey).
Update install_ubuntu.sh to the new age
Apr 21 2018, 4:58 PM
avivey closed D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:58 PM
epriestley awarded D19394: Update install_ubuntu.sh to the new age a Doubloon token.
Apr 21 2018, 4:43 PM
avivey added a comment to D19394: Update install_ubuntu.sh to the new age.

Incidentally, the first page shown after the install (as of 4dc8e2de564f48) is a white exception page with [Core Exception/Exception] Define 'phabricator.base-uri' in your configuration to continue..

Apr 21 2018, 4:51 AM
avivey requested review of D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:50 AM
avivey added a revision to T4200: Building OS packages and install scripts: D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:49 AMGuides, Setup

Apr 20 2018

avivey added a comment to T4200: Building OS packages and install scripts.

install_ubuntu.sh seems to be completely broken for modern Ubuntu. I don't mind updating it, but I think we discussed dumping it completely?

Apr 20 2018, 1:37 AMGuides, Setup

Apr 18 2018

avivey added a revision to T5936: Support terminating builds, terminating remote processes and build steps: D19376: Add an "Abort Older Builds" build step to Harbormaster.
Apr 18 2018, 2:21 AMRestricted Project, Harbormaster
avivey added a task to D19376: Add an "Abort Older Builds" build step to Harbormaster: T5936: Support terminating builds, terminating remote processes and build steps.
Apr 18 2018, 2:21 AM
avivey awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a Dat Boi token.
Apr 18 2018, 2:17 AMDesign, Differential, Plans

Apr 12 2018

avivey added a comment to T3626: Detection of language for some file types isn't good.

Oh, good, it's about time this task be created!

image.png (141脳844 px, 18 KB)

Apr 12 2018, 3:04 PMCustomer Impact, Restricted Project, Differential

Apr 7 2018

avivey added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

image.png (237脳209 px, 5 KB)

Chrome Windows

Apr 7 2018, 2:26 AMRemarkup

Apr 6 2018

avivey changed the visibility for T1349: Warning about commenting on older diffs.
Apr 6 2018, 3:18 AMPhabricator

Mar 23 2018

avivey accepted D19251: Add a basic Remarkup document rendering engine.

(What's \z in the regexp?)

Mar 23 2018, 11:24 AM

Mar 19 2018

avivey added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I'm wondering how this should interact with T8407: Control diffusion's syntax highlighting.

Mar 19 2018, 1:11 PMPlans, Files, Differential, Diffusion
avivey awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Love token.
Mar 19 2018, 1:04 PMPlans, Files, Differential, Diffusion

Mar 18 2018

avivey added a project to T10611: No option to specify a Space when editing a Project's visibility policy: Projects.
Mar 18 2018, 10:20 AMProjects, Restricted Project, Feature Request, Spaces

Mar 16 2018

avivey awarded T13107: Git, Slowly and Painfully a Mountain of Wealth token.
Mar 16 2018, 11:19 AMGuides

Mar 13 2018

avivey created T13104: Policy "Subscribers" does not consider members of subprojects.
Mar 13 2018, 6:34 AMProjects, Policy
avivey awarded T13103: Document favicon customization and validate the "ui.favicons" configuration option a Yellow Medal token.
Mar 13 2018, 6:26 AMFiles, Aphront, Infrastructure

Mar 9 2018

avivey added a comment to D19204: Add some more UI reminder text about draft revisions.

Appears to be broken for non-draft revisions: https://discourse.phabricator-community.org/t/openning-any-differential-fails-with-undefined-variable-object/1216

Mar 9 2018, 10:40 AM

Mar 4 2018

avivey awarded T13098: Plans: Arcanist toolsets and extensions a Pterodactyl token.
Mar 4 2018, 7:33 PMArcanist, Plans

Feb 24 2018

avivey updated the task description for T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:10 AMSearch
avivey created T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:09 AMSearch

Feb 21 2018

avivey added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.
$ sudo apt install lolcat
 ...
 ...
 ...
After this operation, 27.6 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Feb 21 2018, 8:00 PMPlans, Harbormaster

Feb 16 2018

avivey accepted D19109: Suggest Phurl URLs on "((..." in Remarkup text areas.
Feb 16 2018, 5:54 PM

Feb 15 2018

avivey awarded T13079: Allow third-party code to extend the list of functions that function datasources support a Like token.
Feb 15 2018, 2:22 AMTypeahead

Feb 8 2018

avivey added a comment to D19035: When users are subscribed explicitly, count them as "mentioned".

馃憤

Feb 8 2018, 9:29 PM
avivey added a comment to D19035: When users are subscribed explicitly, count them as "mentioned".

Are there cases of "added subscriber" that don't/shouldn't count as mentions?

Feb 8 2018, 9:05 PM
avivey added a comment to D19035: When users are subscribed explicitly, count them as "mentioned".

That kinda makes sense, and kinda confusing. Maybe we should show this information somehow - under view details for the creation, or just consider reviewers/subscribers/project as special cases.

Feb 8 2018, 9:03 PM
avivey added a comment to D19035: When users are subscribed explicitly, count them as "mentioned".

(I don't see any "added subscriber: avivey" transaction, but I'm subscribed)

Feb 8 2018, 8:54 PM
avivey added a comment to T13068: Refinements for "Mute Notifications".

For what it's worth, I think the Mute feature adds a lot of complexities to the system, in excess to the norms of the last few years:

  • Code to handle it in the sending mechanism
  • Prioritizing this feature against any other notify feature (like T9031)
  • UI to show the to the muting user (on the object and in /mail/?)
  • UI to show to other users that this user will not be notified (What if all members of a project are muting a thread?)
  • Can a mailing list/project mute a topic?
  • "why did I not receive this notification?" - there's still some issues about this - novice users don't know/understand /mail/, and admins can't see this for them. I suspect this question will require a written checklist somewhere.
Feb 8 2018, 7:37 PMNotifications, Mail

Feb 6 2018

avivey added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

If all you're going for are emails, why not spin up your own Exchange server (or whatever the kids use these days)? With maybe forwarding to a epriestley-phacility@gmail.com so you remain compliant?

Feb 6 2018, 2:01 AMPhacility, Ops
avivey awarded T13063: Maybe render all text with IMPRESSIVE illuminated drop caps a Manufacturing Defect? token.
Feb 6 2018, 1:49 AMRemarkup

Feb 1 2018

avivey awarded D18983: Add basic support for a "Must Encrypt" mail flag which prevents unsecured content transmission a Like token.
Feb 1 2018, 5:01 PM

Jan 27 2018

avivey awarded T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console a Like token.
Jan 27 2018, 8:18 PMDaemons

Jan 6 2018

cspeckmim awarded Changelog a Mountain of Wealth token.
Jan 6 2018, 4:47 PM

Dec 20 2017

avivey abandoned D18820: Reduce mirth in 403/404 pages.

not applicable...

Dec 20 2017, 7:53 AM

Dec 11 2017

avivey added a comment to D18820: Reduce mirth in 403/404 pages.

This was mostly a preemptive change for me, because my users are more likely to be confused by it. I don't mind forking it if you'd like to keep the poem...

Dec 11 2017, 11:00 AM

Dec 9 2017

avivey added a comment to T13029: Provide some way for administrators to remove/reset a user's profile image.

You need to clear some caches too - ./bin/cache purge - but I'm not sure which; And then hard-refresh the in the browser.

Dec 9 2017, 11:36 PMAbuse, People

Dec 7 2017

avivey created P2081 DebugAuthProvider .
Dec 7 2017, 1:56 PM
avivey created P2080 CopyPHIDAction.php.
Dec 7 2017, 12:47 PM
avivey requested review of D18820: Reduce mirth in 403/404 pages.
Dec 7 2017, 11:51 AM

Nov 30 2017

avivey accepted D18812: Don't require the "gd" extension be installed in order to run unit tests.
Nov 30 2017, 9:50 PM
avivey committed rPd8f2630d5c0f: Modernize QuickSearch typeahead (authored by Aviv Eyal <aviv@myclaimly.com>).
Modernize QuickSearch typeahead
Nov 30 2017, 3:08 PM
avivey closed D18760: Modernize QuickSearch typeahead.
Nov 30 2017, 3:07 PM
avivey added a comment to D18760: Modernize QuickSearch typeahead.

Those are really good points, thanks!

Nov 30 2017, 2:56 PM
epriestley awarded D18760: Modernize QuickSearch typeahead a Hungry Hippo token.
Nov 30 2017, 2:56 PM
avivey updated the diff for D18760: Modernize QuickSearch typeahead.

Re-implement using EngineExtension

Nov 30 2017, 2:55 PM

Nov 21 2017

avivey created T13019: Build Status is integrated into Diffusion in a hacky way.
Nov 21 2017, 12:46 PMDiffusion, Harbormaster

Nov 20 2017

avivey renamed T12525: amckinley's Onboarding from Onboard to amckinley's Onboarding.
Nov 20 2017, 12:36 PMPhacility, Contributor Onboarding

Nov 17 2017

avivey added a comment to T13017: *.phacility.com TLS certificate expiration.

https://phacility.com/ is still giving ssl error - it's net::ERR_CERT_COMMON_NAME_INVALID, I think (Maybe *.x doesn't cover x?)

Nov 17 2017, 1:58 PMPhacility, Ops

Nov 16 2017

avivey created T13016: Modulerize FileImageTransform implementation.
Nov 16 2017, 11:18 AMModernization

Nov 14 2017

avivey awarded T13015: Improve color readability for change age in Diffusion blame view a Like token.
Nov 14 2017, 8:04 PMDesign, Diffusion

Nov 10 2017

avivey added Q643: Using staging area to build will make storage larger. How to deal with it? (Answer 563).
Nov 10 2017, 9:43 AM

Nov 5 2017

avivey added a comment to D18760: Modernize QuickSearch typeahead.

I could add an isAvailableInGlobalSearch() method to PhabricatorTypeaheadDatasource, but it felt like there are too many of those to filter in run-time.

Nov 5 2017, 2:41 PM
avivey requested review of D18760: Modernize QuickSearch typeahead.
Nov 5 2017, 2:41 PM

Oct 31 2017

avivey added a comment to T10109: Differental does not trigger Herald for mundane updates.

From https://discourse.phabricator-community.org/t/644 - it appears that HM now triggers a build on revisions when they are closed via landing, which fails because the build expects a Staging ref. I don't have the setup to test any of it, but the latest revision landed here doesn't show the behavior, so either f7f3dd5b2084 hasn't rolled in here yet, or that user is doing something funny.

Oct 31 2017, 11:09 AMDifferential, Restricted Project, Herald, Bug Report
avivey updated the task description for T3626: Detection of language for some file types isn't good.
Oct 31 2017, 9:09 AMCustomer Impact, Restricted Project, Differential

Oct 9 2017

avivey added inline comments to D18679: Dump tables one at a time, rather than all at once.
Oct 9 2017, 12:44 PM

Oct 7 2017

avivey accepted rP0361591da0d9: (stable) Correct "bin/storage dump" command construction with passwords.
Oct 7 2017, 5:34 PM
avivey renamed T13004: [Stable] bin/storage dump fails if there's a password set from bin/storage dump fails if there's a password set to [Stable] bin/storage dump fails if there's a password set.
Oct 7 2017, 9:20 AMBug Report
avivey created T13004: [Stable] bin/storage dump fails if there's a password set.
Oct 7 2017, 9:16 AMBug Report

Sep 27 2017

avivey added a comment to D18650: Allow filename for linter tests to be explicitly specified.

Also, is there a "help" section for this?

Sep 27 2017, 9:25 AM
avivey added a comment to D18650: Allow filename for linter tests to be explicitly specified.

Maybe call the parameter temp file name?

Sep 27 2017, 9:24 AM

Sep 25 2017

avivey committed rP9f11f310f872: Make PHUITwoColumnView a little more printable (authored by Aviv Eyal <aviv@myclaimly.com>).
Make PHUITwoColumnView a little more printable
Sep 25 2017, 7:56 PM
avivey closed D18583: Make PHUITwoColumnView a little more printable.
Sep 25 2017, 7:56 PM
avivey added a comment to D18583: Make PHUITwoColumnView a little more printable.

There are 4 copies of the important rules because:

  1. !print transformation doesn't handle selector, selector rules, which I guess could be fixed in some way.
  2. At least in my tests, .device-desktop .phabricator-action-list-view + .phui-curtain-panel {...} beats @media print { .phabricator-action-list-view + .phui-curtain-panel { ... }}, so it needs the !print .device-desktop variant.
  3. In my Chrome, the print layout depends on the width of the window that prints - if the window is narrow enough for .device, the print css gets the .device tag. I'm not sure if this is javascript or media calculations? That makes the !print w/o device-desktop needed (Although I guess since it's mostly the same rules as the .device variants, we could get rid of those?)
Sep 25 2017, 7:39 PM
avivey updated the test plan for D18583: Make PHUITwoColumnView a little more printable.
Sep 25 2017, 7:31 PM
avivey updated the diff for D18583: Make PHUITwoColumnView a little more printable.

remove border-top

Sep 25 2017, 7:30 PM
avivey added inline comments to D18583: Make PHUITwoColumnView a little more printable.
Sep 25 2017, 7:27 PM
avivey updated the test plan for D18583: Make PHUITwoColumnView a little more printable.
Sep 25 2017, 7:24 PM
avivey updated the diff for D18583: Make PHUITwoColumnView a little more printable.
  • Use !print more
  • Also remove background when printing
Sep 25 2017, 7:23 PM
avivey planned changes to D18583: Make PHUITwoColumnView a little more printable.
Sep 25 2017, 6:55 PM