Page MenuHomePhabricator
Differential D19457

Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI
ClosedPublic
Actions

Authored by epriestley on Jun 1 2018, 8:14 PM.
Tags
None
Referenced Files
F15461936: D19457.id.diff
Tue, Apr 1, 12:31 PM
F15454439: D19457.id46544.diff
Sat, Mar 29, 6:32 PM
F15448352: D19457.id46548.diff
Fri, Mar 28, 4:20 AM
F15445881: D19457.id.diff
Thu, Mar 27, 4:21 PM
F15439828: D19457.diff
Wed, Mar 26, 9:40 AM
F15426687: D19457.id46544.diff
Sun, Mar 23, 10:28 AM
F15419540: D19457.diff
Fri, Mar 21, 6:54 AM
F15384224: D19457.id.diff
Fri, Mar 14, 7:12 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
T13148: css: ginormous images go over preview panel in Files
Commits
rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering…
Summary

Fixes T13148. Ref T13105. The new document rendering engine for images let them overflow the UI bounds.

Add max-width: 100%; to keep them contained.

Test Plan
  • Viewed a very wide image in Safari, Firefox and Chrome. Saw sensible rendering.
  • Also viewed a normal image, saw normal behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
webroot/
rsrc/
css/
phui/
1 line

Diff 46548

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility