HomePhabricator
Diffusion Phabricator 15e6e2adea61

Update install_ubuntu.sh to the new age
15e6e2adea61
Actions

Description

Update install_ubuntu.sh to the new age

Summary:
Ref T4200. Since the last time this script was written, Ubuntu has made lots of changes.
Try to keep up with those.

Test Plan:
Ran this on frash installs of Ubuntu 16.04 LTS and 18.04 LTS (Pre-release).
Got to see Phabricator running.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: amckinley, Korvin

Maniphest Tasks: T4200

Differential Revision: https://secure.phabricator.com/D19394

Details

Provenance
aviveyAuthored on Apr 21 2018, 4:42 AM
aviveyPushed on Apr 21 2018, 4:58 PM
Reviewer
Blessed Reviewers
Differential Revision
D19394: Update install_ubuntu.sh to the new age
Parents
rP7622f6afccf4: Fix excessively severe CSP URI error during first-time setup
Branches
Unknown
Tags
Unknown
Tasks
T4200: Building OS packages and install scripts
Build Status
Buildable 20211
Build 27426: Run Core Tests

Event Timeline

avivey committed rP15e6e2adea61: Update install_ubuntu.sh to the new age (authored by avivey).Apr 21 2018, 4:57 PM
avivey added a task: T4200: Building OS packages and install scripts.
Harbormaster completed building B20211: rP15e6e2adea61: Update install_ubuntu.sh to the new age.Apr 21 2018, 4:59 PM
eadler added a subscriber: eadler.Apr 21 2018, 5:08 PM
eadler added inline comments.
/scripts/install/install_ubuntu.sh
24

style: prefer $() over backticks

40

style: prefer directly testing commands rather than checking $?

48

ditto above. I won't repeat for the rest

78–79

style: prefer directly using $() in the string; I had to look to see where $ROOT was used

avivey added a comment.Apr 22 2018, 9:26 PM

Want to counter-diff, @eadler?

Changes (1)

PathSize
scripts/
install/

rP15e6e2adea61

View Options

scripts/install/install_ubuntu.sh

Loading...
Phabricator · Built by Phacility