See https://discourse.phabricator-community.org/t/bin-storage-dump-throws-an-exception/542
(I don't have an env to patch this right now, but it's a obvious once you know what to look for)
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| rP8edd04aff365 (stable) Fix "bin/storage dump" with no "--output" | |||
| rP4fd9d2d4bbdb Fix "bin/storage dump" with no "--output" | |||
| rP0361591da0d9 (stable) Correct "bin/storage dump" command construction with passwords | |||
| rP1ee7b3ab8cbb Correct "bin/storage dump" command construction with passwords | |||
Related Objects
Related Objects
Event Timeline
Comment Actions
Thanks for the fix on that. I have my nightly backups running again, however I had to switch from
./bin/storage dump | gzip > file.sql.gz
to
phab/bin/storage dump --output file.sql.gz --compress
if the output file is not specified, the script errors out on line 241 as it is looking for a file but it is set to $null.
Not breaking my flow as I can use the other syntax but figured I'd let you know.
root@vps:~$ phab/bin/storage dump [2017-10-07 12:49:04] EXCEPTION: (Exception) Failed to open file "" for writing. at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php:241] arcanist(head=stable, ref.master=8762e3f36715, ref.stable=282b83bcbed4), phabricator(head=stable, ref.master=85011a46d0aa, ref.stable=0361591da0d9, custom=1), phutil(head=stable, ref.master=230c3e161c9a, ref.stable=b395c100c20b), sprint(head=master, ref.master=7a7368cd2162) #0 PhabricatorStorageManagementDumpWorkflow::didExecute(PhutilArgumentParser) called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:107] #1 PhabricatorStorageManagementWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:441] #2 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:333] #3 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/sql/manage_storage.php:249]
Comment Actions
We should probably update the documentation to recommend --output and --compress, since the error behavior (e.g., in the event of a full disk) is better.