Page MenuHomePhabricator

Fix Javascript busy loop when trying to delete tokens from an empty tokenizer
ClosedPublic

Authored by epriestley on Jun 1 2018, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 10:34 PM
Unknown Object (File)
Tue, Dec 31, 12:20 AM
Unknown Object (File)
Mon, Dec 30, 10:27 PM
Unknown Object (File)
Sat, Dec 21, 3:16 PM
Unknown Object (File)
Nov 29 2024, 12:25 PM
Unknown Object (File)
Nov 26 2024, 6:20 AM
Unknown Object (File)
Oct 23 2024, 4:42 PM
Unknown Object (File)
Oct 23 2024, 3:06 PM
Subscribers
None

Details

Summary

Fixes T13147. In D19437, I changed this logic to support deleting the "" (empty string) token, but [].pop() returns undefined, not null, if the list is empty and I didn't think to try deleting an empty input.

Fix the logic so we don't end up in a loop if the input is empty.

Test Plan
  • In any browser, deleted all tokens in a tokenizer; then pressed delete again.
  • Before: tab hangs in an infinte loop.
  • After: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

👍
Javascript is !!fun!!.

This revision is now accepted and ready to land.Jun 1 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.