It appears that PHUICircleView no longer exists, so calling this moot.

See T13602 for modern followup, recent changes, and plans.

I think this was at least approximately resolved by D21115, which made the default log much quieter and the "debug" log more verbose.

Seems okay for me, too. Calling this resolved, thanks for the report!

That covered everything that looked low-hanging.

From "--trace", client PHID generation seems to be the limiting factor.

A minimal implementation here is probably:

See T13612 for followup.

Continued in T13612.

See T13602 for eventual followup.

I'm going to close this in favor of T13602, which has a more cohesive/modern discussion of the issue. Broadly:

Ah! I like that fix, and it also works for me locally. I think the protocol-length-limit is reasonable to retain on the basis of general sanity, but I'll add the negative lookbehind to further encourage PCRE to run in something resembling O(N) time.

This is at least approximately resolved by D21562. Hopefully that'll stick if I don't kick it anymore. I may or may not land D21561, depending on whether I ultimately use it in T13586.

This passes tests, but it sure is a big mess compared to a 3-character change to just add a maximum length, and discretion is the better part of avoiding a sunk cost fallacy or something along those lines:

At least on my system, no: \w+, \w{3,}, and \w{3,}+ all take 60s+ to (fail to) match AAAAAAAA... (with total length 512KB).

We also can't pass $flags to preg_replace_callback(...) because it wasn't supported until PHP 7.4. This means preg_replace_callback() can't operate on a match-offset basis.

• Fix regexp issue.

I've deployed these changes to secure, so hopefully any issues will present themselves.