Page MenuHomePhabricator
Feed Advanced Search

Dec 12 2018

epriestley moved T6115: Allow multi-factor authentication to be a requirement for user subgroups, including administrators from Backlog to MFA on the Auth board.
Dec 12 2018, 8:29 PM · Haskell.org, Auth
epriestley moved T4184: API does not contain user.create from Backlog to Far Future on the Auth board.
Dec 12 2018, 8:28 PM · Restricted Project, FreeBSD, Auth, Conduit
epriestley merged T6117: The login screen is pretty confusing when you have LDAP and Username/Password enabled into T11514: Authentication should have a way to customize the credentials name.
Dec 12 2018, 8:27 PM · Auth, LDAP, Feature Request
epriestley merged task T6117: The login screen is pretty confusing when you have LDAP and Username/Password enabled into T11514: Authentication should have a way to customize the credentials name.
Dec 12 2018, 8:27 PM · Auth
epriestley moved T6549: Backup codes for multi-factor authentication from Backlog to MFA on the Auth board.
Dec 12 2018, 8:26 PM · Restricted Project, Auth
epriestley moved T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available from Backlog to MFA on the Auth board.
Dec 12 2018, 8:26 PM · Haskell.org, Auth
epriestley moved T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers from Backlog to LDAP is Special on the Auth board.
Dec 12 2018, 8:25 PM · Auth
epriestley closed T4131: Store LDAP domain as credential source for LDAP external accounts as Wontfix.

I think we're going to fix this with T7667 instead. Binding to a particular domain creates headaches if you actually move the LDAP server, and unlocked authentication creates a lot of other problems that we can't address in a similar way.

Dec 12 2018, 8:25 PM · Auth, Security
epriestley moved T4131: Store LDAP domain as credential source for LDAP external accounts from Backlog to Next on the Auth board.
Dec 12 2018, 8:24 PM · Auth, Security
epriestley closed T5210: Support GitHub Enterprise as an OAuth Provider as Wontfix.

This is conceptually easy but we have no outstanding requests from customers.

Dec 12 2018, 8:24 PM · Auth
epriestley moved T5351: Phabricator shows "Anyone can register an account" even if no registration-enabled auth providers exist from Backlog to Next on the Auth board.
Dec 12 2018, 8:23 PM · Restricted Project, Auth
epriestley closed T814: Support HTTP Basic Auth as an authentication mechanism as Wontfix.

At this point, I don't anticipate this ever coming upstream. This is probably a good candidate for third-party maintenance after T5055.

Dec 12 2018, 8:23 PM · Restricted Project, OpenStack, Auth
epriestley moved T6703: Allow multiple copies of the same auth provider type from Backlog to Next on the Auth board.
Dec 12 2018, 8:20 PM · Auth
epriestley moved T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI from Backlog to Next on the Auth board.
Dec 12 2018, 8:19 PM · Auth, Security
epriestley moved T8029: make it possible to "approve" a user from the profile view from Backlog to Next on the Auth board.
Dec 12 2018, 8:19 PM · Auth, People
epriestley moved T8630: Prompt users when they login with an account that has changed email addresses from Backlog to Far Future on the Auth board.
Dec 12 2018, 8:18 PM · Restricted Project, Auth
epriestley moved T8907: Auto-focus first login field on login page from Backlog to Next on the Auth board.
Dec 12 2018, 8:05 PM · Auth
epriestley moved T10071: New account e-mail invites do not allow registration on auth providers that do not allow registration from Backlog to Next on the Auth board.
Dec 12 2018, 8:04 PM · Auth, Bug Report
epriestley moved T9770: It is possible to use the same 2FA token more than once from Backlog to Next on the Auth board.
Dec 12 2018, 8:03 PM · Security, Auth
epriestley moved T11514: Authentication should have a way to customize the credentials name from Backlog to Next on the Auth board.
Dec 12 2018, 8:02 PM · Auth, LDAP, Feature Request
epriestley closed T10095: provide administrators more hints to track down initial failed logins as Wontfix.

This doesn't seem to be cropping up terribly often and I think this use case is fairly weak.

Dec 12 2018, 8:01 PM · Restricted Project, Restricted Project, Auth, Feature Request
epriestley closed T10221: upgrading to ubuntu 15.10 breaks google authentication as Invalid.

Presuming something fixed this.

Dec 12 2018, 7:58 PM · Auth, Bug Report
epriestley closed T11277: Provide a generic SSH public key store for users as Wontfix.

This might happen eventually, or as a side effect of T7303, but the use case here is pretty narrow and there's currently no customer interest so I don't currently anticipate building it.

Dec 12 2018, 7:55 PM · Auth, Feature Request
epriestley closed T2549: Support linking multiple external accounts from the same provider with one Phabricator account as Wontfix.

There are two flavors of this:

Dec 12 2018, 7:53 PM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer
epriestley moved T10452: Provide more flexible management over disabling/changing ldap user accounts from Backlog to LDAP is Special on the Auth board.
Dec 12 2018, 7:46 PM · Restricted Project, LDAP, Auth, Feature Request
epriestley closed T10392: Verify that VCS Password does not match LDAP Password as Wontfix.

Password management is in good shape after T13043 , and this would now be fairly easy to implement in a general way by adding a check in PhabricatorAuthPasswordEngine->isUniquePassword().

Dec 12 2018, 7:46 PM · Auth, Feature Request
epriestley moved T4256: Support Azure as an auth provider from Far Future to Not Likely on the Auth board.
Dec 12 2018, 7:39 PM · Auth
epriestley moved T13044: SAML Support from Backlog to Not Likely on the Auth board.
Dec 12 2018, 7:39 PM · Auth
epriestley committed rP2814d340367c: Fix a stray qsprintf() in the Herald rules engine when recording rule… (authored by epriestley).
Fix a stray qsprintf() in the Herald rules engine when recording rule…
Dec 12 2018, 7:31 PM
epriestley closed D19872: Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects.
Dec 12 2018, 7:31 PM
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 12 2018, 7:30 PM · Plans
epriestley committed rP265f1f9c4d8a: Fix an issue with item list view icon labels (including Differential date… (authored by epriestley).
Fix an issue with item list view icon labels (including Differential date…
Dec 12 2018, 7:08 PM
epriestley closed D19871: Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UI.
Dec 12 2018, 7:08 PM
epriestley requested review of D19872: Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects.
Dec 12 2018, 7:00 PM
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19872: Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects.
Dec 12 2018, 6:59 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley closed T13217: Upgrading: Hardening of qsprintf() as Resolved.

There are probably some stragglers that have yet to turn up, but we appear to have survived this largely unscathed.

Dec 12 2018, 6:19 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley requested review of D19871: Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UI.
Dec 12 2018, 5:32 PM
epriestley added inline comments to D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 12 2018, 5:31 PM
epriestley committed rARCeb732555a71a: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule (authored by epriestley).
Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Dec 12 2018, 5:22 PM
epriestley closed D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule.
Dec 12 2018, 5:22 PM
epriestley committed rP66ff6d4a2ca0: Fix an issue with creating tasks directly into workboard columns (authored by epriestley).
Fix an issue with creating tasks directly into workboard columns
Dec 12 2018, 5:21 PM
epriestley closed D19870: Fix an issue with creating tasks directly into workboard columns.
Dec 12 2018, 5:21 PM
epriestley committed rPd8e2bb9f0f51: Fix some straggling qsprintf() warnings in repository import (authored by epriestley).
Fix some straggling qsprintf() warnings in repository import
Dec 12 2018, 5:21 PM
epriestley closed D19869: Fix some straggling qsprintf() warnings in repository import.
Dec 12 2018, 5:21 PM
epriestley requested review of D19870: Fix an issue with creating tasks directly into workboard columns.
Dec 12 2018, 4:26 PM
epriestley added a comment to D19842: Allow "Change Subtype" to be selected from the comment action stack.

D19870 fixes one workflow I missed: creating a task directly into a column from the workboard UI.

Dec 12 2018, 4:26 PM
epriestley requested review of D19869: Fix some straggling qsprintf() warnings in repository import.
Dec 12 2018, 1:27 PM
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): D19869: Fix some straggling qsprintf() warnings in repository import.
Dec 12 2018, 1:25 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a comment to D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule.

Test failure is a JSHint version thing and will be mooted by T13098, which either removes or rewrites it.

Dec 12 2018, 1:17 PM
epriestley requested review of D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule.
Dec 12 2018, 1:17 PM

Dec 11 2018

epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 11 2018, 12:28 AM · Plans
epriestley committed rP0e067213fbb1: Make viewing a user's profile page clear notifications about that user (authored by epriestley).
Make viewing a user's profile page clear notifications about that user
Dec 11 2018, 12:26 AM
epriestley closed D19867: Make viewing a user's profile page clear notifications about that user.
Dec 11 2018, 12:26 AM
epriestley requested review of D19867: Make viewing a user's profile page clear notifications about that user.
Dec 11 2018, 12:17 AM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19867: Make viewing a user's profile page clear notifications about that user.
Dec 11 2018, 12:15 AM · Plans
epriestley committed rP05900a4cc990: Add a CLI workflow for testing that notifications are being delivered (authored by epriestley).
Add a CLI workflow for testing that notifications are being delivered
Dec 11 2018, 12:06 AM
epriestley closed D19866: Add a CLI workflow for testing that notifications are being delivered.
Dec 11 2018, 12:06 AM
epriestley committed rPe43f9124f8d4: Remove obsolete "NotifyTest" feed story (authored by epriestley).
Remove obsolete "NotifyTest" feed story
Dec 11 2018, 12:03 AM
epriestley closed D19865: Remove obsolete "NotifyTest" feed story.
Dec 11 2018, 12:03 AM
epriestley committed rP773b4eaa9ea0: Separate "feed" and "notifications" better, allow stories to appear in… (authored by epriestley).
Separate "feed" and "notifications" better, allow stories to appear in…
Dec 11 2018, 12:03 AM
epriestley closed T10743: Test notifications should not be broadcast globally in feed as Resolved by committing rP773b4eaa9ea0: Separate "feed" and "notifications" better, allow stories to appear in….
Dec 11 2018, 12:02 AM · Aphlict
epriestley closed D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only.
Dec 11 2018, 12:02 AM
epriestley committed rPba833805656e: Update the "Notification Test" workflow to use more modern mechanisms (authored by epriestley).
Update the "Notification Test" workflow to use more modern mechanisms
Dec 11 2018, 12:02 AM
epriestley closed D19861: Update the "Notification Test" workflow to use more modern mechanisms.
Dec 11 2018, 12:02 AM
epriestley committed rP55a1ef339f45: Fix a bad method call signature throwing exceptions in newer Node (authored by epriestley).
Fix a bad method call signature throwing exceptions in newer Node
Dec 11 2018, 12:01 AM
epriestley closed D19860: Fix a bad method call signature throwing exceptions in newer Node.
Dec 11 2018, 12:01 AM

Dec 10 2018

epriestley committed rP508df60a6217: When users mark their own inline comments as "Done", suppress the timeline/mail… (authored by epriestley).
When users mark their own inline comments as "Done", suppress the timeline/mail…
Dec 10 2018, 11:37 PM
epriestley closed D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories.
Dec 10 2018, 11:37 PM
epriestley committed rP46feccdfcf19: Share more inline "Done" code between Differential and Diffusion (authored by epriestley).
Share more inline "Done" code between Differential and Diffusion
Dec 10 2018, 11:37 PM
epriestley closed D19858: Share more inline "Done" code between Differential and Diffusion.
Dec 10 2018, 11:37 PM
epriestley added a comment to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

When users click "Create Subtask", we now look for a list of possible subtask forms.

Dec 10 2018, 11:30 PM · Feature Request
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 10 2018, 11:24 PM · Plans
epriestley committed rP68b1dee1390d: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you… (authored by epriestley).
Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you…
Dec 10 2018, 10:59 PM
epriestley closed T12588: create subtask side menu to allow creation of subtasks of different types to the parent task as Resolved by committing rP68b1dee1390d: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you….
Dec 10 2018, 10:59 PM · Feature Request
epriestley closed D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 10 2018, 10:59 PM
epriestley committed rPa6632f8c188a: Allow "maniphest.subtypes" to configure which options are presented by "Create… (authored by epriestley).
Allow "maniphest.subtypes" to configure which options are presented by "Create…
Dec 10 2018, 10:58 PM
epriestley closed D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask".
Dec 10 2018, 10:58 PM
epriestley committed rPd1bcdaeda467: Allow the "Create Subtask" workflow to prompt for a subtype selection, and… (authored by epriestley).
Allow the "Create Subtask" workflow to prompt for a subtype selection, and…
Dec 10 2018, 10:44 PM
epriestley closed D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options.
Dec 10 2018, 10:44 PM
epriestley requested review of D19866: Add a CLI workflow for testing that notifications are being delivered.
Dec 10 2018, 10:37 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19866: Add a CLI workflow for testing that notifications are being delivered.
Dec 10 2018, 10:36 PM · Plans
epriestley requested review of D19865: Remove obsolete "NotifyTest" feed story.
Dec 10 2018, 10:27 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19865: Remove obsolete "NotifyTest" feed story.
Dec 10 2018, 10:26 PM · Plans
epriestley requested review of D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only.
Dec 10 2018, 10:25 PM
epriestley added a revision to T10743: Test notifications should not be broadcast globally in feed: D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only.
Dec 10 2018, 10:23 PM · Aphlict
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only.
Dec 10 2018, 10:23 PM · Plans
epriestley accepted D19863: Make it less confusing to create root-level Phriction doc.

Maybe consider setIsWelcomeDocument() or setHideNewDocumentButton(), on first read it was a little surprising that the effect of showWelcomeDocument isn't to cause a welcome document to be shown.

Dec 10 2018, 9:49 PM
epriestley accepted D19862: Fix handling of Phriction conduit edits.

These should probably be strlen(...) tests -- as written, setting the title or content to 0 likely does not work.

Dec 10 2018, 9:00 PM
epriestley requested review of D19861: Update the "Notification Test" workflow to use more modern mechanisms.
Dec 10 2018, 8:37 PM
epriestley added a revision to T10743: Test notifications should not be broadcast globally in feed: D19861: Update the "Notification Test" workflow to use more modern mechanisms.
Dec 10 2018, 8:35 PM · Aphlict
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19861: Update the "Notification Test" workflow to use more modern mechanisms.
Dec 10 2018, 8:35 PM · Plans
epriestley requested review of D19860: Fix a bad method call signature throwing exceptions in newer Node.
Dec 10 2018, 7:45 PM
epriestley added a revision to T10743: Test notifications should not be broadcast globally in feed: D19860: Fix a bad method call signature throwing exceptions in newer Node.
Dec 10 2018, 7:43 PM · Aphlict
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19860: Fix a bad method call signature throwing exceptions in newer Node.
Dec 10 2018, 7:43 PM · Plans
epriestley requested review of D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories.
Dec 10 2018, 7:09 PM
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 10 2018, 7:09 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories.
Dec 10 2018, 7:07 PM · Plans
epriestley added a comment to Eagle Eye.

This is a great badge!

Dec 10 2018, 6:53 PM
epriestley updated subscribers of Eagle Eye.
Dec 10 2018, 6:53 PM
epriestley requested review of D19858: Share more inline "Done" code between Differential and Diffusion.
Dec 10 2018, 6:42 PM