Page MenuHomePhabricator

Fix a bad method call signature throwing exceptions in newer Node
ClosedPublic

Authored by epriestley on Dec 10 2018, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 12:32 PM
Unknown Object (File)
Sat, May 10, 6:47 AM
Unknown Object (File)
Fri, May 9, 12:57 PM
Unknown Object (File)
Thu, May 1, 11:58 PM
Unknown Object (File)
Apr 24 2025, 12:53 AM
Unknown Object (File)
Apr 18 2025, 11:40 AM
Unknown Object (File)
Apr 17 2025, 5:59 PM
Unknown Object (File)
Apr 8 2025, 5:04 AM
Subscribers
None

Details

Summary

Ref T13222. See PHI996. Ref T10743. For context, perhaps see T12171.

Node changed some signatures, behaviors, and error handling here in recent versions. As far as I can tell:

  • The script.runInNewContext(...) method has never taken a path parameter, and passing the path has always been wrong.
  • The script.runInNewContext(...) method started taking an [options] parameter at some point, and validating it, so the bad path parameter now throws.
  • vm.createScript(...) is "soft deprecated" but basically fine, and keeping it looks more compatible.

This seems like the smallest and most compatible correct change.

Test Plan

Under Node 10, started Aphlict. Before: fatal error on bad options parameter to runInNewContext() (expected dictionary). After: notification server starts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable