Page MenuHomePhabricator

Fix handling of Phriction conduit edits
ClosedPublic

Authored by amckinley on Dec 10 2018, 8:53 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/conduit-method-phriction-edit-requires-title-while-the-docs-say-its-optional/2176. Make code consistent with documentation by not requiring either content or title.

Test Plan

Hit the method via the UI and no longer got an error on missing content or title fields.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Dec 10 2018, 8:53 PM
amckinley requested review of this revision.Dec 10 2018, 8:54 PM
epriestley accepted this revision.Dec 10 2018, 9:00 PM

These should probably be strlen(...) tests -- as written, setting the title or content to 0 likely does not work.

This revision is now accepted and ready to land.Dec 10 2018, 9:00 PM
amckinley updated this revision to Diff 47426.Dec 10 2018, 9:37 PM

Switch to strlen.

This revision was automatically updated to reflect the committed changes.