Page MenuHomePhabricator
Differential D19862

Fix handling of Phriction conduit edits
ClosedPublic
Actions

Authored by amckinley on Dec 10 2018, 8:53 PM.
Tags
None
Referenced Files
F15572783: D19862.id47425.diff
Mon, May 5, 5:42 PM
F15528260: D19862.id47425.diff
Tue, Apr 22, 10:02 AM
F15522973: D19862.id47426.diff
Sun, Apr 20, 10:47 PM
F15512415: D19862.id.diff
Thu, Apr 17, 10:33 AM
F15511193: D19862.diff
Thu, Apr 17, 12:14 AM
F15506155: D19862.id.diff
Tue, Apr 15, 8:55 AM
F15503626: D19862.diff
Mon, Apr 14, 11:32 AM
F15468077: D19862.diff
Apr 3 2025, 8:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP00a7071e2d1d: Fix handling of Phriction conduit edits
Summary

See https://discourse.phabricator-community.org/t/conduit-method-phriction-edit-requires-title-while-the-docs-say-its-optional/2176. Make code consistent with documentation by not requiring either content or title.

Test Plan

Hit the method via the UI and no longer got an error on missing content or title fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley created this revision.Dec 10 2018, 8:53 PM
Harbormaster completed remote builds in B21278: Diff 47425.Dec 10 2018, 8:54 PM
amckinley requested review of this revision.Dec 10 2018, 8:54 PM
Herald added a subscriber: Korvin. · View Herald TranscriptDec 10 2018, 8:54 PM
epriestley accepted this revision.Dec 10 2018, 9:00 PM

These should probably be strlen(...) tests -- as written, setting the title or content to 0 likely does not work.

This revision is now accepted and ready to land.Dec 10 2018, 9:00 PM
amckinley updated this revision to Diff 47426.Dec 10 2018, 9:37 PM

Switch to strlen.

Closed by commit rP00a7071e2d1d: Fix handling of Phriction conduit edits (authored by amckinley). · Explain WhyDec 10 2018, 9:38 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B21279: Diff 47426.Dec 10 2018, 9:39 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
conduit/
19 lines

Diff 47427

View Options

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility