Page MenuHomePhabricator

Fix an issue with creating tasks directly into workboard columns
ClosedPublic

Authored by epriestley on Dec 12 2018, 4:25 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/tasks-created-via-workboard-column-menu-are-moved-to-wrong-column/2200. The recent setIsConduitOnly() / setIsFormField() change (in D19842) disrupted creating tasks directly into a column from the workboard UI.

This field is a form field, it just doesn't render a visible control.

Test Plan
  • Created a task directly into a workboard column. Before: column selection ignored. After: appeared in correct column.
  • Used "move on workboard" comment action.
  • Edited tasks; edited forms for tasks. Didn't observe any collateral damage (weird "Column" fields being present).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 12 2018, 4:25 PM
epriestley requested review of this revision.Dec 12 2018, 4:26 PM
amckinley accepted this revision.Dec 12 2018, 4:35 PM
This revision is now accepted and ready to land.Dec 12 2018, 4:35 PM
This revision was automatically updated to reflect the committed changes.