Page MenuHomePhabricator

Fix some straggling qsprintf() warnings in repository import
ClosedPublic

Authored by epriestley on Dec 12 2018, 1:25 PM.
Tags
None
Referenced Files
F15444594: D19869.diff
Thu, Mar 27, 10:14 AM
F15426274: D19869.diff
Sun, Mar 23, 7:54 AM
F15407738: D19869.diff
Tue, Mar 18, 7:14 PM
F15381725: D19869.diff
Fri, Mar 14, 9:05 AM
F15341050: D19869.diff
Sun, Mar 9, 6:21 PM
F15309015: D19869.id47449.diff
Thu, Mar 6, 6:49 AM
F15309014: D19869.id47447.diff
Thu, Mar 6, 6:49 AM
F15309013: D19869.id.diff
Thu, Mar 6, 6:49 AM
Subscribers
None

Details

Summary

Ref T13217. See https://discourse.phabricator-community.org/t/unsafe-raw-string-warnings-while-importing-git-commits/2191.

Hunt down and fix two more qsprintf() things.

I just converted the "performance optimization" into a normal, safe call since we're dealing with far less SVN stuff nowadays and the actual issue has been lost in the mists of time. If it resurfaces, we can take another look.

Test Plan

Imported some commits, no longer saw these warnings in the daemon logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable