Page MenuHomePhabricator

Fix some straggling qsprintf() warnings in repository import
ClosedPublic

Authored by epriestley on Dec 12 2018, 1:25 PM.
Tags
None
Referenced Files
F18834371: D19869.id.diff
Sun, Oct 26, 8:19 AM
F18832299: D19869.diff
Sat, Oct 25, 9:15 PM
F18823690: D19869.diff
Thu, Oct 23, 12:58 PM
F18823136: D19869.diff
Thu, Oct 23, 10:19 AM
F18813896: D19869.id47447.diff
Mon, Oct 20, 7:45 PM
F18807978: D19869.id47447.diff
Sun, Oct 19, 4:22 AM
F18804213: D19869.id47447.diff
Sat, Oct 18, 6:54 AM
F18803834: D19869.id47447.diff
Sat, Oct 18, 4:13 AM
Subscribers
None

Details

Summary

Ref T13217. See https://discourse.phabricator-community.org/t/unsafe-raw-string-warnings-while-importing-git-commits/2191.

Hunt down and fix two more qsprintf() things.

I just converted the "performance optimization" into a normal, safe call since we're dealing with far less SVN stuff nowadays and the actual issue has been lost in the mists of time. If it resurfaces, we can take another look.

Test Plan

Imported some commits, no longer saw these warnings in the daemon logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable