Page MenuHomePhabricator

Fix some straggling qsprintf() warnings in repository import
ClosedPublic

Authored by epriestley on Dec 12 2018, 1:25 PM.

Details

Summary

Ref T13217. See https://discourse.phabricator-community.org/t/unsafe-raw-string-warnings-while-importing-git-commits/2191.

Hunt down and fix two more qsprintf() things.

I just converted the "performance optimization" into a normal, safe call since we're dealing with far less SVN stuff nowadays and the actual issue has been lost in the mists of time. If it resurfaces, we can take another look.

Test Plan

Imported some commits, no longer saw these warnings in the daemon logs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 12 2018, 1:25 PM
epriestley requested review of this revision.Dec 12 2018, 1:27 PM
amckinley accepted this revision.Dec 12 2018, 4:34 PM
This revision is now accepted and ready to land.Dec 12 2018, 4:34 PM
This revision was automatically updated to reflect the committed changes.