Page MenuHomePhabricator
Feed Advanced Search

Apr 10 2017

epriestley triaged T11399: Add support for locations in calendar events as Wishlist priority.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley moved T12295: Allow commenting on imported calendar events from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley triaged T12295: Allow commenting on imported calendar events as Wishlist priority.

This is technically possible (and I believe imported events do have some support for mutation within Phabricator today: for example, I believe you can award them tokens). However, I'm very hesitant to start making imported events writable.

Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley added a subtask for T12295: Allow commenting on imported calendar events: T11800: When duplicate events are imported into Calendar, show viewers only the best version.
Apr 10 2017, 10:58 AM · Calendar, Feature Request
epriestley added a parent task for T11800: When duplicate events are imported into Calendar, show viewers only the best version: T12295: Allow commenting on imported calendar events.
Apr 10 2017, 10:58 AM · Calendar

Mar 31 2017

CodeMouse92 created T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.
Mar 31 2017, 6:37 PM · Calendar, Bug Report

Mar 30 2017

EddieGP added a comment to T11816: Calendar: Feedback and Suggestions.

I have noticed some strange behaviour with recurring events, which I've first documented at Wikimedias Phabricator. It's about what every programmer I know hates: Daylight saving times. Short version is: Phabricator locks time windows of recurring events to the time the event creator had in his time zone settings when he created the event, but does neither give an option to select another time zone to lock to nor does even show which time zone this is currently locked to.

Mar 30 2017, 2:09 AM · Restricted Project, Calendar

Mar 27 2017

ivo added a comment to T11816: Calendar: Feedback and Suggestions.

We encountered a weird bug: a colleague was shown as Busy today because she's attending an event that takes place tomorrow. Calendar on her profile page:

Mar 27 2017, 6:37 PM · Restricted Project, Calendar

Mar 24 2017

epriestley closed T12395: Calendar events aren't sufficiently exhaustive during destruction as Resolved by committing rPdaeb94561f14: When destroying Calendar events, destroy invitees and notifications.
Mar 24 2017, 4:21 PM · Calendar
epriestley added a revision to T12395: Calendar events aren't sufficiently exhaustive during destruction: D17555: When destroying Calendar events, destroy invitees and notifications.
Mar 24 2017, 4:14 PM · Calendar

Mar 20 2017

epriestley moved T12395: Calendar events aren't sufficiently exhaustive during destruction from Backlog to Unprototype (v1) on the Calendar board.
Mar 20 2017, 2:32 PM · Calendar

Mar 16 2017

chad added a comment to T421: Show it to me Calimonk!.

Do this man

Mar 16 2017, 2:00 AM · newyork, Arcanist (Milestone 1), Restricted Project, Localization, ircbot, External, DeviantArt, Database, Dashboard, Dashboards, Daemons, Conpherence, Calendar, Chatlog, Unknown Object (Project)

Mar 13 2017

isfs added a comment to T7930: Let Calendar provide date services to other applications.

Something that would be useful to us would be the ability to create, or probably better, assign a task, as it nears a due date. E.g. we may set up a task due in a year's time, and anticipate working on it two months before it is due. It would be great to be able to schedule the task to be assigned on a particular date, and perhaps moved on a workboard. I don't think this would need to be any more complicated than a Herald action that runs at a particular date/time rather than in response to some other action. I'm not familiar with what Calendar can already do, as we don't have prototype applications turned on for our install, so apologies if this is already possible. I just thought I would mention this use case here for future reference.

Mar 13 2017, 11:29 PM · Calendar
epriestley created T12395: Calendar events aren't sufficiently exhaustive during destruction.
Mar 13 2017, 8:01 PM · Calendar

Mar 11 2017

chad closed T12384: CFM Review L15 as Invalid.
Mar 11 2017, 2:35 PM · Calendar
lizzy9392 created T12384: CFM Review L15.
Mar 11 2017, 9:31 AM · Calendar

Mar 7 2017

chad added a project to T12356: Calendar Notification is not respecting my Time Zone Settings: Calendar.
Mar 7 2017, 2:16 AM · Calendar, Bug Report

Feb 20 2017

ivo created T12295: Allow commenting on imported calendar events.
Feb 20 2017, 1:37 PM · Calendar, Feature Request

Feb 18 2017

epriestley added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

I believe we only get it wrong in the very specific case where you're attending a "Busy" event and an "Away" event at the same time. We'll show the dot color for whichever event started first, so if the "Busy" event started before the "Away" event you get an orange dot instead of a red dot (if the "Away" event started first, we show a red dot, but that's the right color to show).

Feb 18 2017, 9:11 PM · Calendar, Bug Report
cspeckmim added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

rare

Maybe my calendar setup isn't common but I usually have multiple overlapping meetings each week - I know others at the same company manage their calendar in a similar fashion.

Feb 18 2017, 6:27 PM · Calendar, Bug Report

Feb 17 2017

epriestley renamed T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate from calendar: away should be displayed first than busy to When a user is attending multiple overlapping events, computation of availability state may not be accurate.
Feb 17 2017, 9:08 PM · Calendar, Bug Report
epriestley added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

Here's the note in PhabricatorPeopleQuery about this:

Feb 17 2017, 5:42 PM · Calendar, Bug Report
Luke081515.2 created T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.
Feb 17 2017, 5:22 PM · Calendar, Bug Report

Feb 15 2017

hach-que added a comment to T7924: Unprototype Calendar (v1).

Is there any way of getting Calendar enabled on a Phacility instance? We're looking to migrate from a self-hosted instance, and it's one of the applications we use to organise meetings, etc.

Feb 15 2017, 3:51 AM · Restricted Project, Prioritized, Calendar

Feb 14 2017

ivo added a comment to T11816: Calendar: Feedback and Suggestions.

When accessing an ICS export of all events I can see (https://secure.phabricator.com/calendar/export/3/):

Unhandled Exception ("Exception")	
DateTime::__construct(): Failed to parse time string (@) at position 0 (@): Unexpected character
Feb 14 2017, 11:46 AM · Restricted Project, Calendar

Feb 12 2017

johnny-bit added a comment to T7930: Let Calendar provide date services to other applications.

I've recently found myself wishing for couple kinds of functionality that would connect calendar and maniphest:

  • "due date" for tasks,
  • recurring tasks (just like events)
  • age-based priority for tasks (dunno if calendar would be involved, but i've seen some instances of similar FRs popping up)
Feb 12 2017, 11:35 AM · Calendar
chad merged T12247: mail notification for those tasks which overdue date into T7930: Let Calendar provide date services to other applications.
Feb 12 2017, 4:00 AM · Calendar

Feb 9 2017

ivo added a comment to T11816: Calendar: Feedback and Suggestions.

Future instances of recurring events aren't visible in panels when an item limit is set:

Feb 9 2017, 1:33 PM · Restricted Project, Calendar

Feb 8 2017

nemobis added a comment to T5296: Allow user-defined date format.

The most important aspect in flexibility is the ability to support all locales. MediaWiki uses a system largely based on PHP's date() for historical reasons, see Language::sprintfDate().

Feb 8 2017, 5:38 PM · Calendar, User Delight, User Preferences

Jan 23 2017

RuralHunter added a comment to T12130: DateTime parsing error in phd log.

OK, it seems utcInstanceEpoch is only used in child event of recurring events according to the code. After I canceled the recurring event(E4), there is no more error in phd log.

Jan 23 2017, 7:35 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

I just created a simple test event and the utcInstanceEpoch column is still NULL. What does this column mean?

Jan 23 2017, 7:27 AM · Calendar, Bug Report (Needs Information)
RuralHunter updated subscribers of T12130: DateTime parsing error in phd log.
Jan 23 2017, 7:12 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a project to T12130: DateTime parsing error in phd log: Calendar.

just FYI, I checked the database and found the utcInstanceEpoch is NULL for some old events, which maybe caused by bug in data migration during upgrade.

Jan 23 2017, 7:11 AM · Calendar, Bug Report (Needs Information)

Jan 17 2017

Alexmoon2 added projects to T421: Show it to me Calimonk!: Chatlog, Calendar, Conpherence, Daemons, Dashboards, Dashboard, Database, DeviantArt, External, ircbot, Localization, Restricted Project, Arcanist (Milestone 1), newyork.
Jan 17 2017, 9:24 AM · newyork, Arcanist (Milestone 1), Restricted Project, Localization, ircbot, External, DeviantArt, Database, Dashboard, Dashboards, Daemons, Conpherence, Calendar, Chatlog, Unknown Object (Project)

Jan 6 2017

epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D17150: Fix an issue where setting a recurrence end date on a Calendar event without one could fatal.
Jan 6 2017, 9:31 PM · Restricted Project, Calendar
epriestley closed T11945: Unable to edit calendar events created by someone else, even after `bin/policy unlock` as Resolved.

I wasn't able to reproduce this earlier so I'm not sure how to move forward, but feel free to follow up if you have more information.

Jan 6 2017, 9:25 PM · Bug Report (Needs Information), Policy, Calendar
0 added a comment to T11816: Calendar: Feedback and Suggestions.

When I try to make E1211 recurring (see screenshot below), I get

Jan 6 2017, 5:28 AM · Restricted Project, Calendar

Dec 5 2016

epriestley added a project to T11945: Unable to edit calendar events created by someone else, even after `bin/policy unlock` : Bug Report (Needs Information).
Dec 5 2016, 5:10 PM · Bug Report (Needs Information), Policy, Calendar
epriestley added a comment to T11945: Unable to edit calendar events created by someone else, even after `bin/policy unlock` .

Hmm, I'm having trouble reproducing this. Here's what I did:

Dec 5 2016, 5:09 PM · Bug Report (Needs Information), Policy, Calendar

Dec 4 2016

nongmai.orm is attending E1217: Test-event.
Dec 4 2016, 8:32 PM · Calendar
20after4 created T11945: Unable to edit calendar events created by someone else, even after `bin/policy unlock` .
Dec 4 2016, 9:40 AM · Bug Report (Needs Information), Policy, Calendar

Dec 2 2016

epriestley added a comment to T11801: Calendar: ICS Import Errata.

Thanks, that's extremely helpful. I think D16974 + D16975 should fix the bug (and an adjacent bug I hit while testing the first fix).

Dec 2 2016, 12:58 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: D16975: Set the viewer timezone properly on Calendar event RecurrenceSet objects.
Dec 2 2016, 12:57 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: D16974: When resolving a relative date, only ignore the viewer timezone if the date has a timezone.
Dec 2 2016, 12:54 PM · Bug Report, Calendar
carlokok added a comment to T11801: Calendar: ICS Import Errata.

Attached is a single VEVENT that causes "Datetime has no timezone or viewer timezone." in the calendar view after importing, the import itself runs fine.

Dec 2 2016, 11:53 AM · Bug Report, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

In the general case:

Dec 2 2016, 11:20 AM · Restricted Project, Calendar
carlokok added a comment to T11816: Calendar: Feedback and Suggestions.

Getting Datetime has no timezone or viewer timezone when viewing the main calendar.(https://gist.github.com/carlokok/570d524fe2a6dd1472835c0fa67b7faf) after import. Since the import contains a quite a bit of private data, how can I narrow down which record specifically it fails on?

Dec 2 2016, 11:11 AM · Restricted Project, Calendar

Dec 1 2016

carlokok added a comment to T11816: Calendar: Feedback and Suggestions.

It makes sense in retrospect, but not from the workflow no.

Dec 1 2016, 5:32 AM · Restricted Project, Calendar

Nov 30 2016

epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Hmm, I'm guessing this wasn't clear from the workflow either, then?

Nov 30 2016, 6:48 PM · Restricted Project, Calendar
carlokok added a comment to T11816: Calendar: Feedback and Suggestions.

My apologies. I read over that bit and presumed it meant edit the calendar items

Nov 30 2016, 6:37 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Why did you allow everyone everyone edit the event?

Nov 30 2016, 5:15 PM · Restricted Project, Calendar
carlokok added a comment to T11816: Calendar: Feedback and Suggestions.

Everyone can see from which url a calendar event came.

This isn't expected. Can you give me reproduction steps for this?

Nov 30 2016, 4:41 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Everyone can see from which url a calendar event came.

Nov 30 2016, 4:33 PM · Restricted Project, Calendar
carlokok added a comment to T11816: Calendar: Feedback and Suggestions.

My only concern with the current ics importing is that the url for importing from google, owncloud/nextcloud usually contains secrets other users shouldn't see, like in the case of owncloud: un/pw. Everyone can see from which url a calendar event came.

Nov 30 2016, 3:06 PM · Restricted Project, Calendar

Nov 28 2016

brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Thank you! The new dialog looks excellent, it would have prevented my error.

Nov 28 2016, 7:09 PM · Wikimedia, Calendar, Bug Report
epriestley closed T11909: Recurring Events: "Edit all Future Events" edits past instances as well as Resolved by committing rP5cc4f6407ceb: Make the modal choice between "Edit This Event" and "Edit Future Events" more….
Nov 28 2016, 6:48 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Here's the revised dialog after D16956:

Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16956: Make the modal choice between "Edit This Event" and "Edit Future Events" more clear.
Nov 28 2016, 5:50 PM · Restricted Project, Calendar
epriestley added a revision to T11909: Recurring Events: "Edit all Future Events" edits past instances as well: D16956: Make the modal choice between "Edit This Event" and "Edit Future Events" more clear.
Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

I don't think that edit is always invalid: offhand, one reason you might want to make such an edit is so that you can add a tag to all events in a series, allowing you to query them so they can be exported to another calendar. Another case I could imagine is wanting to correct a mistake in the description of an event when you know nothing will be lost by editing future events (e.g., because you are the only user who can edit the event).

Nov 28 2016, 5:49 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16955: Ignore Calendar date edits which just change the internal date timezone without rescheduling it.
Nov 28 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16954: Fix an issue where internal Calendar DateTimes would not be correctly set to all-day.
Nov 28 2016, 4:53 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16953: Fix an issue where all-day events had durations applied incorrectly.
Nov 28 2016, 4:28 PM · Restricted Project, Calendar

Nov 26 2016

brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Maybe it would also be sensible to not allow mass-edits to be triggered by past events. While it may be useful to tweak a single past event, I don't see much of a use case of updating all events starting from some past date. I'd argue that that is nearly always unintended.

Nov 26 2016, 9:01 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • Availability cache build on All-Day events may be off, I didn't pick up a dot for E1222.
Nov 26 2016, 5:11 PM · Restricted Project, Calendar

Nov 25 2016

epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Couple of other things:

Nov 25 2016, 7:07 PM · Restricted Project, Calendar
Luke081515.2 cancelled E1217: Test-event.
Nov 25 2016, 3:17 PM · Calendar
Luke081515.2 added a comment to T11894: Calendar "away icons" do not automatically appear.

Thank you very much, I'll take a look :)

Nov 25 2016, 3:15 PM · Calendar, Bug Report

Nov 24 2016

brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Thanks @epriestley for the reply. Seems like my mental model of "prototypes" along with the misleading wording of "future" threw me off.

Nov 24 2016, 6:29 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

As far as I understand, E66 acts as a prototyp (or template), providing defaults for when the individual instances are "materialized" later, when they are edited. Is that correct?

Nov 24 2016, 3:12 PM · Wikimedia, Calendar, Bug Report
brightbyte added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Hi @epriestley, thank you for your explanation.

Nov 24 2016, 1:57 PM · Wikimedia, Calendar, Bug Report

Nov 23 2016

epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

E1218 seems to have worked properly after the patch, at least.

Nov 23 2016, 11:47 PM · Calendar, Bug Report
epriestley closed T11894: Calendar "away icons" do not automatically appear as Resolved by committing rPeac49e421a41: Fix an issue where an excessively long TTL was computed for "not attending….
Nov 23 2016, 11:22 PM · Calendar, Bug Report
epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

I'm pretty sure D16937 fixes this, thanks for the report! Let us know if you're still seeing issues after that.

Nov 23 2016, 11:16 PM · Calendar, Bug Report
epriestley added a revision to T11894: Calendar "away icons" do not automatically appear: D16937: Fix an issue where an excessively long TTL was computed for "not attending anything" event caches.
Nov 23 2016, 11:10 PM · Calendar, Bug Report
epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

Yeah, looks like that reproduced it. Here are the caches:

Nov 23 2016, 9:06 PM · Calendar, Bug Report
Luke081515.2 changed the edit policy for E1217: Test-event.
Nov 23 2016, 8:35 PM · Calendar
chad declined E1217: Test-event.
Nov 23 2016, 7:40 PM · Calendar
epriestley added a comment to E1217: Test-event.

Sorry, can't make it this time! I'll catch you guys next time for sure.

Nov 23 2016, 7:27 PM · Calendar
chad is attending E1217: Test-event.
Nov 23 2016, 7:03 PM · Calendar
chad added a comment to E1217: Test-event.

frowncat

Nov 23 2016, 7:03 PM · Calendar
Luke081515.2 changed the start date for E1217: Test-event from Nov 23 2016, 7:00 PM to Nov 23 2016, 9:00 PM.
Nov 23 2016, 6:58 PM · Calendar
Luke081515.2 created E1217: Test-event.
Nov 23 2016, 6:57 PM · Calendar
epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

Hmm, can you try creating a test event on this install to see if you can reproduce it here? I played around with this a little bit locally but wasn't able to get it to break.

Nov 23 2016, 6:48 PM · Calendar, Bug Report
Luke081515.2 added a comment to T11894: Calendar "away icons" do not automatically appear.

It's like before: Neither the orange thing appears nor am I listed as "busy" at my profile. I'm listed as available there.

Nov 23 2016, 6:46 PM · Calendar, Bug Report
20after4 added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

This all seems reasonable, I'm actually not 100% sure what happened so I'll try to gather a better understanding of the situation ;)

Nov 23 2016, 7:36 AM · Wikimedia, Calendar, Bug Report

Nov 22 2016

epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Generally, our behavior here is approximately the same as Calendar.app and Google Calendar. T11804 documents how various edge cases behave in those applications. I believe our behavior is no more spooky in any case I'm aware of.

Nov 22 2016, 8:42 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Maybe this is a misinterpretation of "All Future Events"? That means "All events which start after this event starts", not "all events which have not yet occurred, considering the current time".

Nov 22 2016, 8:29 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

I'm still having trouble figuring out which past events were edited. Downstream has this query:

Nov 22 2016, 8:25 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Oh, sorry, E66 would have been disconnected from past events by the edit. Let me look through the downstream task.

Nov 22 2016, 8:22 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Assuming that's just a miscommunication, I can't immediately reproduce this locally:

Nov 22 2016, 8:20 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

E66 is the first event in the series, so I would expect editing E66 "All Future Events" to edit every event in the series: there are no past instances. Am I misunderstanding? What's an example of a past instance?

Nov 22 2016, 8:17 PM · Wikimedia, Calendar, Bug Report
20after4 created T11909: Recurring Events: "Edit all Future Events" edits past instances as well.
Nov 22 2016, 8:07 PM · Wikimedia, Calendar, Bug Report
Luke081515.2 added a comment to T11894: Calendar "away icons" do not automatically appear.

I created a test-event now, it starts in an hour, and I will take a look if this occurs again.

Nov 22 2016, 6:03 PM · Calendar, Bug Report

Nov 21 2016

epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

Although it's very possible that this is a bug, this state also has a 72-hour internal cache which wasn't written correctly in older versions of Phabricator.

Nov 21 2016, 2:34 PM · Calendar, Bug Report

Nov 19 2016

Luke081515.2 created T11894: Calendar "away icons" do not automatically appear.
Nov 19 2016, 9:38 PM · Calendar, Bug Report

Nov 18 2016

aHa added a comment to T11816: Calendar: Feedback and Suggestions.

The Event Hovercards are not really useful: E990 The Mouse-over dialog shows no date and time for example...

Nov 18 2016, 10:23 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16899: In Calendar mobile month view, color circles green for attending events too.
Nov 18 2016, 7:51 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: D16898: Fix a couple of calendar export daterange issues.
Nov 18 2016, 5:37 PM · Restricted Project, Calendar
deric added a comment to T11809: Calendar v1 Errata Mark II.

@epriestley Yeah, you're right. There was a php5-fpm instance running, which i forgot to restart.

Nov 18 2016, 7:35 AM · Calendar