Page MenuHomePhabricator

Fix an issue where all-day events had durations applied incorrectly
ClosedPublic

Authored by epriestley on Nov 28 2016, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 12:06 PM
Unknown Object (File)
Sun, Feb 9, 2:54 AM
Unknown Object (File)
Jan 31 2025, 10:10 PM
Unknown Object (File)
Jan 30 2025, 4:33 AM
Unknown Object (File)
Jan 30 2025, 4:33 AM
Unknown Object (File)
Jan 30 2025, 4:33 AM
Unknown Object (File)
Jan 29 2025, 3:46 AM
Unknown Object (File)
Jan 25 2025, 4:59 PM
Subscribers
None

Details

Summary

Ref T11816. User-visible bug here was that availability dots (away/busy) for all-day events might not appear correctly if the viewer timezone and event timezone differ.

Underlying issue was that when adding a duration (one day) to an all-day event datetime, we incorrectly used the viewer timezone as part of the calculation.

Instead, base the calculation on a clone of the event with no viewer timezone.

Test Plan
  • Added failing unit test, made it pass.
  • Saw proper availability dots for all-day events in Phabricator.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue where all-day events had durations applied incorrectly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 4:30 PM
This revision was automatically updated to reflect the committed changes.