Page MenuHomePhabricator

When resolving a relative date, only ignore the viewer timezone if the date has a timezone
ClosedPublic

Authored by epriestley on Dec 2 2016, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:28 PM
Unknown Object (File)
Feb 15 2024, 12:00 AM
Unknown Object (File)
Feb 8 2024, 1:32 PM
Unknown Object (File)
Jan 21 2024, 2:02 PM
Unknown Object (File)
Jan 21 2024, 1:59 PM
Unknown Object (File)
Jan 15 2024, 7:28 PM
Unknown Object (File)
Jan 8 2024, 6:10 AM
Unknown Object (File)
Dec 27 2023, 8:37 AM
Subscribers
None

Details

Summary

Ref T11801. In some cases, we generate a relative date without having a timezone. In these cases, use the viewer timezone.

Test Plan
  • Added a failing test case and made it pass.
  • Imported the event from T11801#202293, which failed before this change and worked after it.
  • Also added a reduced version of that event as a .ics test case since I caught a different bug. See next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When resolving a relative date, only ignore the viewer timezone if the date has a timezone.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 3:22 PM