Page MenuHomePhabricator

Ignore Calendar date edits which just change the internal date timezone without rescheduling it
ClosedPublic

Authored by epriestley on Nov 28 2016, 5:20 PM.
Tags
None
Referenced Files
F12812595: D16955.diff
Thu, Mar 28, 12:23 AM
Unknown Object (File)
Sat, Mar 23, 3:08 PM
Unknown Object (File)
Feb 3 2024, 1:14 PM
Unknown Object (File)
Feb 1 2024, 10:25 PM
Unknown Object (File)
Jan 21 2024, 6:49 AM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Subscribers
None

Details

Summary

Ref T11816. Currently, if someone in California creates an event and then someone in New York edits it, we generate a no-op "<user> changed the start time from 3PM to 3PM." transaction.

This is because the internal timezone of the event is changing, but the actual absolute time is not.

Instead, when an edit wouldn't reschedule an event and would only change the internal timezone, ignore the edit.

Test Plan
  • Edited non-all-day events in PST / EST with out making changes (ignored).
  • Edited non-all-day events in PST / EST with changes (changes worked).
  • Performed the same edits with all-day events, which also were ignored and worked, respectively.
  • Pulled events in and out of all-day mode in different timezones, behavior seemeed reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Ignore Calendar date edits which just change the internal date timezone without rescheduling it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 6:29 PM
This revision was automatically updated to reflect the committed changes.