Page MenuHomePhabricator

Fix an issue where internal Calendar DateTimes would not be correctly set to all-day
ClosedPublic

Authored by epriestley on Nov 28 2016, 4:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 3:08 PM
Unknown Object (File)
Tue, Mar 5, 9:27 AM
Unknown Object (File)
Feb 3 2024, 1:14 PM
Unknown Object (File)
Jan 23 2024, 10:31 AM
Unknown Object (File)
Jan 20 2024, 8:49 PM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Unknown Object (File)
Jan 12 2024, 11:12 AM
Subscribers
None

Details

Summary

Ref T11816. I don't really know what happened here, maybe I rewrote and broke this at the last second?

In most cases, we directly respect the isAllDay flag on the event, so the internal date state doesn't matter too much.

However, in the case of mail notifications, the raw internal state is relevant. This should fix mail notifications for all-day events.

(I might still turn them off since I'm not sure they're too useful, but it's good to have them working.)

Test Plan
  • Created a new all-day event, verified database values wrote correctly.
  • Ran bin/calendar notify --trace, verified it picked up an all-day event tomorrow with a large enough --minutes value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue where internal Calendar DateTimes would not be correctly set to all-day.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 4:53 PM
This revision was automatically updated to reflect the committed changes.