Page MenuHomePhabricator
Feed Advanced Search

Jul 11 2019

epriestley added a revision to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way: D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 9:40 PM · Javelin
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Jul 11 2019, 7:53 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

Could this be related to the custom footer markup? The code in question hasn't changed in a long time but I suspect maybe it's related to changes in the remarkup rendering code that's adding metadata where it didn't previously?

Jul 11 2019, 7:00 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

I toggled developer mode on for a moment and managed to get a stack trace:

Jul 11 2019, 6:56 PM · Javelin

Jul 8 2019

epriestley updated subscribers of T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

@20after4, any chance there's a stack trace for this in the webserver error logs? I can't immediately figure out how to reproduce this locally.

Jul 8 2019, 3:57 PM · Javelin

Jul 6 2019

aklapper created T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 6 2019, 9:37 AM · Javelin

Jul 9 2017

chad removed the image for Celerity.
Jul 9 2017, 7:28 PM

Apr 9 2017

epriestley moved T11217: Make Tokens modular / real application from Intermediate to Backlog on the Contributor Onboarding board.
Apr 9 2017, 11:27 AM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Apr 7 2017

epriestley placed T11217: Make Tokens modular / real application up for grabs.
Apr 7 2017, 1:03 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Feb 23 2017

epriestley added a comment to T12311: Allow users to choose both "Larger Fonts" and "High Contrast" at the same time.

Possibly this should really be three dimensions (Size, Contrast, Color Correction).

Feb 23 2017, 7:11 PM · Celerity, Accessibility
epriestley added a project to T12311: Allow users to choose both "Larger Fonts" and "High Contrast" at the same time: Celerity.
Feb 23 2017, 7:03 PM · Celerity, Accessibility

Dec 13 2016

chad renamed T11217: Make Tokens modular / real application from Make tokens modular or data-driven to Make Tokens modular / real application.
Dec 13 2016, 12:11 AM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Dec 12 2016

lewellyn added a comment to T11217: Make Tokens modular / real application.

T12000 isn't really a duplicate. It's more of an enhancement for today's tokens. Of course, it'd be useful for this eventually, too, but that's tangential.

Dec 12 2016, 11:37 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad merged T12000: Tokens should be more usable into T11217: Make Tokens modular / real application.
Dec 12 2016, 11:36 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Sep 28 2016

jcox added a revision to T11217: Make Tokens modular / real application: D16621: Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 2:41 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Sep 27 2016

chad added a comment to T11217: Make Tokens modular / real application.

I did order an iPhone 7 plus, so I'll have a better understanding if 2x is actually noticeably bad.

Sep 27 2016, 4:24 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

This isn't like something I'm looking for immediately, btw. Just like, next time I have to make 50 images.

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I'm also not sure if we can use SVG as a data: URL in CSS. It probably should work, but if it doesn't we'll have to rasterize (and, I guess, serve 5+ different sizes to every user).

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

Alright -- we can have bin/celerity map rasterize SVG into arbitrary sizes if I'm not comfortable serving SVG directly from Celerity.

Sep 27 2016, 4:17 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

I'd like to generate 1 image and have them work 1x, 2x, 3x, etc or any size I need. I can't think of any other long term solution.

Sep 27 2016, 4:16 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

(That will give us slightly bad scale-downs on 1X screens, but I bet they're not worse than scaling down an SVG would be.)

Sep 27 2016, 4:05 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I think we can just do 2x in all cases for these, if that's reasonable?

Sep 27 2016, 4:04 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

fwiw, I want to convert all bitmaps to SVG if possible, so we can skip building 1x and 2x images.

Sep 27 2016, 4:01 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

Don't know if D16178 is worth comandeering? But feel free.

Sep 27 2016, 4:00 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley assigned T11217: Make Tokens modular / real application to jcox.

This one is a little scattered, so let me know where I can fill in any gaps. Most of the details are in D16178.

Sep 27 2016, 3:59 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T11217: Make Tokens modular / real application from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:47 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Sep 15 2016

eadler added a project to T11217: Make Tokens modular / real application: Restricted Project.
Sep 15 2016, 6:08 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Aug 25 2016

scheat added a watcher for Celerity: scheat.
Aug 25 2016, 2:38 PM

Aug 23 2016

chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

arc cast

Aug 23 2016, 7:04 PM · Celerity
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

Sounds like we should write a "Screencastph" app!

Aug 23 2016, 7:01 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

is there a twitch module for bash? can I live stream this excitement?

Aug 23 2016, 7:00 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

how.will.it.end

Aug 23 2016, 6:59 PM · Celerity
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

rough life :(

Aug 23 2016, 6:56 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

do-dist-upgrade is pushing me to 16.04

Aug 23 2016, 6:54 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

welp

Aug 23 2016, 6:53 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

I'm on 14.04 and it has 0.6.4 installed. :(

Aug 23 2016, 6:47 PM · Celerity
chad changed the visibility for T3311: Detect or manage optipng versions (-clobber flag).
Aug 23 2016, 6:46 PM · Celerity
epriestley closed T3311: Detect or manage optipng versions (-clobber flag) as Wontfix.

This hasn't come up again in three years so I'm just going to assume that everyone is realistically installing 0.7.0 or newer nowadays. Today, optiping strongly recommends upgrading to 0.7.6 or newer to fix some security issues.

Aug 23 2016, 6:42 PM · Celerity

Aug 22 2016

epriestley added a project to T11217: Make Tokens modular / real application: Contributor Onboarding.
Aug 22 2016, 5:38 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Aug 7 2016

eadler closed T11244: Identify additional tokens to add to Phabricator as Resolved.
Aug 7 2016, 7:56 PM · Celerity, Tokens
eadler closed T11244: Identify additional tokens to add to Phabricator, a subtask of T11217: Make Tokens modular / real application, as Resolved.
Aug 7 2016, 7:56 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Aug 7 2016, 7:31 PM · Celerity, Tokens

Jul 12 2016

cspeckmim added a comment to T11244: Identify additional tokens to add to Phabricator.

Something representing a prison, quarantine, or really good fence? I'm also a fan of the spooky ghost.

Jul 12 2016, 12:57 AM · Celerity, Tokens

Jul 11 2016

chad added a comment to T11244: Identify additional tokens to add to Phabricator.

shruggy_ghost

Jul 11 2016, 4:31 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

haha i was just thinking the same thing with the spooky haunted file task.

Jul 11 2016, 4:31 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

Some kind of ghost would be good too, but not too snapchat-ey.

Jul 11 2016, 4:30 PM · Celerity, Tokens

Jul 4 2016

chad added a revision to T11244: Identify additional tokens to add to Phabricator: D16228: More tokens.
Jul 4 2016, 1:22 AM · Celerity, Tokens

Jul 3 2016

chad added a comment to T11244: Identify additional tokens to add to Phabricator.

next batch is ready, should land tonight:

Jul 3 2016, 9:03 PM · Celerity, Tokens

Jul 1 2016

yelirekim added a comment to T11244: Identify additional tokens to add to Phabricator.

1f417.png (128×136 px, 2 KB)

Jul 1 2016, 5:01 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

Nope, it's a hardcoded app right now, see T11217

Jul 1 2016, 4:57 PM · Celerity, Tokens
yelirekim added a comment to T11244: Identify additional tokens to add to Phabricator.

Is this not a modularizable thing?

Jul 1 2016, 4:56 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

First 16 are done and out for review. Next 8 are sent off to the designer, should have them next week. Can explore another set of 8 if needed after that.

Jul 1 2016, 4:28 AM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jul 1 2016, 4:27 AM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jul 1 2016, 4:24 AM · Celerity, Tokens
chad added a revision to T11244: Identify additional tokens to add to Phabricator: D16211: New Tokens.
Jul 1 2016, 4:11 AM · Celerity, Tokens
eadler added a comment to T11244: Identify additional tokens to add to Phabricator.

We need a platypus. It is objectively the best animal.

Jul 1 2016, 2:49 AM · Celerity, Tokens

Jun 30 2016

bjshively added a comment to T11244: Identify additional tokens to add to Phabricator.

Humbly suggesting any/all of the following: gun, bomb, skull and cross bones. I find that I type :skull: :gun: on slack a lot (a common side effect of support ops work.)

Jun 30 2016, 9:57 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

These will be images in Phabricator, not emoji.

Jun 30 2016, 9:19 PM · Celerity, Tokens
avivey added a comment to T11244: Identify additional tokens to add to Phabricator.
In T11244#183049, @chad wrote:
Jun 30 2016, 9:19 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

http://emojipedia.org/upside-down-face/

Jun 30 2016, 9:16 PM · Celerity, Tokens
avivey added a comment to T11244: Identify additional tokens to add to Phabricator.

Is the last one supposed to be a cube? Windows is 🐗 ing

pasted_file (164×66 px, 2 KB)

Jun 30 2016, 9:16 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

need some food / drinks

Jun 30 2016, 9:15 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

added dat boi

Jun 30 2016, 9:15 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

ohh, its boaring

Jun 30 2016, 9:14 PM · Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Jun 30 2016, 9:14 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I think only frogs are allowed to be memes.

Jun 30 2016, 9:11 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I wish :(

Jun 30 2016, 9:11 PM · Celerity, Tokens
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

is that from a dank meme i'm not aware of?

Jun 30 2016, 9:08 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.
  • 🐗 For when something is boring.
Jun 30 2016, 9:06 PM · Celerity, Tokens
chad created T11244: Identify additional tokens to add to Phabricator.
Jun 30 2016, 9:04 PM · Celerity, Tokens

Jun 27 2016

epriestley added a comment to T11217: Make Tokens modular / real application.

Probably go with data driven. I don't think these need to be sprited, but should probably inline CSS (base64) with celerity? I don't think these will be large enough to need to be in an image sheet.

Jun 27 2016, 3:38 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Jun 25 2016

chad added a revision to T11217: Make Tokens modular / real application: D16178: First Cut Tokens Application.
Jun 25 2016, 8:54 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad merged T6520: Allow for custom tokens to be created into T11217: Make Tokens modular / real application.
Jun 25 2016, 7:13 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad moved T11217: Make Tokens modular / real application from Backlog to v1 on the Tokens board.
Jun 25 2016, 7:11 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

So I think I can lay the groundwork here. My plan is to:

Jun 25 2016, 6:58 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

Probably go with data driven. I don't think these need to be sprited, but should probably inline CSS (base64) with celerity? I don't think these will be large enough to need to be in an image sheet.

Jun 25 2016, 5:43 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley created T11217: Make Tokens modular / real application.
Jun 25 2016, 2:13 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Jun 2 2016

epriestley closed T10902: Support third-party package definitions in Celerity, or remember how it works if I already built it as Resolved.

Fix for this is on meta, but the short version is that it works fine as-is.

Jun 2 2016, 2:00 AM · Phacility, Celerity

May 3 2016

hach-que added a comment to T10902: Support third-party package definitions in Celerity, or remember how it works if I already built it.

I don't believe it was implemented; the third party Celerity stuff only supports individual files as far as I remember.

May 3 2016, 1:47 AM · Phacility, Celerity

Apr 29 2016

epriestley created T10902: Support third-party package definitions in Celerity, or remember how it works if I already built it.
Apr 29 2016, 5:20 PM · Phacility, Celerity

Nov 13 2015

jamieisboss added a comment to T7683: Have CelerityResourceTransformer add .device-desktop automatically?.

Complete outlier device but; tablets with active styli (pretty much just the galaxy note range I think) use hover and it works really well.

Nov 13 2015, 8:02 AM · PHUI, Celerity

Oct 7 2015

chad added a comment to T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents.

I'm not able to reproduce this at HEAD. Are you sure your install is up to date? We expected D14063 to resolve this. If this still reproduces at HEAD, can you give us a better idea of OS/Browser for testing?

Oct 7 2015, 1:59 PM · PHUI
Pawka added projects to T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents: Phriction, Paste, Celerity.
Oct 7 2015, 7:37 AM · PHUI

Jun 1 2015

epriestley closed T8372: Resource cache as Resolved by committing rP7a9174fa21b7: Digest resource cachekeys to maximum length.
Jun 1 2015, 4:04 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Awesome, thanks for testing! We'll get this upstreamed shortly.

Jun 1 2015, 3:48 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.

Oh no, its not a silly question :D Sorry, i justy quickly look this patch and totally forget restarting web-server... It works lik a charm ;) Thanks.

Jun 1 2015, 3:46 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Probably a silly question, but did you restart Apache or php-fpm after applying the patch?

Jun 1 2015, 3:38 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.

Applyed this diff to my local install but does not seems to be helped. The trace, and the throwed exception is the same as before.

Jun 1 2015, 1:39 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Pretty sure D13095 will fix this.

Jun 1 2015, 1:27 PM · Aphront, Celerity
epriestley added a revision to T8372: Resource cache: D13095: Digest resource cachekeys to maximum length.
Jun 1 2015, 1:27 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.
[2015-06-01 08:43:09] EXCEPTION: (AphrontQueryException) #1406: Data too long for column 'cacheKey' at row 1 at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:311]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message: arcanist(head=master, ref.master=0b1acf0dc02a), phabricator(head=master, ref.master=c4bcfc85f160), phutil(head=master, ref.master=ee6d0c3fe26e)
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #0 phlog(AphrontQueryException) called at [<phabricator>/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php:226]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #1 AphrontDefaultApplicationConfiguration::handleException(AphrontQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:230]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #2 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:140]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #3 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]
Jun 1 2015, 1:26 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Do you have a full stack trace in your error log? Usually /var/log/apache2/error_log or something like that, depending on exactly which webserver/OS you're running.

Jun 1 2015, 1:16 PM · Aphront, Celerity
Zolli created T8372: Resource cache.
Jun 1 2015, 6:21 AM · Aphront, Celerity

May 4 2015

epriestley closed T8058: Unit tests failing at HEAD as Resolved by committing rP1168a8c0a014: Don't add resources to Multimeter when there's no multimeter running.
May 4 2015, 4:15 PM · Celerity
epriestley added a revision to T8058: Unit tests failing at HEAD: D12699: Don't add resources to Multimeter when there's no multimeter running.
May 4 2015, 3:07 PM · Celerity
joshuaspence created T8058: Unit tests failing at HEAD.
May 4 2015, 3:03 PM · Celerity

Mar 28 2015

chad created T7683: Have CelerityResourceTransformer add .device-desktop automatically?.
Mar 28 2015, 5:55 PM · PHUI, Celerity

Nov 4 2014

epriestley closed T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library. as Resolved.

(I think D10780 fixed this.)

Nov 4 2014, 2:48 PM · Celerity, Javelin, Wikimedia
ChristopherHJohnson added a revision to T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library.: D10780: Allow Javelin initBehavior to source alternative library behaviors.
Nov 4 2014, 12:38 PM · Celerity, Javelin, Wikimedia
ChristopherHJohnson created T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library..
Nov 4 2014, 12:07 PM · Celerity, Javelin, Wikimedia