- Group Reviewers
- Maniphest Tasks
- T11217: Make Tokens modular / real application
- rP32d660c08f46: Added a `token_token` table in anticipation of some data-driven tokens
I ran ./bin/storage upgrade successfully and there were no schema errors.
Couple of possible things inline, but this looks pretty good to me.
This should maybe be nullable since I think builtin tokens probably won't use an actual File for their data (we can just read it directly off disk) but we can fix that easily later and I'm not 100% sure it will actually be how things turn out.
(Column doesn't exist?)
Let's just omit this for now -- we don't have a mailKey, and I think interacting with tokens via email seems a little silly / not worth building, at least for now. I could be wrong and maybe emailing firstname.lastname@example.org will be all the rage in a few months, but doesn't feel like the highest-value interaction here.
I think this isn't right -- it's loading copies of itself by a nonexistent column. Probably intended to delete PhabricatorTokenGiven instead (replace new self() with new PhabricatorTokenGiven())?
I think we could reasonably delete the File by filePHID, if filePHID is set too.
This is ultimately a product question but maybe creating a token shouldn't permanently auto-subscribe you to it. We don't really have a hard-and-fast rule for this but I think the soft rule is "if you own the object", and a creator's ownership claim on a token feels a little tenuous (e.g., compared to a Differential Revision, which is clearly strongly-owned).
We recently backed off on auto-subscribe on Phame blogs, and this ownership feels similarly soft to me.
We can easily tweak this later, though.