Page MenuHomePhabricator

ChristopherHJohnson (Christopher Johnson)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 27 2014, 10:51 AM (391 w, 1 d)
Availability
Available

Recent Activity

Aug 6 2015

ChristopherHJohnson added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

Thank you for the response.

Aug 6 2015, 9:15 AM · Aphront

Aug 5 2015

ChristopherHJohnson added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

I am not asking for "support" per se, so I am not sure the referenced link is applicable for this task. The use case of application/json requests is major, so rejecting it outright as some kind of non-essential fringe "custom code" seems rather strong. The problem is pretty simple and the fix even more so. I am asking you to consider the benefits of parsing a specific content-type request with an appropriate parser. I totally understand that you have priorities, etc., but this is the situation with my team. We have code on GitHub and associated build tools that will probably never move to Phabricator. How can I not consider the need to integrate these "third-party" tools seriously? I am open to suggestions. Worst case scenario is that we maintain a patched version of this class, which for such a trivial change seems ridiculous.

Aug 5 2015, 3:08 PM · Aphront

Aug 4 2015

ChristopherHJohnson created T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.
Aug 4 2015, 4:51 PM · Aphront

Jun 25 2015

ChristopherHJohnson added a comment to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .

How would separating these transaction types help?

Jun 25 2015, 1:41 PM · Projects, Maniphest, Wikimedia, Transactions
ChristopherHJohnson added a comment to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .

Can you give me a specific example of a query that you believe Facts will be unable to satisfy, or will satisfy less elegantly than parsing a flat logfile on disk?

Jun 25 2015, 1:30 PM · Projects, Maniphest, Wikimedia, Transactions
ChristopherHJohnson added a comment to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .

Can you walk me through how the data is useless? The data is not in a queryable form, but it is complete: it fully captures the state change -- and we use that fact to render strings like "added project x" and "removed project y". To find adds and removes, you perform set differences on the "old value" and "new value". PHIDs only present in one of the two values were added or removed.

Jun 25 2015, 12:52 PM · Projects, Maniphest, Wikimedia, Transactions
ChristopherHJohnson added a comment to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .

I think that promoting Facts to address this problem is a red herring. I agree that Facts offers many advantages for offline processing of transactions. But I do not understand the reasoning for having such arcane and basically useless metadata for maniphest transactions. If you are trying to discourage the direct usage of transaction queries for performance reasons, this is also sensible. However, we need more descriptive data about task history that can only be provided with transaction metadata. Why not fix the problem where it exists? If you are reluctant to add more logic into TaskEditController, I understand that as well. This is a class that is desperate for refactoring.

Jun 25 2015, 12:02 PM · Projects, Maniphest, Wikimedia, Transactions
ChristopherHJohnson added projects to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) : Maniphest, Projects.
Jun 25 2015, 11:19 AM · Projects, Maniphest, Wikimedia, Transactions
ChristopherHJohnson created T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .
Jun 25 2015, 11:18 AM · Projects, Maniphest, Wikimedia, Transactions

Dec 25 2014

ChristopherHJohnson added a comment to T5245: Migrate Maniphest Projects to use edge infrastructure.

Please check https://secure.phabricator.com/maniphest/report/project/

Dec 25 2014, 2:44 PM · Support Impact, Maniphest

Dec 24 2014

ChristopherHJohnson moved T6808: arc commit problem! thanks! from Backlog to In Progress on the Arcanist board.
Dec 24 2014, 12:04 PM · Arcanist

Dec 17 2014

ChristopherHJohnson added a comment to T6771: Create index for transactionType in phabricator_maniphest.maniphest_transaction.

Actually, yes. ManiphestReportController lines 95-97.

Dec 17 2014, 9:27 AM · Maniphest, Wikimedia
ChristopherHJohnson created T6771: Create index for transactionType in phabricator_maniphest.maniphest_transaction.
Dec 17 2014, 6:20 AM · Maniphest, Wikimedia

Nov 4 2014

ChristopherHJohnson updated the diff for D10780: Allow Javelin initBehavior to source alternative library behaviors.

corrects indentation to two spaces lines 6-8

Nov 4 2014, 2:09 PM
ChristopherHJohnson updated the diff for D10780: Allow Javelin initBehavior to source alternative library behaviors.

establishs a default scalar parameter value for source_name

Nov 4 2014, 2:06 PM
ChristopherHJohnson added a task to D10780: Allow Javelin initBehavior to source alternative library behaviors: T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library..
Nov 4 2014, 12:38 PM
ChristopherHJohnson added a revision to T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library.: D10780: Allow Javelin initBehavior to source alternative library behaviors.
Nov 4 2014, 12:38 PM · Celerity, Javelin, Wikimedia
ChristopherHJohnson retitled D10780: Allow Javelin initBehavior to source alternative library behaviors from to Allow Javelin initBehavior to source alternative library behaviors.
Nov 4 2014, 12:35 PM
ChristopherHJohnson created T6467: Javelin initBehavior is set to only source behaviors from the 'phabricator' library..
Nov 4 2014, 12:07 PM · Celerity, Javelin, Wikimedia

Oct 30 2014

ChristopherHJohnson added a comment to T6422: Mapping resources outside of webroot.

I got this to work as you suggested.

Oct 30 2014, 1:24 PM · Celerity, Wikimedia

Oct 29 2014

ChristopherHJohnson created T6422: Mapping resources outside of webroot.
Oct 29 2014, 5:14 PM · Celerity, Wikimedia