Page MenuHomePhabricator

More tokens
ClosedPublic

Authored by chad on Jul 4 2016, 1:22 AM.
Tags
None
Referenced Files
F11025920: D16228.id39035.diff
Fri, Aug 12, 2:42 PM
F11025616: D16228.id39036.diff
Fri, Aug 12, 1:16 PM
Unknown Object (File)
Tue, Aug 9, 7:47 PM
Unknown Object (File)
Tue, Aug 9, 7:14 PM
Unknown Object (File)
Tue, Aug 9, 7:12 PM
Unknown Object (File)
Tue, Aug 9, 12:18 AM
Unknown Object (File)
Sun, Aug 7, 7:44 PM
Unknown Object (File)
Sun, Aug 7, 7:44 PM
Subscribers
Tokens
"Dat Boi" token, awarded by chad."Dat Boi" token, awarded by epriestley.

Details

Summary

Ref T11244. 8 more tokens. Probably need better math on the selector?

Test Plan

Award Dat Boi.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to More tokens.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

You can change the % 4 to % 6 near line 93 of TokenGiveController to produce this if you like it better:

Screen Shot 2016-07-03 at 6.26.55 PM.png (400×614 px, 36 KB)

That knocks the similar tokens (e.g., coin1-4, medal1-4) out of alignment, though.

Or you can use % 5 or whatever but then it won't be a perfect rectangle. :( :(

This revision is now accepted and ready to land.Jul 4 2016, 1:28 AM

Or % 8 to sort of retain alignment, not sure if this fits on mobile:

Screen Shot 2016-07-03 at 6.28.45 PM.png (309×609 px, 33 KB)

been thinking of having them make a @putnam token.

This revision was automatically updated to reflect the committed changes.