Paths

Table of Contentst

Differential D16228

More tokens
ClosedPublic
Actions

Authored by chad on Jul 4 2016, 1:22 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T11244: Identify additional tokens to add to Phabricator

Commits

rPd09094f4fbb2: More tokens

Summary

Ref T11244. 8 more tokens. Probably need better math on the selector?

Test Plan

Award Dat Boi.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39035.Jul 4 2016, 1:22 AM

chad retitled this revision from to More tokens.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11244: Identify additional tokens to add to Phabricator.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 4 2016, 1:22 AM

You can change the % 4 to % 6 near line 93 of TokenGiveController to produce this if you like it better:

Screen Shot 2016-07-03 at 6.26.55 PM.png (400×614 px, 36 KB)

That knocks the similar tokens (e.g., coin1-4, medal1-4) out of alignment, though.

Or you can use % 5 or whatever but then it won't be a perfect rectangle. :( :(

This revision is now accepted and ready to land.Jul 4 2016, 1:28 AM

Or % 8 to sort of retain alignment, not sure if this fits on mobile:

Screen Shot 2016-07-03 at 6.28.45 PM.png (309×609 px, 33 KB)

been thinking of having them make a @putnam token.

Closed by commit rPd09094f4fbb2: More tokens (authored by chad, committed by chad). · Explain WhyJul 4 2016, 1:32 AM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Jul 4 2016, 1:37 AM

chad awarded a token.Jul 4 2016, 1:37 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

sprite/

manifest/

tokens.json

40 lines

tokens_1x/

tokens_2x/

src/

applications/

tokens/

controller/

PhabricatorTokenGiveController.php

2 lines

query/

PhabricatorTokenQuery.php

8 lines

webroot/

rsrc/

css/

sprite-tokens.css

58 lines

image/

sprite-tokens-X2.png

sprite-tokens.png

Diff 39036

View Options

resources/celerity/map.php

View Options

resources/sprite/manifest/tokens.json

View Options

resources/sprite/tokens_1x/emoji-1.png

View Options

resources/sprite/tokens_1x/emoji-2.png

View Options

resources/sprite/tokens_1x/emoji-3.png

View Options

resources/sprite/tokens_1x/emoji-4.png

View Options

resources/sprite/tokens_1x/emoji-5.png

View Options

resources/sprite/tokens_1x/emoji-6.png

View Options

resources/sprite/tokens_1x/emoji-7.png

View Options

resources/sprite/tokens_1x/emoji-8.png

View Options

resources/sprite/tokens_2x/emoji-1.png

View Options

resources/sprite/tokens_2x/emoji-2.png

View Options

resources/sprite/tokens_2x/emoji-3.png

View Options

resources/sprite/tokens_2x/emoji-4.png

View Options

resources/sprite/tokens_2x/emoji-5.png

View Options

resources/sprite/tokens_2x/emoji-6.png

View Options

resources/sprite/tokens_2x/emoji-7.png

View Options

resources/sprite/tokens_2x/emoji-8.png

View Options

src/applications/tokens/controller/PhabricatorTokenGiveController.php

View Options

src/applications/tokens/query/PhabricatorTokenQuery.php

View Options

webroot/rsrc/css/sprite-tokens.css

View Options

webroot/rsrc/image/sprite-tokens-X2.png

View Options

webroot/rsrc/image/sprite-tokens.png

More tokensClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39036

resources/celerity/map.php

resources/sprite/manifest/tokens.json

resources/sprite/tokens_1x/emoji-1.png

resources/sprite/tokens_1x/emoji-2.png

resources/sprite/tokens_1x/emoji-3.png

resources/sprite/tokens_1x/emoji-4.png

resources/sprite/tokens_1x/emoji-5.png

resources/sprite/tokens_1x/emoji-6.png

resources/sprite/tokens_1x/emoji-7.png

resources/sprite/tokens_1x/emoji-8.png

resources/sprite/tokens_2x/emoji-1.png

resources/sprite/tokens_2x/emoji-2.png

resources/sprite/tokens_2x/emoji-3.png

resources/sprite/tokens_2x/emoji-4.png

resources/sprite/tokens_2x/emoji-5.png

resources/sprite/tokens_2x/emoji-6.png

resources/sprite/tokens_2x/emoji-7.png

resources/sprite/tokens_2x/emoji-8.png

src/applications/tokens/controller/PhabricatorTokenGiveController.php

src/applications/tokens/query/PhabricatorTokenQuery.php

webroot/rsrc/css/sprite-tokens.css

webroot/rsrc/image/sprite-tokens-X2.png

webroot/rsrc/image/sprite-tokens.png

More tokens
ClosedPublic
Actions

Revision Contents
Changeset List