Digest resource cachekeys to maximum length
ClosedPublic
Actions

Authored by epriestley on Jun 1 2015, 1:27 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8372: Resource cache

Commits

Restricted Diffusion Commit
rP7a9174fa21b7: Digest resource cachekeys to maximum length

Summary

Fixes T8372. We currently store the entire resource path in the cachekey; shorten it to a maximum of 64 characters.

The key size is 128 and T8372 had an example of a 112-byte key which could run over 128 with a slightly-long cache namespace.

Test Plan

Not 100% sure this is the issue, but it seems likely.
Dumped the cachekey before and after the change.
Saw values like celerity:/res/1432859262T/phabricator/e2460e8f/core.pkg.css-6eGjUCJORU3j now.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31615.Jun 1 2015, 1:27 PM

epriestley retitled this revision from to Digest resource cachekeys to maximum length.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8372: Resource cache.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 1 2015, 1:27 PM

epriestley mentioned this in T8372: Resource cache.Jun 1 2015, 1:27 PM

chad accepted this revision.Jun 1 2015, 3:58 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Jun 1 2015, 3:58 PM

Closed by commit rP7a9174fa21b7: Digest resource cachekeys to maximum length (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2015, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

celerity/

controller/

CelerityResourceController.php

2 lines

Diff 31621

View Options

src/applications/celerity/controller/CelerityResourceController.php

Digest resource cachekeys to maximum lengthClosedPublicActions