Page MenuHomePhabricator
Feed All Stories

Sep 14 2018

epriestley added a parent task for T5055: Distribution mechanism for arc extensions: T13098: Plans: Arcanist toolsets and extensions.
Sep 14 2018, 6:09 PM · Arcanist
epriestley added subtasks for T13098: Plans: Arcanist toolsets and extensions: T5055: Distribution mechanism for arc extensions, T10038: Plan the mid-term pathway for unit-test/linter bindings.
Sep 14 2018, 6:09 PM · Arcanist, Plans
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T11911: Arcanist Experimental Branch.
Sep 14 2018, 6:08 PM · Arcanist, Plans
epriestley added a parent task for T11911: Arcanist Experimental Branch: T13098: Plans: Arcanist toolsets and extensions.
Sep 14 2018, 6:08 PM · Restricted Project, Arcanist
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Sep 14 2018, 5:58 PM · Plans
epriestley triaged T13202: Plans: 2018 Week 38-40 Bonus Content as Normal priority.
Sep 14 2018, 5:01 PM · Plans
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 14 2018, 5:01 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 14 2018, 4:25 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 14 2018, 4:12 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 14 2018, 4:01 PM · Plans, Harbormaster
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Sep 14 2018, 3:59 PM · Differential, Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 14 2018, 1:50 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 14 2018, 1:39 PM · Plans
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Sep 14 2018, 1:27 PM · Mail
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Restricted Differential Revision.
Sep 14 2018, 1:27 PM · Plans

Sep 13 2018

epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 13 2018, 4:12 PM · Plans
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 13 2018, 3:33 PM · Plans, Phriction
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 13 2018, 3:33 PM · Plans
epriestley removed a parent task for T5031: Draft Comment Persists After Submission: T5811: Phriction does not correctly save and restore document drafts of in-progress edits.
Sep 13 2018, 3:28 PM · Restricted Project, Support Impact, Mobile
epriestley removed a subtask for T5811: Phriction does not correctly save and restore document drafts of in-progress edits: T5031: Draft Comment Persists After Submission.
Sep 13 2018, 3:28 PM · Phriction
epriestley added a parent task for T4768: Phabricator silently overwrites concurrent changes (no conflict detection): T13201: Develop a more comprehensive approach for previews/drafts on edit screens.
Sep 13 2018, 3:28 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added subtasks for T13201: Develop a more comprehensive approach for previews/drafts on edit screens: T10859: Wiki page title is not updated in preview, T5811: Phriction does not correctly save and restore document drafts of in-progress edits, T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Sep 13 2018, 3:28 PM · EditEngine
epriestley added a parent task for T10859: Wiki page title is not updated in preview: T13201: Develop a more comprehensive approach for previews/drafts on edit screens.
Sep 13 2018, 3:28 PM · Feature Request, Phriction
epriestley added a parent task for T5811: Phriction does not correctly save and restore document drafts of in-progress edits: T13201: Develop a more comprehensive approach for previews/drafts on edit screens.
Sep 13 2018, 3:28 PM · Phriction
epriestley added a project to T13201: Develop a more comprehensive approach for previews/drafts on edit screens: EditEngine.
Sep 13 2018, 3:22 PM · EditEngine
epriestley closed T665: Don't lose data when submitting forms if the machine is offline as Wontfix.

I think we have no realistic way forward here. See T13201 for related things which are moving forward.

Sep 13 2018, 3:22 PM
epriestley triaged T13201: Develop a more comprehensive approach for previews/drafts on edit screens as Low priority.
Sep 13 2018, 3:21 PM · EditEngine
epriestley moved T4768: Phabricator silently overwrites concurrent changes (no conflict detection) from Far Future to Future on the Phriction board.
Sep 13 2018, 3:17 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley moved T5811: Phriction does not correctly save and restore document drafts of in-progress edits from Next to Future on the Phriction board.
Sep 13 2018, 3:17 PM · Phriction
epriestley moved T10859: Wiki page title is not updated in preview from Next to Future on the Phriction board.
Sep 13 2018, 3:17 PM · Feature Request, Phriction
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 13 2018, 2:44 PM · Plans, Harbormaster
epriestley added a comment to T9041: Control access to administrator capabilities with custom policies.

I don't currently plan to make "Disable User" any more granular than it is. If you have a use case where you want multiple administrator levels and to allow administrators at a certain level to act downward but not upward, you might be able to do something like have an enforcer-bot account which users can instruct to disable one another. The enforcer-bot itself could act via the API.

Sep 13 2018, 2:42 PM · FreeBSD, Policy, People
aklapper added a comment to T9041: Control access to administrator capabilities with custom policies.

"Disable User", specifically, is now granular.

Sep 13 2018, 9:41 AM · FreeBSD, Policy, People

Sep 12 2018

epriestley closed T1894: Support commenting on Phriction documents as Resolved by committing Restricted Diffusion Commit.
Sep 12 2018, 8:21 PM · Restricted Project, Restricted Project, Phriction
epriestley closed T1894: Support commenting on Phriction documents, a subtask of T9379: Build Phriction v3, as Resolved.
Sep 12 2018, 8:21 PM · Phriction
epriestley triaged T13200: "Responsible Users" queries with "Author" or "Reviewer" or "Auditor" constraints can include too many results as Low priority.
Sep 12 2018, 8:18 PM · Diffusion, Differential

Sep 11 2018

yelirekim added a comment to T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc".

Use cases we've seen FWIW:

Sep 11 2018, 11:19 PM · Arcanist, Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 8:53 PM · Plans
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Restricted Differential Revision.
Sep 11 2018, 8:39 PM · Plans, Phriction
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 11 2018, 8:29 PM · Plans
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 5:28 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 5:07 PM · Plans, Phriction
epriestley added a comment to T5811: Phriction does not correctly save and restore document drafts of in-progress edits.
  • This feature was originally added in D1378.
  • This feature was accidentally broken by D11169.
  • In D19661, I removed the nonfunctional remnants of D1378.
Sep 11 2018, 4:44 PM · Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 4:39 PM · Plans, Phriction
epriestley added a revision to T5811: Phriction does not correctly save and restore document drafts of in-progress edits: Unknown Object (Differential Revision).
Sep 11 2018, 4:39 PM · Phriction
epriestley added a revision to T1894: Support commenting on Phriction documents: Unknown Object (Differential Revision).
Sep 11 2018, 3:40 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 3:40 PM · Plans, Phriction
kerberizer awarded T1894: Support commenting on Phriction documents a Like token.
Sep 11 2018, 3:19 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T1894: Support commenting on Phriction documents: Unknown Object (Differential Revision).
Sep 11 2018, 3:15 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 3:15 PM · Plans, Phriction
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 11 2018, 3:06 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:52 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:22 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:14 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:05 PM · Plans
pouyana added a comment to T8656: Parse ANSI-style color strings in build output.

I wrote a patch for this, for both new log prototype and old log viewer here some screenshots for the view. If it is look OK, I will submit it.

Sep 11 2018, 9:32 AM · Haskell.org, Restricted Project, Harbormaster
epriestley closed T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes as Resolved.

This is now live.

Sep 11 2018, 12:52 AM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

Deploying the changes to web now.

Sep 11 2018, 12:48 AM · Ops, Phacility

Sep 10 2018

epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 10 2018, 9:43 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 9:34 PM · Plans
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

I've issued all instances a 24-hour service credit for the disruption. This should be reflected on your next invoice.

Sep 10 2018, 9:17 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

Here's the request rate leading up to the rate limiting:

Sep 10 2018, 9:11 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

D19653 (above) changes the per-"Host" rate limit to require "X-Forwarded-For" be present in the request. This should exempt ELB requests from these limits.

Sep 10 2018, 8:55 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.
...
[Mon Sep 10 20:48:43.928021 2018] [:error] [pid 21570] [client 172.30.0.171:16516] Array\n(\n    [f] => \n    [h] => 172.30.0.60\n)\n
...
Sep 10 2018, 8:51 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

... in production today as a next step.

Sep 10 2018, 8:46 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

This should have the pleasant side effect of letting us drop the goofy hard-coded internal rate limiting IP list.

Sep 10 2018, 8:44 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

There are four rate limits, and I don't currently have enough information to figure out which one triggered. The rate limits are:

Sep 10 2018, 8:41 PM · Ops, Phacility
epriestley triaged T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes as High priority.
Sep 10 2018, 8:25 PM · Ops, Phacility
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 7:50 PM · Plans
epriestley added a comment to T13197: 2018 Week 37 Bonus Content.

The remaining work on the audit constants is:

Sep 10 2018, 7:19 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 7:11 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 6:44 PM · Plans
epriestley added a comment to T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc".

See also PHI862 for a request for arc amend --force.

Sep 10 2018, 3:25 PM · Arcanist, Plans
epriestley triaged T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc" as Normal priority.
Sep 10 2018, 3:24 PM · Arcanist, Plans
• GoogleLegacy added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Sep 10 2018, 9:48 AM · Differential, Audit
• GoogleLegacy added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
Sep 10 2018, 9:47 AM · Restricted Project, User Delight, Maniphest
• GoogleLegacy added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Sep 10 2018, 9:46 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
• GoogleLegacy added a comment to T5811: Phriction does not correctly save and restore document drafts of in-progress edits.
Sep 10 2018, 9:45 AM · Phriction
• GoogleLegacy added a comment to T7303: Provide OAuth access to Conduit.
Sep 10 2018, 9:44 AM · Restricted Project, Conduit, Restricted Project
• GoogleLegacy added a comment to T9303: Improve Phacility Onboarding/NUX.
Sep 10 2018, 9:44 AM · Phacility
• GoogleLegacy added a comment to T4316: Allow a comment to be added on the Maniphest edit interface.
Sep 10 2018, 9:43 AM · Maniphest
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:40 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:39 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T7429: Update tour screenshots on dot org.
Sep 10 2018, 9:35 AM · Public & Media Relations
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:32 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to 5 Years .
Sep 10 2018, 9:31 AM
• GoogleLegacy added a comment to T9304: Workflow for inviting new users to a Phacility instance is unnecessarily confusing.
Sep 10 2018, 9:20 AM · Phacility
• GoogleLegacy added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.
Sep 10 2018, 9:19 AM · Phortune, Phacility
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:18 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T7303: Provide OAuth access to Conduit.
Sep 10 2018, 9:17 AM · Restricted Project, Conduit, Restricted Project
• GoogleLegacy added a comment to T10034: Plan the future of Maniphest task relationships.
Sep 10 2018, 9:10 AM · Maniphest
• GoogleLegacy added a comment to T10187: hard to understand status of sub-tasks from parent.
Sep 10 2018, 9:09 AM · Restricted Project, Maniphest
• GoogleLegacy added a comment to T7804: Implement an "Acting User" Herald condition.
Sep 10 2018, 9:06 AM · Restricted Project, Herald, Mail
• GoogleLegacy added a comment to T8726: Modularize Herald fields and actions.
Sep 10 2018, 9:06 AM · Herald
• GoogleLegacy added a comment to T9054: Undefined class constant ACTION_BLOCK.
Sep 10 2018, 9:05 AM · Herald
• GoogleLegacy added a comment to T13057: Formalize "reverts" and "resurrects" between revisions.
Sep 10 2018, 8:41 AM · Differential

Sep 8 2018

epriestley edited the content of Changelog.
Sep 8 2018, 11:53 AM
epriestley created 2018 Week 36 (Mid September).
Sep 8 2018, 11:52 AM
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 8 2018, 11:46 AM · Plans
epriestley closed T13195: 2018 Week 36 Bonus Content as Resolved.
Sep 8 2018, 1:05 AM · Plans