Page MenuHomePhabricator

"Responsible Users" queries with "Author" or "Reviewer" or "Auditor" constraints can include too many results
Open, LowPublic

Description

To reproduce:

  • In Differential or Diffusion, issue a query like "Responsible Users: epriestley, Authors or Auditors or Reviewers: alice".

Expected result:

  • Query matches only audits/revisions with specific authors or auditors or reviewers.

Actual result:

  • Query also matches audits/revisions where you or some project or package are a member of are an author/auditor/reviewer.

Diffusion example:

Screen Shot 2018-09-12 at 1.10.53 PM.png (997×686 px, 107 KB)

Differential example:

Screen Shot 2018-09-12 at 1.14.37 PM.png (951×1 px, 147 KB)

The way we build these queries ends up with WHERE clauses that are too permissive for these fields on one half of the UNION'd subquery.