Page MenuHomePhabricator
Feed All Stories

Sep 8 2018

epriestley triaged T13197: 2018 Week 37 Bonus Content as Normal priority.
Sep 8 2018, 1:05 AM · Plans

Sep 7 2018

epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 7:21 PM · Plans
epriestley closed T8573: All reviewers should be allowed to mark a comment as done, a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
Sep 7 2018, 6:18 PM · User Delight, Differential
epriestley closed T8573: All reviewers should be allowed to mark a comment as done as Resolved by committing Restricted Diffusion Commit.
Sep 7 2018, 6:18 PM · Restricted Project, Differential, Restricted Project
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 4:53 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 4:53 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Restricted Differential Revision.
Sep 7 2018, 4:53 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 4:05 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 3:37 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 3:07 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 7 2018, 3:05 PM · Plans, Harbormaster
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 3:04 PM · Plans

Sep 6 2018

epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

See PHI860 and T13111. In the future, repository nodes may automatically gc/prune/repack. If they do, it may make sense to sort them to the bottom of the list so traffic is sent to them only if no other nodes are available, in order to minimize the impact that gc/prune/repack have on other activity.

Sep 6 2018, 6:43 PM · Clusters
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

PHI860 is a close variant of this and discusses periodically running git repack. Most concerns around git repack are likely similar to concerns around gc and prune.

Sep 6 2018, 6:42 PM · Phacility, Diffusion
epriestley added a comment to T3130: Improve recognition of symbols in Java.

D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).

Sep 6 2018, 5:35 PM · Symbols, libphutil
avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 6 2018, 1:30 PM · Plans

Sep 5 2018

epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 8:49 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 5:32 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 5:11 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 4:34 PM · Plans
epriestley added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

Yes. The diff is a relatively small amount of the work I must do to respond to this issue: install ElasticSearch, configure it in the way you describe, reproduce the issue, write or apply a change, verify it actually fixes the problem, go read through the documentation enough that I'm confident the fix is the best available fix and that we've understood the issue reasonably well.

Sep 5 2018, 4:28 PM · Search, Elasticsearch
Pawka added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

Even if I'd provide the diff?

Sep 5 2018, 4:16 PM · Search, Elasticsearch
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 5 2018, 3:54 PM · Arcanist, Plans
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Sep 5 2018, 3:29 PM · Arcanist, Plans
epriestley renamed T13077: Plans: Phriction modern "v3" APIs, Drafts from Plans: Phriction modern "v3" APIs to Plans: Phriction modern "v3" APIs, Drafts.
Sep 5 2018, 2:35 PM · Plans, Phriction
epriestley added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

(Just to set expectations, anything which isn't coming in through Support Pacts may take a very long time for us to get to.)

Sep 5 2018, 2:27 PM · Search, Elasticsearch
epriestley moved T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction from Tentative to Soon on the Plans board.
Sep 5 2018, 1:34 PM · Plans, Ops, Infrastructure, Phacility
epriestley moved T13195: 2018 Week 36 Bonus Content from Backlog to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans
epriestley moved T13178: Plans: Support Pact Competitive Update from Backlog to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans, Support, Phacility
epriestley moved T13098: Plans: Arcanist toolsets and extensions from Tentative to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Arcanist, Plans
epriestley moved T13077: Plans: Phriction modern "v3" APIs, Drafts from Future to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans, Phriction
Pawka triaged T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine as Normal priority.
Sep 5 2018, 6:09 AM · Search, Elasticsearch

Sep 4 2018

epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 9:51 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 9:45 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 9:20 PM · Plans
epriestley added a revision to T3130: Improve recognition of symbols in Java: Unknown Object (Differential Revision).
Sep 4 2018, 9:01 PM · Symbols, libphutil
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 9:01 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 7:50 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 7:35 PM · Plans
epriestley updated the task description for T13083: Plans: Portals and Facts.
Sep 4 2018, 7:34 PM · Plans, Facts, Dashboards
epriestley added a comment to T8573: All reviewers should be allowed to mark a comment as done.
  • D19634 allows reviewers to mark their own inlines as "Done" before they submit them. This addresses the case where you want to leave a non-actionable inline (like "This is much-improved.") but feel like leaving an inline like this is imposing on the author because they "must" check it off.
  • D19635 marks the author's own inlines as "Done" by default. They may un-mark them if they prefer (e.g., actually want to leave themselves a TODO). This addresses the case where authors feel like they "must" check off every comment, so they either reply in two passes (one to submit; one to check off all their own replies) or avoid replying.
Sep 4 2018, 7:16 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: Unknown Object (Differential Revision).
Sep 4 2018, 7:08 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 7:08 PM · Plans
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: Unknown Object (Differential Revision).
Sep 4 2018, 7:02 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 7:02 PM · Plans
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: Unknown Object (Differential Revision).
Sep 4 2018, 6:31 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 6:31 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 6:01 PM · Plans
epriestley closed T13189: Plans: 2018 Week 35 Bonus Content as Resolved.
Sep 4 2018, 5:34 PM · Plans
epriestley edited the content of Changelog.
Sep 4 2018, 5:11 PM
epriestley edited the content of 2018 Week 35 (Early September).
Sep 4 2018, 5:10 PM
epriestley created 2018 Week 35 (Early September).
Sep 4 2018, 5:10 PM
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 3:51 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 3:44 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 3:42 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 3:42 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 3:41 PM · Plans
epriestley triaged T13195: 2018 Week 36 Bonus Content as Normal priority.
Sep 4 2018, 3:38 PM · Plans
timor awarded T4675: Support bulk editing object policies and other fields with complex UI controls a Burninate token.
Sep 4 2018, 12:11 PM · ApplicationEditor

Aug 31 2018

epriestley closed T13194: 1 < 2 && "z" > "a", a subtask of T13189: Plans: 2018 Week 35 Bonus Content, as Resolved.
Aug 31 2018, 11:37 PM · Plans
epriestley closed T13194: 1 < 2 && "z" > "a" as Resolved.
Aug 31 2018, 11:37 PM
epriestley triaged T13194: 1 < 2 && "z" > "a" as Normal priority.
Aug 31 2018, 11:36 PM
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 31 2018, 5:08 PM · Plans, Phriction

Aug 30 2018

epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 30 2018, 5:35 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 30 2018, 5:09 PM · Plans, Phriction
epriestley updated the task description for T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB.
Aug 30 2018, 1:24 PM · Database
epriestley triaged T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB as Low priority.
Aug 30 2018, 1:10 PM · Database
epriestley created T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB.
Aug 30 2018, 1:10 PM · Database
aristedes added a comment to T6491: Herald rules based on age.

With D11419 implemented, is it possible to now allow Herald rules to be triggered on a cron (even a very simple 'daily' option would be good)?

Aug 30 2018, 12:18 AM · Restricted Project, Herald

Aug 29 2018

epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 29 2018, 9:15 PM · Plans
epriestley closed T4815: Navigation buttons "Next version" and "Previous version" for phriction-documents, a subtask of T9379: Build Phriction v3, as Resolved.
Aug 29 2018, 8:49 PM · Phriction
epriestley closed T4815: Navigation buttons "Next version" and "Previous version" for phriction-documents as Resolved by committing Restricted Diffusion Commit.
Aug 29 2018, 8:49 PM · Badge Awarded, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 4:34 PM · Plans, Phriction
epriestley added a revision to T4815: Navigation buttons "Next version" and "Previous version" for phriction-documents: Unknown Object (Differential Revision).
Aug 29 2018, 4:34 PM · Badge Awarded, Phriction
epriestley added a comment to T13077: Plans: Phriction modern "v3" APIs, Drafts.

contentID on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road.

Aug 29 2018, 4:04 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 3:47 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 3:29 PM · Plans, Phriction
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Aug 29 2018, 3:29 PM · Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 3:18 PM · Plans, Phriction
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Oh, and also to the original use case, I'll at least add some kind of warning for this since "silently skip some patches" isn't a good behavior. I'm open to adding some other hint mechanisms on top of this later so linters can better pick which patch wins, but would like to motivate it with some specific, surgical examples. The original example, where one linter removes debugging code and one linter reformats it, is a good starting point: in this case, "remove" should have greater strength than "reformat" and we'd prefer to discard the reformat patch and apply only the removal patch.

Aug 29 2018, 3:08 PM · Restricted Project, Arcanist
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I'll plan to make these changes:

Aug 29 2018, 3:00 PM · Restricted Project, Arcanist
cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I'm going to try to rewrite our linters to emit minimal fixes and try that
out. I do think that will make the conflicts nearly nonexistent.

I think adding the "requirements of a custom linter" and possibly also
adding verification of original text matching the byte range for fix
application should still be addressed, though.

Aug 29 2018, 2:54 PM · Restricted Project, Arcanist

Aug 28 2018

epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 10:14 PM · Plans, Phriction
epriestley closed T8172: "Edit" button shouldn't be hidden in "Actions", a subtask of T9379: Build Phriction v3, as Resolved.
Aug 28 2018, 9:58 PM · Phriction
epriestley closed T8172: "Edit" button shouldn't be hidden in "Actions" as Resolved by committing Restricted Diffusion Commit.
Aug 28 2018, 9:58 PM · FreeBSD, Restricted Project, Phriction
epriestley added a revision to T8172: "Edit" button shouldn't be hidden in "Actions": Unknown Object (Differential Revision).
Aug 28 2018, 9:51 PM · FreeBSD, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 9:51 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 9:00 PM · Plans, Phriction
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 28 2018, 8:44 PM · Plans
epriestley added a comment to T9951: Store/display more information for Unit tests.

After D19615, callers to harbormaster.sendmessage can specify "format": "remarkup" to get "details" rendered as remarkup (including {Fxxx}) instead of plain text.

Aug 28 2018, 8:30 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley closed T9951: Store/display more information for Unit tests as Resolved by committing Restricted Diffusion Commit.
Aug 28 2018, 8:26 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Plans, Harbormaster
epriestley added a revision to T9951: Store/display more information for Unit tests: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Plans
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

The unit test results also don't currently show on individual builds, which is a little whack?

Aug 28 2018, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

See T13189#240682 for some planning on the Unit Test result table.

Aug 28 2018, 7:52 PM · Plans, Harbormaster
epriestley added a comment to T13189: Plans: 2018 Week 35 Bonus Content.

See PHI710. This is a request for richer lint/unit results. It's likely entangled with T13088 but can probably be planned.

Aug 28 2018, 7:52 PM · Plans

Aug 27 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:21 PM · Plans, Harbormaster
epriestley closed T10870: Allow Harbormaster builds to run another build plan on the same buildable as Invalid.

(Feature request with no support mana.)

Aug 27 2018, 10:16 PM · Restricted Project, Harbormaster