Page MenuHomePhabricator
Feed Advanced Search

Jan 20 2018

epriestley updated the task description for T13043: Improve authentication revocation behaviors.
Jan 20 2018, 4:52 PM · Phacility, Auth, Security
epriestley added a comment to T13043: Improve authentication revocation behaviors.

See D17458 for the previous, narrower case of token revocation in response to Heartbleed (T12313).

Jan 20 2018, 4:45 PM · Phacility, Auth, Security
epriestley triaged T13043: Improve authentication revocation behaviors as Normal priority.
Jan 20 2018, 4:42 PM · Phacility, Auth, Security

Jan 19 2018

epriestley renamed T4675: Support bulk editing object policies and other fields with complex UI controls from Maniphest batch editor does not allow bulk modification of visibility to Support bulk editing object policies.
Jan 19 2018, 11:03 PM · ApplicationEditor
epriestley closed T11475: Allow users to bulk-change visibility and editability policies for Phriction documents as Resolved.

This is either T4675 or T6004. I don't know which will happen first, but I'm just going to close it in favor of those.

Jan 19 2018, 11:00 PM · Phriction, Feature Request
epriestley added a revision to T10973: Allow users to edit story points via batch (bulk) edits: Unknown Object (Differential Revision).
Jan 19 2018, 10:58 PM · Maniphest, Feature Request
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 10:58 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Restricted Differential Revision.
Jan 19 2018, 10:52 PM · Transactions, ApplicationEditor
epriestley closed T13040: Fatal in Diffusion blame with missing leaves (deleted repository) as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 10:19 PM
epriestley added a revision to T13040: Fatal in Diffusion blame with missing leaves (deleted repository): Unknown Object (Differential Revision).
Jan 19 2018, 9:41 PM
epriestley closed T13042: Add a "silent" mode to bulk edits, a subtask of T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support, as Resolved.
Jan 19 2018, 9:25 PM · Transactions, ApplicationEditor
epriestley closed T13042: Add a "silent" mode to bulk edits as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 9:25 PM · ApplicationEditor
epriestley closed T5689: Batch edit of Maniphest custom fields, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Resolved.
Jan 19 2018, 9:18 PM · ApplicationEditor
epriestley closed T5689: Batch edit of Maniphest custom fields as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 9:18 PM · Custom Fields, Maniphest
epriestley closed T12415: Comment field action in batch action doesn't render correctly as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 8:45 PM · Bug Report
epriestley closed T10005: Implement an ApplicationEditor-based Bulk Editor as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 8:43 PM · ApplicationEditor
epriestley closed T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 8:40 PM · Customer Impact, Workboards, Maniphest
epriestley closed T11286: make it possible to remove tasks from a batch edit tasks workflow as Resolved by committing Restricted Diffusion Commit.
Jan 19 2018, 8:39 PM · Maniphest, Feature Request
epriestley created 2018 Week 3 (Late January).
Jan 19 2018, 8:37 PM
epriestley edited the content of 2018 Week 2 (Mid January).
Jan 19 2018, 8:27 PM
epriestley added a revision to T13042: Add a "silent" mode to bulk edits: Restricted Differential Revision.
Jan 19 2018, 6:21 PM · ApplicationEditor
epriestley added a revision to T13042: Add a "silent" mode to bulk edits: Unknown Object (Differential Revision).
Jan 19 2018, 5:48 PM · ApplicationEditor
epriestley added a revision to T13042: Add a "silent" mode to bulk edits: Unknown Object (Differential Revision).
Jan 19 2018, 3:48 PM · ApplicationEditor
epriestley added a subtask for T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: T13042: Add a "silent" mode to bulk edits.
Jan 19 2018, 3:43 PM · Transactions, ApplicationEditor
epriestley added a parent task for T13042: Add a "silent" mode to bulk edits: T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support.
Jan 19 2018, 3:43 PM · ApplicationEditor
epriestley triaged T13042: Add a "silent" mode to bulk edits as Normal priority.
Jan 19 2018, 3:43 PM · ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 3:34 PM · Transactions, ApplicationEditor
epriestley added a comment to T5689: Batch edit of Maniphest custom fields.

I've marked D18879 as fixing this. It does not extend bulk editor support to all custom field types, but makes such support generally trivial. We'll fill in and test more field types as use cases arise.

Jan 19 2018, 3:02 PM · Custom Fields, Maniphest
epriestley added a revision to T5689: Batch edit of Maniphest custom fields: Unknown Object (Differential Revision).
Jan 19 2018, 2:59 PM · Custom Fields, Maniphest
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 2:59 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 2:57 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 2:43 PM · Transactions, ApplicationEditor
epriestley added a comment to T10005: Implement an ApplicationEditor-based Bulk Editor.

I've marked D18863 as fixing this. This doesn't expose bulk editors in all applications, but generalizes all existing bulk edit operations and makes the process of adding more bulk editors straightforward.

Jan 19 2018, 2:40 PM · ApplicationEditor
epriestley added a revision to T10005: Implement an ApplicationEditor-based Bulk Editor: Unknown Object (Differential Revision).
Jan 19 2018, 2:39 PM · ApplicationEditor
epriestley added a comment to T12415: Comment field action in batch action doesn't render correctly.

I've marked D18867 as fixing this. It isn't a perfect fix, but it's closer to the realm of reasonable (you have a sensible amount of area to work with and a readable font):

Jan 19 2018, 2:38 PM · Bug Report
epriestley added a revision to T12415: Comment field action in batch action doesn't render correctly: Unknown Object (Differential Revision).
Jan 19 2018, 2:32 PM · Bug Report
epriestley added a revision to T8740: Batch edit Add Project does not perform the action requested: Unknown Object (Differential Revision).
Jan 19 2018, 2:31 PM · Maniphest
epriestley closed T8740: Batch edit Add Project does not perform the action requested, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Resolved.
Jan 19 2018, 2:31 PM · ApplicationEditor
epriestley closed T8740: Batch edit Add Project does not perform the action requested as Resolved.

After D18868, which rewrote the relevant code in the bulk editor, I can no longer reproduce this. My expectation is that the modern pathway these edits take can correctly collate multiple edits to the same field.

Jan 19 2018, 2:31 PM · Maniphest
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 2:23 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 1:53 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 19 2018, 1:18 PM · Transactions, ApplicationEditor
Ltrlg awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Jan 19 2018, 8:26 AM · Calendar

Jan 18 2018

epriestley triaged T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated as Low priority.
Jan 18 2018, 2:58 PM · Diffusion, Herald
epriestley added a comment to T13038: Meltdown and Spectre Speculative Branch Prediction Attacks.

In theory, yes. But I suspect the actual required sample size may be on the scale of "heat death of the universe", potentially making this attack less practical than just brute forcing whatever secret you're trying to extract.

Jan 18 2018, 2:10 AM · Security
neilfitz awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Yellow Medal token.
Jan 18 2018, 12:01 AM · Security

Jan 16 2018

epriestley added a comment to T13023: Non-standard patches lead to exceptions being generated.

Tangential, but T8768 is a case where we generated an unfaithful synthetic diff (a diff --git that the git binary could not generate since 2006) and took the blame for it.

Jan 16 2018, 10:22 PM · Differential
epriestley updated the task description for T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .
Jan 16 2018, 10:20 PM · Git, Mercurial, Arcanist
epriestley edited the content of Changelog.
Jan 16 2018, 10:17 PM
epriestley created 2018 Week 2 (Mid January).
Jan 16 2018, 10:16 PM
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I'm not totally sure all variants of this are fixed, but I don't know how to reproduce any remaining issues.

Jan 16 2018, 10:15 PM · Git, Mercurial, Arcanist
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them , a subtask of T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats, as Resolved.
Jan 16 2018, 9:57 PM · Arcanist, Differential
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them as Resolved by committing Restricted Diffusion Commit.
Jan 16 2018, 9:57 PM · Git, Mercurial, Arcanist
epriestley updated the answer details for Q644: Is it possible to create a database for an application which just stores edges? (Answer 564).
Jan 16 2018, 7:24 PM
epriestley added Q644: Is it possible to create a database for an application which just stores edges? (Answer 564).
Jan 16 2018, 7:16 PM
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I filed a summary of this in the Mercurial upstream to waste someone else's time so I feel better:

Jan 16 2018, 5:21 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

This is an explicit behavior in Mercurial and dates from 2007:

Jan 16 2018, 4:49 PM · Git, Mercurial, Arcanist
epriestley added a revision to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them : Unknown Object (Differential Revision).
Jan 16 2018, 4:26 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

The rule Git uses appears to literally be "does the filename include a space":

Jan 16 2018, 4:01 PM · Git, Mercurial, Arcanist
epriestley renamed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from `arc patch` fails to add two files starting by the same word, then a space on hg to Under Mercurial, `arc patch` mishandles files with spaces in them .
Jan 16 2018, 3:42 PM · Git, Mercurial, Arcanist

Jan 11 2018

epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 11 2018, 7:08 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 11 2018, 6:17 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 11 2018, 5:35 PM · Transactions, ApplicationEditor

Jan 10 2018

epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 10 2018, 9:15 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 10 2018, 9:12 PM · Transactions, ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Jan 10 2018, 9:07 PM · Transactions, ApplicationEditor

Jan 9 2018

epriestley closed T8303: Mercurial hooks as Invalid.

I'm going to close this since it was mostly answered and the remaining questions (about custom extension development) are outside the scope of modern support. See T13039 for a followup about numeric fields in Herald.

Jan 9 2018, 4:55 PM · Mercurial, Diffusion
epriestley triaged T13039: Support numeric fields in Herald as Low priority.
Jan 9 2018, 4:54 PM · Herald
jcox awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Dat Boi token.
Jan 9 2018, 4:50 PM · Security
epriestley archived Customer Impact.
Jan 9 2018, 4:46 PM
epriestley updated the task description for T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.
Jan 9 2018, 4:44 PM · Mercurial, Arcanist
epriestley closed T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state as Invalid.

Ah, thanks! This is probably effectively covered by T9948 anyway -- one of the major changes for the Git flavor of that (T9657) was "put things back the way they were when anything goes wrong, even if we discard merge/rebase work", and that seems like a better behavior. I'll make a note there just in case.

Jan 9 2018, 4:42 PM · Arcanist, Mercurial
epriestley archived Prioritized.
Jan 9 2018, 3:31 PM

Jan 8 2018

mpadourek awarded T10004: ApplicationEditor Errata a Like token.
Jan 8 2018, 11:34 AM · ApplicationEditor
mpadourek awarded T418: Integrate CustomField into more interfaces a Like token.
Jan 8 2018, 11:32 AM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields
mpadourek awarded T7930: Let Calendar provide date services to other applications a Like token.
Jan 8 2018, 10:42 AM · Calendar

Jan 6 2018

epriestley edited the content of 2018 Week 1 (Early January).
Jan 6 2018, 4:38 PM
kristo.mario awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Party Time token.
Jan 6 2018, 4:36 PM · Security
epriestley edited the content of Changelog.
Jan 6 2018, 4:30 PM
epriestley created 2018 Week 1 (Early January).
Jan 6 2018, 4:20 PM
epriestley updated the task description for T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.
Jan 6 2018, 3:26 PM · Phacility, Security, Mail

Jan 5 2018

ftdysa awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Dat Boi token.
Jan 5 2018, 9:46 PM · Security
cspeckmim awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Party Time token.
Jan 5 2018, 9:42 PM · Security
epriestley closed T13038: Meltdown and Spectre Speculative Branch Prediction Attacks as Resolved.

Another quality Security update from Phabricator! 🐕

Jan 5 2018, 9:24 PM · Security
epriestley updated the task description for T13038: Meltdown and Spectre Speculative Branch Prediction Attacks.
Jan 5 2018, 9:13 PM · Security
epriestley triaged T13038: Meltdown and Spectre Speculative Branch Prediction Attacks as Normal priority.
Jan 5 2018, 9:13 PM · Security
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

Mostly from the HN thread, other possible providers we haven't tried yet include Mandrill, Postmark, and Sparkpost.

Jan 5 2018, 8:55 PM · Phacility, Security, Mail
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

T12677 documents previous general issues with mail providers. Mailgun gets the worst of it there, but just because we've been with them for a while without anything too awful happening.

Jan 5 2018, 8:20 PM · Phacility, Security, Mail
epriestley triaged T13037: An attacker gained staff access to Mailgun and was able to read customer API keys as Normal priority.
Jan 5 2018, 8:14 PM · Phacility, Security, Mail
epriestley moved T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Git, Mercurial, Arcanist
epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state from Backlog to arc land on the Mercurial board.
Jan 5 2018, 6:55 PM · Arcanist, Mercurial
epriestley moved T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads from Backlog to arc land on the Mercurial board.
Jan 5 2018, 6:55 PM · Mercurial, Arcanist
epriestley closed T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Jan 5 2018, 6:47 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured as Resolved.

The install in PHI271 reported this as fixed after upgrading.

Jan 5 2018, 6:47 PM · Mail, Differential
epriestley closed T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured, a subtask of T13010: Upgrading: Differential Draft State, as Resolved.
Jan 5 2018, 6:47 PM · Installing & Upgrading

Jan 4 2018

arend.danielek awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 4 2018, 10:38 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

After D18857, I'm not aware of any remaining, reproducible issues with Mercurial. If you're still encountering protocol issues after upgrading through D18857, let me know how to reproduce the problem you're seeing.

Jan 4 2018, 10:32 PM · Mercurial
epriestley closed T9548: Support Mercurial's bundle2 wire protocol as Resolved.

T13036 is a more focused rebrand of this issue, since this has a lot of philosophy and not a lot of actionable reproduction steps. The three line fix in D18857 may have resolved these issues.

Jan 4 2018, 10:30 PM · Diffusion, Mercurial