Page MenuHomePhabricator
Feed Advanced Search

Apr 14 2017

epriestley added a revision to T12451: Finding your subscriptions / cards on Phacility is non-obvious: Restricted Differential Revision.
Apr 14 2017, 4:53 PM · Phortune, Phacility
dmitry.shulga awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Apr 14 2017, 4:24 PM · Workboards (v3), Restricted Project
epriestley added a revision to T12451: Finding your subscriptions / cards on Phacility is non-obvious: Unknown Object (Differential Revision).
Apr 14 2017, 4:23 PM · Phortune, Phacility
epriestley added a revision to T12451: Finding your subscriptions / cards on Phacility is non-obvious: Restricted Differential Revision.
Apr 14 2017, 4:18 PM · Phortune, Phacility
epriestley closed T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes as Resolved by committing Restricted Diffusion Commit.
Apr 14 2017, 3:03 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley updated the post content for Blog Post: That's Not a CSRF Attack.
Apr 14 2017, 3:02 PM
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

Totally my fault, I just didn't read half that sentence. 🐈

Apr 14 2017, 2:59 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
chad awarded Blog Post: That's Not a CSRF Attack a Cup of Joe token.
Apr 14 2017, 2:38 PM
epriestley created Blog Post: That's Not a CSRF Attack.
Apr 14 2017, 2:36 PM
epriestley claimed T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.
Apr 14 2017, 12:59 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley updated the task description for T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard.
Apr 14 2017, 12:58 PM · Lint, Arcanist, Contributor Onboarding
epriestley moved T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard from Backlog to Basic on the Contributor Onboarding board.
Apr 14 2017, 12:57 PM · Lint, Arcanist, Contributor Onboarding
epriestley created T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard.
Apr 14 2017, 12:57 PM · Lint, Arcanist, Contributor Onboarding
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

And thanks for the report! Let us know if you run into anything else.

Apr 14 2017, 12:10 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

D17687 should dirty the cache properly on username changes. It should promote to stable within the next ~12 hours, and deploy to Phacility production about 24 hours from now.

Apr 14 2017, 12:10 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a revision to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes: Unknown Object (Differential Revision).
Apr 14 2017, 12:09 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

I was able to resolve the issue by deleting my user's ssh key, and uploading the original ssh key material as a new Phabricator sshkey.

Apr 14 2017, 12:02 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

See also somewhat-related task T12397.

Apr 14 2017, 11:55 AM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley renamed T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes from Git push failed, "there is no user with this username" to PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.
Apr 14 2017, 11:50 AM · Customer Impact, Infrastructure, Diffusion, Bug Report

Apr 13 2017

epriestley merged T12552: Auto population of subtasks when a task is created into T7190: Project templates/Copying tasks.
Apr 13 2017, 9:32 PM · Projects, Maniphest
epriestley merged task T12552: Auto population of subtasks when a task is created into T7190: Project templates/Copying tasks.
Apr 13 2017, 9:31 PM · Feature Request
epriestley added a comment to E1469: Austin on vacation.

Maybe you will see a tree on vacation!

Apr 13 2017, 9:04 PM · Phacility
epriestley awarded E1469: Austin on vacation a Evil Spooky Haunted Tree token.
Apr 13 2017, 9:04 PM · Phacility
epriestley awarded T12524: Modernize Countdown a Mountain of Wealth token.
Apr 13 2017, 8:19 PM · Countdown
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

"RU SUB" DKP are the best DKP.

Apr 13 2017, 7:03 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

There are probably a couple of tags on hovercards and maybe user profiles which should be color-coordianted for consistency.

Apr 13 2017, 6:45 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Orange and red/vermillion are already used for "Away" and "Busy", and I think green would be confusing (similar to "online"), so maybe indigo/pink/blue/violet?

Apr 13 2017, 6:44 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

"Busy" and "Away" are temporal too. I think all three states are important: they indicate that you shouldn't expect a response from the user.

Apr 13 2017, 6:42 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

If auth.require-email-verification is off, they receive notifications in Phabricator itself.
If auth.require-email-verification is on, they can not log in or see anything until they verify their email addresses.

Apr 13 2017, 6:36 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

(Although I think the dots appeared before that change, when you enabled auth.require-email-verification to combat printer faxers.)

Apr 13 2017, 6:30 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Right.

Apr 13 2017, 6:30 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

(But almost no users in General Chat are actually disabled, I think -- all the dots are for unverified users. Not sure if those should act the same, since we probably wouldn't sort away/busy users to the bottom? Also, why not just kick those users out in normal cases?)

Apr 13 2017, 6:26 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Maybe just sort them to the bottom?

Apr 13 2017, 6:25 PM · Conpherence (v4)
epriestley added a revision to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`: Unknown Object (Differential Revision).
Apr 13 2017, 2:55 PM · Auth, Bug Report
epriestley added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

In particular, when you connect over HTTP to a security.require-https install, we normally just immediately redirect you to https://....

Apr 13 2017, 2:13 PM · Auth, Bug Report
epriestley added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

Was this on a test install on localhost? I can only reproduce this if the remote address is part of cluster.addresses.

Apr 13 2017, 1:42 PM · Auth, Bug Report
epriestley added a comment to T12548: Unable to initialize database with invalid credentials in configuration file.

This could definitely be more clear, but I think this is currently expected -- you still need to have valid configuration even when providing additional administrative credentials.

Apr 13 2017, 1:25 PM · Database, Bug Report
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

(And I think "Conpherence as an announcement tool" is a very marginal use case anyway -- today, Phame is probably better already?)

Apr 13 2017, 12:22 PM · Conpherence (v4), Security
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

That seems reasonable to me. We could implement a "read-only" equivalent later by having a flag like "require edit permission to send messages to this room" if we need it. That probably makes more sense anyway -- I can't really think of any use cases where a room is sort-of read-only, but the users who can post to it are different than users who can edit it.

Apr 13 2017, 12:20 PM · Conpherence (v4), Security
epriestley added a comment to T12525: amckinley's Onboarding.

To clarify, I meant this:

Apr 13 2017, 12:01 PM · Phacility, Contributor Onboarding
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 13 2017, 2:20 AM · Search, Customer Impact, Bug Report
epriestley closed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search, Customer Impact, Bug Report
epriestley closed T12003: Explain to users how fulltext queries are parsed and executed as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search
epriestley closed T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 12:57 AM · Search
epriestley added a comment to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty.

I'm only like 85% sure that D17667 really fixes things so yell if it still looks ~weird~.

Apr 13 2017, 12:57 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it as Resolved.

Searching for ひらがな or 漢字汉字 or 漢字汉 now finds this task. Searching for 漢字 or 汉字 does not, but I think that's because they're under the minimum token length.

Apr 13 2017, 12:19 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it, a subtask of T12003: Explain to users how fulltext queries are parsed and executed, as Resolved.
Apr 13 2017, 12:18 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字汉

Apr 13 2017, 12:09 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

ひらがな
漢字汉字

Apr 13 2017, 12:08 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字
汉字

Apr 13 2017, 12:07 AM · Search
epriestley renamed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Stemming + MySQL Fulltext search can lead to unexpected results to MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
Apr 13 2017, 12:05 AM · Search, Customer Impact, Bug Report
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 13 2017, 12:05 AM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 13 2017, 12:04 AM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 13 2017, 12:04 AM · Search, Customer Impact, Bug Report

Apr 12 2017

epriestley closed T12537: Ambiguous display of commits in maniphest as Resolved.

Great! Handling of branches is definitely something we'd like to improve in the future, but most of the improvements we have planned require significant amounts of work. If you eventually run into limitations with this approach, hopefully we'll have some improvements in place by then.

Apr 12 2017, 11:24 PM · Feature Request
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

Er, that wasn't even close -- this is simpler and actually works:

Apr 12 2017, 10:17 PM · Feature Request
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

I think you could do something like this (made-up pseudocode because my bash is garbage):

Apr 12 2017, 10:13 PM · Feature Request
epriestley added a revision to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty: Unknown Object (Differential Revision).
Apr 12 2017, 9:58 PM · Search
epriestley added a comment to T12532: `syntax.filemap` does not validate input.
  • PhabricatorSyntaxHighlightingConfigOptions defines this option.
  • Change the type from wild to custom:SomeClassName to switch to a custom type validator.
  • The new validator class should subclass PhabricatorConfigJSONOptionType.
  • You can look at PhabricatorKeyringConfigOptionType for a (more complex) example of how to validate a value.
  • Test by trying to change the value to something invalid, you should get an error.
  • You can test a regexp is valid like this:
Apr 12 2017, 8:40 PM · Contributor Onboarding, Config, Bug Report
epriestley moved T12532: `syntax.filemap` does not validate input from Backlog to Basic on the Contributor Onboarding board.
Apr 12 2017, 8:35 PM · Contributor Onboarding, Config, Bug Report
epriestley added a project to T12532: `syntax.filemap` does not validate input: Contributor Onboarding.
Apr 12 2017, 8:35 PM · Contributor Onboarding, Config, Bug Report
epriestley closed T12535: Diffusion view to show the commits within a range. as Resolved.

Cool. We'll improve this in the future and make it easier to find once we do.

Apr 12 2017, 8:33 PM · Feature Request
epriestley renamed T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud) from Use InnoDB for FULLTEXT indexes where supported to Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
Apr 12 2017, 8:19 PM
epriestley removed projects from T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Search, Infrastructure.

This is essentially complete except for the Google Cloud specific issue with MyISAM being unavailable; I'm going to retarget it for that.

Apr 12 2017, 8:18 PM
epriestley added a revision to T12546: "bin/remote deploy" picks up deployment keys locally instead of on the bastion: Unknown Object (Differential Revision).
Apr 12 2017, 8:12 PM · Ops, Infrastructure, Phacility
epriestley created T12546: "bin/remote deploy" picks up deployment keys locally instead of on the bastion.
Apr 12 2017, 7:08 PM · Ops, Infrastructure, Phacility
epriestley merged task T12545: People > Assigned Tasks are not ordered by priority into T12423: Bring MenuItem customization options to User Profiles.
Apr 12 2017, 5:28 PM · People, Bug Report
epriestley merged T12545: People > Assigned Tasks are not ordered by priority into T12423: Bring MenuItem customization options to User Profiles.
Apr 12 2017, 5:28 PM · Dashboards, Restricted Project, Profile
epriestley moved T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud) from Backlog to v2 on the Search board.
Apr 12 2017, 4:27 PM
epriestley moved T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Backlog to v2 on the Search board.
Apr 12 2017, 4:27 PM · Search, Customer Impact, Bug Report
epriestley added a project to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Search.
Apr 12 2017, 4:27 PM · Search, Customer Impact, Bug Report
epriestley added a project to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Search.
Apr 12 2017, 4:27 PM
epriestley moved T11887: Harbormaster artifacts do not decode Conduit HTTP parameters with proper types from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:59 PM · Customer Impact, Restricted Project, Harbormaster
epriestley moved T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded from Backlog to Active Impact on the Customer Impact board.
Apr 12 2017, 3:59 PM · Inline Comments, Customer Impact, Differential
epriestley moved T11363: Differential "revision updated" mail preference is pretty useless from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:59 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley moved T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster from Backlog to Future on the Customer Impact board.
Apr 12 2017, 3:59 PM · Phacility
epriestley removed a project from T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded: Phacility.
Apr 12 2017, 3:59 PM · Inline Comments, Customer Impact, Differential
epriestley edited projects for T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:58 PM · Phacility
epriestley edited projects for T11887: Harbormaster artifacts do not decode Conduit HTTP parameters with proper types, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:58 PM · Customer Impact, Restricted Project, Harbormaster
epriestley added a project to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded: Customer Impact.
Apr 12 2017, 3:58 PM · Inline Comments, Customer Impact, Differential
epriestley edited projects for T11363: Differential "revision updated" mail preference is pretty useless, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:58 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley moved T12164: Put an indirection layer between author/committer strings and user accounts from Backlog to Future on the Customer Impact board.
Apr 12 2017, 3:57 PM · Customer Impact, Diffusion (v3)
epriestley edited projects for T12164: Put an indirection layer between author/committer strings and user accounts, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:57 PM · Customer Impact, Diffusion (v3)
epriestley moved T12177: Provide time-to-review statistics and reporting in Facts from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:37 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley edited projects for T12177: Provide time-to-review statistics and reporting in Facts, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:37 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley moved T12296: Improve Phacility repository import performance from Backlog to "Customers" on the Customer Impact board.
Apr 12 2017, 3:36 PM · Customer Impact, Diffusion, Ops
epriestley edited projects for T12296: Improve Phacility repository import performance, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:36 PM · Customer Impact, Diffusion, Ops
epriestley moved T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:34 PM · Customer Impact, Restricted Project, Mail
epriestley edited projects for T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:34 PM · Customer Impact, Restricted Project, Mail
epriestley removed a project from T11773: Improve behaviors for "overheated" policy queries: Phacility.
Apr 12 2017, 3:34 PM · Performance
epriestley renamed 🐳 from ? to 🐳.
Apr 12 2017, 3:32 PM
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

("We don't want to do that just to make Phabricator work" is a completely reasonable response, but at least in this project this practice seems useful and we'd probably keep doing it even if branch information was more accessible.)

Apr 12 2017, 3:31 PM · Feature Request