Page MenuHomePhabricator
Feed Advanced Search

Mar 24 2017

epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

(In the longer term, the permissions here could probably be cleaned up, but I think that's the cleanest fix without upstream changes.)

Mar 24 2017, 10:53 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

You can edit the "Create Form" form and change "Visible To:" to "Members of Project: Doctorate in Form Theory". Then only members of that project will be able to create other forms or edit the form form, I believe.

Mar 24 2017, 10:50 PM · Bug Report
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Ah. I think you'd just see this, then:

Mar 24 2017, 10:01 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Overall, you only get checkboxes for users, packages and projects which are already reviewers, with the exception that you'll get one for yourself if you aren't a reviewer yet.

Mar 24 2017, 9:47 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

I think there is also zero legitimate reason for the form-configuring-form to be editable and this entire workflow essentially represents a trap for the unwary.

Mar 24 2017, 9:43 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

If you can't enable that form, you might need to go hunt it down in the database and manually enable it (or tell me what you hit and we'll fix it if it's a bug).

Mar 24 2017, 9:38 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

Can you click that link, then "Enable Form"? Or do you get some kind of error?

Mar 24 2017, 9:36 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

A MARVEL OF ACADEMIC PURITY, EDITENGINE PUSHES THE BOUNDARIES OF ADVANCED FORM THEORY TO NEW DEPTHS

Mar 24 2017, 9:27 PM · Bug Report
epriestley added a comment to T12449: Cannot set access control for creating new Maniphest forms.

DO YOU HAVE ACCESS TO FORMS FOR CONFIGURING FORMS?!

Mar 24 2017, 9:25 PM · Bug Report
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 24 2017, 9:03 PM · Badges (v0)
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 24 2017, 9:01 PM · Badges (v0)
epriestley created T12448: Rotate 2017 SSL certificate for `secure.phabricator.com`.
Mar 24 2017, 8:47 PM · Ops
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 24 2017, 8:44 PM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 24 2017, 8:28 PM · Daemons, Ops, Phacility
epriestley closed T12446: Can't create new diffs using `arc diff` after upgrade (possibly related to 0ceab7d36f914f1c7ae45b733a1ab1ae7b7afbad) as Resolved by committing Restricted Diffusion Commit.
Mar 24 2017, 8:14 PM · Bug Report
epriestley added a revision to T11050: Allow resigning from a review you are not directly responsible for: Unknown Object (Differential Revision).
Mar 24 2017, 8:07 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a revision to T12446: Can't create new diffs using `arc diff` after upgrade (possibly related to 0ceab7d36f914f1c7ae45b733a1ab1ae7b7afbad): Unknown Object (Differential Revision).
Mar 24 2017, 8:07 PM · Bug Report
epriestley added a revision to T12447: Missing documentation for crafting raw Conduit API requests: Unknown Object (Differential Revision).
Mar 24 2017, 7:37 PM · Conduit, Feature Request
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

Yeah, there's no real hint about that in the UI to suggest that the box will update, and it's easy to miss since it looks nearly identical after it updates. I'll add a piece of hint text to hopefully make it more clear.

Mar 24 2017, 7:32 PM · Conduit, Feature Request
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

Oh, maybe we could make this more clear. Here's how to use the examples to figure out how to make a call:

Mar 24 2017, 7:23 PM · Conduit, Feature Request
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

(Kicking Documentation off because this would just be another tab next to PHP / cURL / arc in Conduit, not static documentation.)

Mar 24 2017, 7:06 PM · Conduit, Feature Request
epriestley edited projects for T12447: Missing documentation for crafting raw Conduit API requests, added: Conduit; removed Documentation.
Mar 24 2017, 7:06 PM · Conduit, Feature Request
epriestley added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

Can you use a service like https://requestb.in with curl?

Mar 24 2017, 7:05 PM · Conduit, Feature Request
epriestley added a comment to T12446: Can't create new diffs using `arc diff` after upgrade (possibly related to 0ceab7d36f914f1c7ae45b733a1ab1ae7b7afbad).

Does your webserver error log have a more specific stack trace on the server? I can't reproduce this locally.

Mar 24 2017, 6:53 PM · Bug Report
epriestley closed T12395: Calendar events aren't sufficiently exhaustive during destruction as Resolved by committing Restricted Diffusion Commit.
Mar 24 2017, 4:21 PM · Calendar
epriestley closed T12422: Unable to navigate to "All Daemons" on Mobile as Resolved by committing Restricted Diffusion Commit.
Mar 24 2017, 4:20 PM · Daemons, Mobile, Bug Report
epriestley added a revision to T12395: Calendar events aren't sufficiently exhaustive during destruction: Unknown Object (Differential Revision).
Mar 24 2017, 4:14 PM · Calendar
epriestley added a revision to T12422: Unable to navigate to "All Daemons" on Mobile: Unknown Object (Differential Revision).
Mar 24 2017, 4:10 PM · Daemons, Mobile, Bug Report
epriestley closed T12441: Implement "Phabricator Stories" as Resolved.

I don't really see a pathway to turn this into a particularly useful and/or hilarious feature that has enough of a payoff to justify the legwork.

Mar 24 2017, 4:07 PM
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Restricted Differential Revision.
Mar 24 2017, 3:56 PM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 24 2017, 3:23 PM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 24 2017, 3:21 PM · Daemons, Ops, Phacility
epriestley merged T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection into T11037: `bin/phd status` is misleading about local / remote daemons.
Mar 24 2017, 3:07 PM · Daemons, Restricted Project
epriestley merged task T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection into T11037: `bin/phd status` is misleading about local / remote daemons.
Mar 24 2017, 3:07 PM · Restricted Project, Bug Report
epriestley added a comment to T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection.

Actually, this is a little different from what I've been seeing locally. I'm just going to merge this into T11037, which discusses some general improvements to phd status output.

Mar 24 2017, 3:07 PM · Restricted Project, Bug Report
epriestley added a comment to T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.

Based on like 10 seconds of looking at the code that's where I'd start. 💯

Mar 24 2017, 1:35 PM · Dashboards, Bug Report
epriestley claimed T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.

We should still be able to handle this case, but I can take a look at what's happening since this is a nonstandard element and the fix is probably easy once I understand what's going on with the logic.

Mar 24 2017, 10:30 AM · Dashboards, Bug Report
epriestley added a comment to T12118: Differential email does not contain reviewers/subscribers information anymore.

See also T5853 (distinguish between "blocking" and "reviewing" in email) and T10574 (provide more guidance around the pathway toward a revision becoming accepted).

Mar 24 2017, 10:25 AM · Restricted Project, Differential, Bug Report
• tomekj2ee awarded T11371: Restore PHP to Glory a Burninate token.
Mar 24 2017, 12:35 AM · Public & Media Relations

Mar 23 2017

epriestley added a comment to T9501: Need a dashboard that can used by members of differing Space/Projects.

I can't think of any offhand. It might be easier to fix the dashboard/panel stuff first (i.e., inherit parent dashboard permissions) and then do this rather than the other way around, though.

Mar 23 2017, 8:35 PM · Dashboards
epriestley added a comment to T9363: improve handling of panels that do not always return results.

We can also shrink/hide buckets from the panel context but keep them from the ApplicationSearch context. I think that's desirable -- if you go to /differential/ it's probably good to see all the bucket headers? Just not so good if you have a "Stuff to Review" panel on your home page.

Mar 23 2017, 6:59 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
epriestley added a comment to T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.

With subprojects, #project changed to mean "that project, and all its descendant projects", but any(...) and not(...) still mean "just the parameter, exactly". I think viewerprojects() and projects(user) are also "just the parameter".

Mar 23 2017, 6:33 PM · Typeahead, Projects, Maniphest, Feature Request
epriestley closed T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation? as Resolved.

Great! Thanks for the report, and for your help confirming the fix. Let us know if you run into anything else.

Mar 23 2017, 6:12 PM · Bug Report
jcox awarded T12441: Implement "Phabricator Stories" a Dat Boi token.
Mar 23 2017, 6:09 PM
epriestley added a comment to T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.

Thanks! That's consistent with 32-bit and I suspect the & 0x7FFFFFFF part of rP9326b4d131ce will fix it.

Mar 23 2017, 6:05 PM · Bug Report
epriestley added a comment to T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.

(Alternatively, upgrade to rP9326b4d131ce and run the bin/people ... command again and see if that just fixes it.)

Mar 23 2017, 5:56 PM · Bug Report
epriestley added a comment to T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.

@deathsyn Can you show me the output of this command on your system to help confirm that there's a 32-bit issue at play here?

Mar 23 2017, 5:49 PM · Bug Report
epriestley added a revision to T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?: Unknown Object (Differential Revision).
Mar 23 2017, 5:48 PM · Bug Report
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

We could probably ship it (.md in Diffusion rendering as GitHub Flavored Markdown) this week -- it wouldn't be perfect, but we do have total freedom there to iterate as we find cases we're missing there -- it's just a pretty hard sell as a priority for me relative to the development cost. Obviously it would be nice if you bring in your repository to Phabricator and the README.md renders perfectly instead of rendering mostly-okay-but-a-bit-buggy, but it's hard for me to imagine we're losing many users there.

Mar 23 2017, 5:44 PM · Remarkup, Feature Request
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

I think the two goals are sufficiently in conflict and the value of supporting these rules is so low that it probably isn't worth the effort to try to get it right most of the time.

Mar 23 2017, 5:24 PM · Remarkup, Feature Request
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

My viewpoint is that Markdown was developed for writing first-party blog posts, not for technical discussions about software.

Mar 23 2017, 4:53 PM · Remarkup, Feature Request
epriestley added a revision to T12217: Reduce the hardware cost of Phacility free instances: Unknown Object (Differential Revision).
Mar 23 2017, 2:35 PM · Ops, Phacility
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Oh, sorry! I totally missed the bit with italics which described things quite precisely.

Mar 23 2017, 2:02 PM · Bug Report, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

@cspeckmim I think that patch fixes the issue, thanks for hunting down those reproduction steps!

Mar 23 2017, 1:42 PM · Bug Report, EditEngine
epriestley closed T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task as Resolved by committing Restricted Diffusion Commit.
Mar 23 2017, 1:40 PM · Bug Report, EditEngine
• tomekj2ee awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 23 2017, 1:16 PM · Workboards (v3), Restricted Project
epriestley closed T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes as Resolved.

I haven't seen more of this and there's no planned action on our end, so I'm going to presume we've weathered the storm.

Mar 23 2017, 12:46 PM · Guides
epriestley added a revision to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task: Unknown Object (Differential Revision).
Mar 23 2017, 12:43 PM · Bug Report, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I'm going to fix the bug with these reproduction instructions:

Mar 23 2017, 12:41 PM · Bug Report, EditEngine
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 2:02 AM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 1:57 AM · Daemons, Ops, Phacility
epriestley added a comment to T12443: Applying fulltext limits first causes missing results.

T12003 is also related to this (providing more explanatory, contextual help for users executing searches which may not be doing what they want for technical reasons).

Mar 23 2017, 1:54 AM · Restricted Project, Search, Bug Report
epriestley added a comment to T12443: Applying fulltext limits first causes missing results.

There's some additional stuff in D17384, where Elastic has an internal hard limit of 10K results.

Mar 23 2017, 1:48 AM · Restricted Project, Search, Bug Report
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 1:17 AM · Daemons, Ops, Phacility
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

@beber, please file a new task with reproduction instructions that work on a clean install if you believe you've found a bug.

Mar 23 2017, 12:33 AM · Maniphest, Feature Request
epriestley added a comment to T12442: Build PhrictionPortal.

One other thought as a sort of counterpoint to myself: if we do implement T11367, I probably would expect it to work more like "portals", where you define a portal/directory/volume and everything inside it shares the same permissions. But that's because I'd plan to eventually build DefinitelyNotDropbox.app for bridging file directories to the desktop so you could mount the filesystem on your computer as a disk, and I think we get into enormous amounts of trouble if I mount the phacility_tax_documents/ drive locally and then individual files inside it might have individual permissions so I couldn't view or edit some of them, since there's no way we can give users guidance about that from a filesystem mount. But maybe we have more flexibility there than I think.

Mar 23 2017, 12:22 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think we could just add spaces without any real fuss, yeah. Two possible considerations:

Mar 23 2017, 12:15 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I do think we could make a product argument like "the hierarchical permissions system is too complicated for users to understand, and they'd be better off with a less powerful system". That might look like:

Mar 23 2017, 12:08 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think PhrictionPortal probably doesn't look too much different from "make a second wiki, except this time you don't have permission to edit the root document, and it's locked to public / all users visibility automatically, and it's at some other URL other than /w/, and remarkup has two different rules".

Mar 23 2017, 12:03 AM · Phriction

Mar 22 2017

epriestley added a comment to T12442: Build PhrictionPortal.

When I create a second portal ("Encyclopedia of Fruit") and a page ("Orange"), what URL does the page exist at?

Mar 22 2017, 11:42 PM · Phriction
phil awarded T12441: Implement "Phabricator Stories" a Dat Boi token.
Mar 22 2017, 9:02 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I 😍 love staying in touch with my favorite brands. 🎁

Mar 22 2017, 8:59 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I got the python script working by changing "w" to "wb" like a comment suggested, but I'm only getting all-black bitmaps out of it.

Mar 22 2017, 8:18 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

Does anyone actually use the "Stories" feature in one of the other things that implements it (Excel, Settings.app, Disk Recovery Utility, etc)? Why is it compelling?

Mar 22 2017, 8:09 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

The UI should probably look like this (not 100% final/polished yet):

Mar 22 2017, 7:45 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I think pictures are part of a "story"? We can have users upload pictures and take pictures with phones. There doesn't seem to be a native CLI way to get Macbooks to take photos but we can make users brew install imagesnap, it seems, and then arc could update stories.

Mar 22 2017, 7:40 PM
epriestley created T12441: Implement "Phabricator Stories".
Mar 22 2017, 7:38 PM
epriestley added a revision to T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for: Unknown Object (Differential Revision).
Mar 22 2017, 6:47 PM · Audit, Restricted Project, Differential
epriestley added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

Thanks for the extremely thorough bug report. This should be fixed in HEAD of master, and promote to stable within about 72 hours.

Mar 22 2017, 5:00 PM · Bug Report
epriestley closed T12439: Maniphest comment editing fails with required custom field and edge as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:59 PM · Bug Report
epriestley added a revision to T12439: Maniphest comment editing fails with required custom field and edge: Unknown Object (Differential Revision).
Mar 22 2017, 4:55 PM · Bug Report
epriestley closed T11050: Allow resigning from a review you are not directly responsible for, a subtask of T10967: Move Differential reviewers back to a dedicated database storage table, as Resolved.
Mar 22 2017, 4:50 PM · Restricted Project, Infrastructure, Differential
epriestley closed T11050: Allow resigning from a review you are not directly responsible for as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:50 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley closed T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:50 PM · EditEngine, Bug Report
epriestley added a revision to T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for: Unknown Object (Differential Revision).
Mar 22 2017, 4:45 PM · Audit, Restricted Project, Differential
epriestley added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

I'd guess there is a ...->setContinueOnMissingFields(true)->... missing on an Editor somewhere.

Mar 22 2017, 4:27 PM · Bug Report
epriestley added a comment to T12440: Broken project permissions/weird bug with nested projects.

Actually, that fix is completely bogus and there's no inverse edge type so this is perhaps somewhat more involved.

Mar 22 2017, 4:25 PM · Bug Report
epriestley added a comment to T12440: Broken project permissions/weird bug with nested projects.

This is probably a one-line fix, but let me repro + get test coverage on it.

Mar 22 2017, 4:25 PM · Bug Report
epriestley closed T12437: Phriction Public Visibility requires login as Invalid.

This is expected:

Mar 22 2017, 2:42 PM · Bug Report
epriestley added a comment to T12437: Phriction Public Visibility requires login.

I can't reproduce this. Phriction is successfully public on this install:

Mar 22 2017, 2:18 PM · Bug Report
epriestley claimed T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.
Mar 22 2017, 2:05 PM · EditEngine, Bug Report
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: Unknown Object (Differential Revision).
Mar 22 2017, 2:00 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T11050: Allow resigning from a review you are not directly responsible for: Unknown Object (Differential Revision).
Mar 22 2017, 1:49 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley updated the task description for T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes.
Mar 22 2017, 12:06 PM · Guides
epriestley added a comment to T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.

It's a lot easier to merge stuff than split it, so don't worry about filing new stuff if there's any ambiguity. We can merge them with a couple clicks, but if you've really described a different issue then splitting them is much more of a pain.

Mar 22 2017, 12:03 PM · EditEngine, Bug Report
epriestley added a revision to T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice: Unknown Object (Differential Revision).
Mar 22 2017, 12:03 PM · EditEngine, Bug Report

Mar 21 2017

epriestley closed T12433: Developer as Invalid.
Mar 21 2017, 11:48 PM · Feature Request
epriestley created T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes.
Mar 21 2017, 11:16 PM · Guides
epriestley added a comment to T10390: Dashboards v2 (UX).

extra-thinking.jpg (512×512 px, 6 KB)

Mar 21 2017, 10:47 PM · Dashboards (v2)
epriestley added a comment to T10390: Dashboards v2 (UX).

(And it's easier to build query panels.)

Mar 21 2017, 7:17 PM · Dashboards (v2)