After performing the upgrade my team is not able to create new diffs using arc diff.
Setup:
phbricator: daeb94561f148c41f131d7e535976b30e892f183
arcanist: d1db9a72b552151613a918e3d49fa72433387a68
libphutil: f2b2abeacf842c373cd7f58c43e7fb18a953e3d7
Reproduction steps:
- Checkout repositories at described commits
- Restart phabricator
- Run arc diff --trace on a local commit
Expected result:
- New commit ready for revision
Actual result:
- Error with message:
EXCEPTION: (HTTPFutureHTTPResponseStatus) [HTTP/500] Internal Server Error >>> UNRECOVERABLE FATAL ERROR <<< Call to a member function getPHID() on a non-object /srv/phabricator/phabricator/src/applications/differential/xaction/DifferentialRevisionTransactionType.php:63 ┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻ at [<phutil>/src/future/http/BaseHTTPFuture.php:339] arcanist(), geekie-libphutil(), phutil() #0 BaseHTTPFuture::parseRawHTTPResponse(string) called at [<phutil>/src/future/http/HTTPSFuture.php:418] #1 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37] #2 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34] #3 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64] #4 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:588] #5 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]
Updating existent diffs is not affected by the problem, only creating new ones.
Rolling back to master@{2017-03-22 00:00:00} we can create diffs again.