Page MenuHomePhabricator
Feed Advanced Search

Mar 13 2017

epriestley created T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.
Mar 13 2017, 6:54 PM · Bug Report, Clusters, Diffusion
epriestley closed T12328: "Watching Projects" doc section seems wrong as Resolved.

(Presuming this is resolved since it's been open for a while without feedback.)

Mar 13 2017, 5:44 PM · Restricted Project, Documentation, Bug Report
epriestley added a comment to T12380: Errors with Mercurial trust while browsing rHGTEST on this install.

This is likely just some of the secure hosts having different configuration. Ideally, we'd get the rCORE deployment stuff aligned to deploy them with it.

Mar 13 2017, 5:11 PM · Mercurial, Bug Report
epriestley added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

Any ideas on how we can move forward with this?

Mar 13 2017, 4:12 PM · Conduit, Differential, Bug Report
epriestley renamed T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence from Remakrup textbox missing most buttons in Mobile mode to Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence.
Mar 13 2017, 4:08 PM · Design, Conpherence, Bug Report
epriestley edited projects for T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence, added: Conpherence, Design; removed Remarkup.

These CSS rules:

Mar 13 2017, 4:08 PM · Design, Conpherence, Bug Report
avivey added a project to T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence: Remarkup.
Mar 13 2017, 2:59 PM · Design, Conpherence, Bug Report
avivey renamed T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence from Markdown preview not loading on mobile and tablet view to Remakrup textbox missing most buttons in Mobile mode .
Mar 13 2017, 2:57 PM · Design, Conpherence, Bug Report
KostasPelelis created T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence.
Mar 13 2017, 11:50 AM · Design, Conpherence, Bug Report
joshuaspence added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

Mar 13 2017, 3:15 AM · Conduit, Differential, Bug Report
joshuaspence added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

OK weird, I can't reproduce it anymore. Anyway, I'll add the response body from differential.querydiffs here. It shouldn't contain any sensitive information, but I'll restrict the visibility of the file given that it does contain email addresses.

Mar 13 2017, 3:11 AM · Conduit, Differential, Bug Report
joshuaspence created T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.
Mar 13 2017, 3:03 AM · Conduit, Differential, Bug Report

Mar 12 2017

epriestley closed T12387: Typo in code. as Resolved by committing Restricted Diffusion Commit.
Mar 12 2017, 9:23 PM · Bug Report
epriestley added a revision to T12387: Typo in code.: Restricted Differential Revision.
Mar 12 2017, 8:46 PM · Bug Report
slsumathi created T12388: Newly created Git repository main page is not shown up.
Mar 12 2017, 12:25 PM · Bug Report (Needs Information)
chad added a comment to T12387: Typo in code..

(You can use T12270 to give feedback or report bugs on Badges, specifically)

Mar 12 2017, 4:08 AM · Bug Report
chad added a comment to T12387: Typo in code..

Please read and follow Contributing Bug Reports. Also, we don't accept bug reports against prototype applications.

Mar 12 2017, 4:05 AM · Bug Report
arielyang added a comment to T12385: Incorrect Chinese unicode character saving in translation config..

Yes, it is not "incorrect" but it is not human-readable format problem same with T8973 either. Chinese / Japanese / Korean unicode should be shown as what it is instead of some unreadable unicode digitals, especially in TRANSLATION functions, otherwise how to translate and confirm that?

Mar 12 2017, 1:30 AM · libphutil, Localization, Bug Report
arielyang created T12387: Typo in code..
Mar 12 2017, 1:21 AM · Bug Report

Mar 11 2017

chad added a project to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Mail.
Mar 11 2017, 8:20 PM · Mail, Bug Report
chad added a project to T12380: Errors with Mercurial trust while browsing rHGTEST on this install: Mercurial.
Mar 11 2017, 8:19 PM · Mercurial, Bug Report
cspeckmim added a comment to T11892: Aphlict does not work using SSL and node 6.9.1.

Tried again with node v6.9.4 (current version of node with CentOS7), and still has same problem 😢

Mar 11 2017, 8:07 PM · Aphlict, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

Happy to accept a patch for this (deleting that one line of code) if someone wants to claim that they tested the scenario above and it worked correctly.

Mar 11 2017, 6:57 PM · Macros, Phame, Bug Report
epriestley renamed T12373: Support macros in Phame from Macro not displaying in Phame post to Support macros in Phame.
Mar 11 2017, 6:56 PM · Macros, Phame, Bug Report
chad closed T12381: Profile link click area overflow? as Resolved by committing Restricted Diffusion Commit.
Mar 11 2017, 5:41 PM · Bug Report
epriestley merged task T12385: Incorrect Chinese unicode character saving in translation config. into T8973: Encoding JSON for presentation could use more human-friendly escaping rules.
Mar 11 2017, 5:38 PM · libphutil, Localization, Bug Report
epriestley added a comment to T12385: Incorrect Chinese unicode character saving in translation config..

This behavior is not "incorrect", it just isn't the most human-readable format we could use. I'm going to merge this into T8973, which discusses this and other potential improvements to human-readability for JSON encoded for presentation.

Mar 11 2017, 5:38 PM · libphutil, Localization, Bug Report
arielyang added a project to T12385: Incorrect Chinese unicode character saving in translation config.: libphutil.
Mar 11 2017, 5:19 PM · libphutil, Localization, Bug Report
arielyang updated the task description for T12385: Incorrect Chinese unicode character saving in translation config..
Mar 11 2017, 5:17 PM · libphutil, Localization, Bug Report
chad edited projects for T12385: Incorrect Chinese unicode character saving in translation config., added: Localization; removed Transactions.
Mar 11 2017, 4:50 PM · libphutil, Localization, Bug Report
chad added a project to T12385: Incorrect Chinese unicode character saving in translation config.: Transactions.
Mar 11 2017, 4:50 PM · libphutil, Localization, Bug Report
arielyang updated the task description for T12385: Incorrect Chinese unicode character saving in translation config..
Mar 11 2017, 4:03 PM · libphutil, Localization, Bug Report
arielyang created T12385: Incorrect Chinese unicode character saving in translation config..
Mar 11 2017, 4:02 PM · libphutil, Localization, Bug Report
fosskevin added a comment to T12381: Profile link click area overflow?.

When I checked the source code I saw that the anchor tag was being applied
to the profile image, so I assumed that the link should be clickable only
inside the area of the profile image.

Mar 11 2017, 7:19 AM · Bug Report
chad added a comment to T12381: Profile link click area overflow?.

Why do you think its a bug?

Mar 11 2017, 3:55 AM · Bug Report
fosskevin added a comment to T12381: Profile link click area overflow?.

Yes, I was referring to a small area around the hovercard which was clickable. Not a big issue, but just something I noticed the other day. 😄

Mar 11 2017, 2:41 AM · Bug Report

Mar 10 2017

lvital added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Great, thank you!

Mar 10 2017, 10:55 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

After D17489 you should be able to do this:

Mar 10 2017, 10:50 PM · Mail, Bug Report
epriestley added a revision to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Restricted Differential Revision.
Mar 10 2017, 10:48 PM · Mail, Bug Report
lvital added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Sounds reasonable to me.

Mar 10 2017, 10:45 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Hrrm -- I can adjust bin/mail send-test to accept raw email addresses, and then you can use it to send a message to test+00001@gmail.com, test+00002@gmail.com and similar. Shouldn't be too involved.

Mar 10 2017, 10:43 PM · Mail, Bug Report
lvital added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Any suggestions to test this on staging without mass emailing everyone / patching prod? I am trying to test this on staging with bin/mail show-outbound --id xxxx (staging has mail disabled), but the recipients / To: list look fine with or without the patch.

Mar 10 2017, 10:23 PM · Mail, Bug Report
chad added a revision to T12381: Profile link click area overflow?: Restricted Differential Revision.
Mar 10 2017, 7:18 PM · Bug Report
cinek updated the task description for T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings.
Mar 10 2017, 2:39 PM · Lint, Arcanist, Bug Report
cinek created T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings.
Mar 10 2017, 2:24 PM · Lint, Arcanist, Bug Report
chad added a comment to T12381: Profile link click area overflow?.

I going guess the here is that a small margin around the area of the hovercard is clickable? Or maybe your using a browser that displays a more nefarious issue? In Chrome/Mac I can't reproduce anything unexpected or can't find anything I'm prevented in doing, like copying text from the hovercard. Hovercards are meant to be small bits of information, and then click through to the profile. I'm not sure what "bug" there is in having a larger click area.

Mar 10 2017, 2:04 PM · Bug Report
chad added a comment to T12381: Profile link click area overflow?.

What is the bug that you're reporting here?

Mar 10 2017, 1:49 PM · Bug Report
fosskevin created T12381: Profile link click area overflow?.
Mar 10 2017, 9:51 AM · Bug Report
cspeckmim added a comment to T12380: Errors with Mercurial trust while browsing rHGTEST on this install.

Different parts of the repository page may or may not load indicating error. I refreshed on the page with the commit a few times and sometimes it says the commit is missing and other times it can't load the content, and other times it can't load the paths, but sometimes it can load them.

Mar 10 2017, 5:32 AM · Mercurial, Bug Report
cspeckmim created T12380: Errors with Mercurial trust while browsing rHGTEST on this install.
Mar 10 2017, 5:28 AM · Mercurial, Bug Report

Mar 9 2017

chad closed T12326: Long tag names can break out of hovercards as Resolved by committing Restricted Diffusion Commit.
Mar 9 2017, 7:09 PM · Bug Report, Hovercards, PHUI
chad added a revision to T12326: Long tag names can break out of hovercards: Restricted Differential Revision.
Mar 9 2017, 7:06 PM · Bug Report, Hovercards, PHUI
lvital added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Thanks for the quick fix and the huge amount of detail under the hood, we'll give that patch a shot!

Mar 9 2017, 6:57 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Internally, PHPMailer sends headers through two adjustment phases:

Mar 9 2017, 6:30 PM · Mail, Bug Report
epriestley added a comment to T12359: Registration does not accept valid email addresses.

I know someone who has a normalname@domain.horse address and frequently finds services which won't accept it (since they're hard-coded for 3-letter TLDs) so I'd guess users with ={^_^}=@nekoneko.com addresses run into more frequent problems. We should handle .horse, .technology, etc., properly.

Mar 9 2017, 6:18 PM · Bug Report
lambdafu added a comment to T12359: Registration does not accept valid email addresses.

I am sure these email addresses are valid, but they are from people who run their own mailserver and can easily add a reasonable address for themselves, so I agree with your conclusion. More importantly, I want to thank you for your quick response, for phabricator, and your passion!

Mar 9 2017, 6:15 PM · Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Can you test if this fixes the issue in your environment?

Mar 9 2017, 6:15 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think this is the controlling specification -- 2008 was a simpler time when no sequence of non-whitespace characters could ever be longer than 78 bytes, and a thousand bytes of memory was an untold wealth of riches:

Mar 9 2017, 6:09 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think the actual issue is that we're not wrapping the header. When I generate a synthetic message locally with a "To:" header with a length of ~50,000 bytes, the raw output is an unbroken line ~50,00 bytes long. I suspect this is RFC-violating and that whatever the mail gets handed to next gets upset by it.

Mar 9 2017, 5:57 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Perfect, thanks!

Mar 9 2017, 5:28 PM · Mail, Bug Report
jmeador added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

The default -- PhabricatorMailImplementationPHPMailerLiteAdapter

Mar 9 2017, 5:27 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

What is metamta.mail-adapter set to?

Mar 9 2017, 5:26 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

See also T12046 for why all open source is sketchy voodoo and the eventual pathway forward here is likely replacing it with first-party code.

Mar 9 2017, 5:25 PM · Mail, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

That is, the problem would be:

Mar 9 2017, 3:37 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

I guess we actually have to test this use case:

Mar 9 2017, 3:36 PM · Macros, Phame, Bug Report
chad added a comment to T12373: Support macros in Phame.

I can fix if it's one line, I just assumed it was something super hard with external urls or something.

Mar 9 2017, 3:32 PM · Macros, Phame, Bug Report
chad added a comment to T12373: Support macros in Phame.

I blame the fun police.

Mar 9 2017, 3:32 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/markup/PhabricatorMarkupEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$356

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley updated subscribers of T12373: Support macros in Phame.

Macros are disabled in Phame posts, via markup engine. This originated in D2202.

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
cspeckmim added a comment to T12370: Maniphest menu items misalign if they have submenu items.

youreawesome

Mar 9 2017, 3:27 PM · Bug Report
chad closed T12370: Maniphest menu items misalign if they have submenu items as Resolved by committing Restricted Diffusion Commit.
Mar 9 2017, 3:25 PM · Bug Report
chad closed T12377: S3 cannot migrate / upload files as Wontfix.
Mar 9 2017, 2:45 PM · Bug Report
rlex added a comment to T12377: S3 cannot migrate / upload files.

Ok, i'm an idiot.
I configured wrong endpoint.
It's working now.
Still, it might be good idea for mentioning this policy in install doc - it's not really obvious that you need

"Effect": "Allow",
"Action": "s3:ListAllMyBuckets",
"Resource": "arn:aws:s3:::*"

For IAM policy to work.

Mar 9 2017, 1:37 PM · Bug Report
rlex added a comment to T12377: S3 cannot migrate / upload files.

Probably worth mentioning that this creds are configured using IAM instead of root creds.
Policy for this user:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": "s3:ListAllMyBuckets",
            "Resource": "arn:aws:s3:::*"
        },
        {
            "Effect": "Allow",
            "Action": "s3:*",
            "Resource": [
                "arn:aws:s3:::files.example.com",
                "arn:aws:s3:::files.example.com/*"
            ]
        }
    ]
}
Mar 9 2017, 1:29 PM · Bug Report
rlex created T12377: S3 cannot migrate / upload files.
Mar 9 2017, 1:27 PM · Bug Report
chad triaged T12373: Support macros in Phame as Low priority.
Mar 9 2017, 2:47 AM · Macros, Phame, Bug Report
CodeMouse92 created T12373: Support macros in Phame.
Mar 9 2017, 2:39 AM · Macros, Phame, Bug Report
chad added a revision to T12370: Maniphest menu items misalign if they have submenu items: Restricted Differential Revision.
Mar 9 2017, 2:03 AM · Bug Report
lvital updated subscribers of T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 9 2017, 12:55 AM · Mail, Bug Report
lvital created T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 9 2017, 12:50 AM · Mail, Bug Report

Mar 8 2017

cspeckmim added a comment to T12370: Maniphest menu items misalign if they have submenu items.

I tried removing white space: nowrap; (from one of .phabricator-action-view button.phabricator-action-view-item, .phabricator-action-view-item) in the browser inspector on FF and it looks like it goes back to normal (even when expanding).

Mar 8 2017, 8:52 PM · Bug Report
chad added a comment to T12370: Maniphest menu items misalign if they have submenu items.

Yeah Chrome is fine as well.

Mar 8 2017, 8:48 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:43 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:42 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:42 PM · Bug Report
cspeckmim created T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:41 PM · Bug Report
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I've followed the steps you listed above but am not able to reproduce the issue. Do you have more information you can give us on how to reproduce the bug? Without reproduction steps the upstream cannot move forward.

Mar 8 2017, 2:44 PM · Bug Report, EditEngine
d.maznekov updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 8 2017, 2:31 PM · Bug Report, EditEngine
d.maznekov created T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 8 2017, 2:30 PM · Bug Report, EditEngine
mcorteel added a comment to T12284: Wrong notification label (subtask status update).

Thank you for the very thorough reply.
That's not a big deal and it certainly can wait!

Mar 8 2017, 12:46 PM · Bug Report
mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

In our case these are commits from landed Differential diffs. Permissions
for the web user are there and correct, but I'm not sure I understand all
the details around the daemon vs. web user, and the daemon is doing the
work for this git commit parser.

Mar 8 2017, 12:46 PM · Daemons, Bug Report
mcorteel added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.

Thank you for your quick reaction (and sorry that I didn't reply sooner). I think a black color with a 1px black text-shadow looks better. The blue is confusing (it sort of looks like a link).
So I suggest:

.phui-document-view .phabricator-remarkup .remarkup-header strong {
  color: #000000;
  text-shadow: 0 0 1px #000000;
}
Mar 8 2017, 12:42 PM · Remarkup, Bug Report
avivey added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

mkdir: cannot create directory ‘/var/storage/3f/49’: Permission denied

Mar 8 2017, 11:56 AM · Daemons, Bug Report
• sshannin renamed T7022: diffusion - doesn't understand svn Replace operation from Differential looking at wrong revision #'s to diffusion - doesn't understand svn Replace operation.
Mar 8 2017, 12:40 AM · Bug Report, Diffusion, Subversion
chad closed T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead as Resolved by committing Restricted Diffusion Commit.
Mar 8 2017, 12:38 AM · PHUI, Bug Report
chad closed T12366: Long Project names outgrow dropdown widget as Resolved by committing Restricted Diffusion Commit.
Mar 8 2017, 12:36 AM · PHUI, Bug Report

Mar 7 2017

mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

Occasionally, even after running the re-parse command, the basics of the commit will import but the content itself will not. A phd restart will almost immediately allow the commit to then import.

Mar 7 2017, 10:18 PM · Daemons, Bug Report
chad added a revision to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead: Restricted Differential Revision.
Mar 7 2017, 9:29 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

But other interfaces around Phabricator are not going to fair as well, just FYI.

Mar 7 2017, 9:25 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

Server side reduces this quite a bit:

Mar 7 2017, 9:25 PM · PHUI, Bug Report