Page MenuHomePhabricator
Feed Advanced Search

Nov 7 2016

epriestley merged task T11828: LDAP username change does not update externalaccount table into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
Nov 7 2016, 3:08 PM · People, LDAP, Bug Report
epriestley added a comment to T11828: LDAP username change does not update externalaccount table.

This isn't a bug. Here's an example of why the proposed behavior is dangerous:

Nov 7 2016, 3:08 PM · People, LDAP, Bug Report
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

I'd prefer not to produce any output until we've generated everything, so we don't end up in a situation where we output half of the file and then fail if we can help it. Additionally, this script changed in D16744, a few weeks ahead of your version.

Nov 7 2016, 3:01 PM · Diffusion, Bug Report
epriestley added a comment to T5267: Localize Phabricator.

I don't know what this means. $ in the string contents isn't anything special for translatewiki.net.

Nov 7 2016, 2:51 PM · Prioritized, Localization

Nov 6 2016

epriestley added a comment to T5267: Localize Phabricator.

The technical definition of "Limited" is that it has fewer than 512 strings, including 0 strings.

Nov 6 2016, 10:31 PM · Prioritized, Localization
epriestley added a comment to T11826: Improve troubleshooting section of phd in Diffusion Hosting Guide.

You should file a new bug report, describing exactly what you did and how we can reproduce the problem.

Nov 6 2016, 9:51 PM · Documentation
epriestley closed T11826: Improve troubleshooting section of phd in Diffusion Hosting Guide as Invalid.

To report a bug, please provide complete reproduction steps. We can't fix issues we can't reproduce. See Contributing Bug Reports for details.

Nov 6 2016, 9:46 PM · Documentation
epriestley added a comment to T5267: Localize Phabricator.

I think D16810 should get this started, at least. Known technical issues:

Nov 6 2016, 9:40 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 6 2016, 9:27 PM · Prioritized, Localization
epriestley merged T11825: Prose diffs unusable for changes with large blocks of unmodified text into T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 6 2016, 9:08 PM · Prioritized, Transactions
epriestley merged task T11825: Prose diffs unusable for changes with large blocks of unmodified text into T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 6 2016, 9:08 PM · Remarkup, Bug Report
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 6 2016, 7:20 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 6 2016, 6:49 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

@MZMcBride, couple of questions so we can improve this:

Nov 6 2016, 5:31 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 6 2016, 5:16 PM · Prioritized, Localization
epriestley closed T4788: Allow "Edit Dependencies" both ways (blocking and depending) as Resolved by committing Restricted Diffusion Commit.
Nov 6 2016, 5:05 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley closed T4788: Allow "Edit Dependencies" both ways (blocking and depending), a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Nov 6 2016, 5:05 PM · Maniphest
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I've marked D16806 as resolving this. Once that lands, here's the state of the world in terms of how the product works:

Nov 6 2016, 5:05 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Nov 6 2016, 4:14 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 6 2016, 3:42 PM · Bug Report, Calendar
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
mysql> select * from repository_refcursor where repositoryPHID = 'PHID-REPO-9a38b7db1b795ae3e348'\G
*************************** 1. row ***************************
              id: 16859
            phid: PHID-RREF-2v6ff7fmx4p62ddr3x7w
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fCKLrzDyaVYn
      refNameRaw: master
 refNameEncoding: utf8
commitIdentifier: e1566bef63c273404d3e8a3e8b4b4e23e387d772
        isClosed: 0
*************************** 2. row ***************************
              id: 16860
            phid: PHID-RREF-ev7y6ezkb4iqbbhpm3jp
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fCKLrzDyaVYn
      refNameRaw: master
 refNameEncoding: utf8
commitIdentifier: e1566bef63c273404d3e8a3e8b4b4e23e387d772
        isClosed: 0
*************************** 3. row ***************************
              id: 16854
            phid: PHID-RREF-bu25xmjsnzlb5lvdux2g
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fWcLw_rNrNJF
      refNameRaw: stable
 refNameEncoding: utf8
commitIdentifier: 111c63955155046bbd57c3836c78d460ebe13dfb
        isClosed: 0
3 rows in set (0.00 sec)
Nov 6 2016, 3:16 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T11801: Calendar: ICS Import Errata.

I would expect that we could parse a 3MB .ics file in less than 30 seconds, but obviously there's nothing to prevent you from uploading a 30MB or 300MB or 3GB .ics file, and at some point we'll take longer than 30 seconds to process it.

Nov 6 2016, 2:18 PM · Bug Report, Calendar

Nov 5 2016

epriestley added a comment to T11801: Calendar: ICS Import Errata.

T11399 has some discussion of "Location" for events -- we could possibly implement a little piece of that now to split out resources from normal attendees, but my initial inclination is to wait until we do a real implementation of locations.

Nov 5 2016, 5:35 PM · Bug Report, Calendar
epriestley closed T11822: asdf as Invalid.
Nov 5 2016, 4:54 PM
epriestley added a comment to T11801: Calendar: ICS Import Errata.

I wasn't immediately able to reproduce the "OPT-PARTICIPANT" issue -- here's the file I used, trying to mimic your test case:

Nov 5 2016, 4:43 PM · Bug Report, Calendar
epriestley added a comment to T11801: Calendar: ICS Import Errata.
  • D16804 should resolve the sha1() issue.
    • That may also resolve the timeout: the sha1() issue made us take a much slower code path. But I might also need to optimize the import and make it fall back to occurring in the background for large .ics files. Let me know if you're still seeing timeouts after the sha1() fix.
    • When a user is only an email address, we currently show "Private User 1" instead of the address. We could just show the address, or could show some "totally impossible to guess" address like me.......om@mycompany.com, but I wanted to err on the side of caution about disclosing email addresses, at least to start with. We're fairly conservative about this in other parts of the product and it's hard to put the cat back in the bag if we consider this information open. In Phabricator, it's easier to import an .ics file and expose the data to all users than it is in more private-by-default / personally-focused applications with defaults aimed more toward individual users, which also gives me some pause. But this may get in the way of usability too much, so I could see changing this behavior. If a user has a display name ("Meeting Room" <meetingroom@company.com>), we should show them as "Meeting Room", we just avoid showing meetingroom@company.com if that's the only name we have.
    • I'll look at the OPT-PARTICIPANT thing, I would expect them to import but just not have an "optional" marker right now. To clarify, they didn't import at all, right?
    • The "Ignored Node" stuff is likely fine, things like VALARM sections inside VEVENT sections. At some point I'll make the error message more helpful ("Ignored a VALARM section; Phabricator does not send reminders for imported events.") but probably OK to ignore those warnings for now.
    • URI stuff is because security.outbound-blacklist defaults to blacklisting all private/internal IP space, to prevent attackers from discovering and interacting with private services on your network by using features like image proxying, macros, calendar import, etc. If you want to fetch data from a host in private IP space, you'll need to remove its address from the blacklist (or expose an alternate interface for it in public IP space).
Nov 5 2016, 4:39 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 5 2016, 4:26 PM · Bug Report, Calendar
epriestley renamed T4124: Test the capabilities of `diff` better, especially for Solaris from Test the capabilities of `diff` better to Test the capabilities of `diff` better, especially for Solaris.
Nov 5 2016, 3:57 PM · Arcanist
epriestley merged task T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes into T4124: Test the capabilities of `diff` better, especially for Solaris.
Nov 5 2016, 3:56 PM · Bug Report (Needs Information)
epriestley merged T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes into T4124: Test the capabilities of `diff` better, especially for Solaris.
Nov 5 2016, 3:56 PM · Arcanist
epriestley added a comment to T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes.

Cool. I'll merge this into T4124 and retitle that to be a little more specific.

Nov 5 2016, 3:56 PM · Bug Report (Needs Information)
epriestley added a comment to T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes.

We've only seen that one other time, so it hasn't been a priority to fix. I believe the other install which hit the issue was able to install GNU diff to resolve it.

Nov 5 2016, 3:48 PM · Bug Report (Needs Information)
epriestley added a comment to T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes.

Incidentally, this Phabricator installation is running on Solaris (Solaris 11.3) if that makes any difference.

Nov 5 2016, 3:42 PM · Bug Report (Needs Information)
epriestley added a comment to T11809: Calendar v1 Errata Mark II.

(If you believe I'm mistaken, please show the full stack trace for the error so we can identify and remove the remaining reference to this column.)

Nov 5 2016, 3:13 PM · Calendar
epriestley added a comment to T11809: Calendar v1 Errata Mark II.

@deric, the code event.dateTo no longer appears anywhere in Phabricator (it was removed prior to the column being removed) so I suspect you did not restart properly and were running cached code (or possibly have custom code you need to update). See Restarting Phabricator.

Nov 5 2016, 3:05 PM · Calendar
epriestley edited the content of Changelog.
Nov 5 2016, 1:05 AM
epriestley created 2016 Week 45 (Early November).
Nov 5 2016, 1:05 AM

Nov 4 2016

epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • D16803 should fix Applications → Calendar → Edit Policies.
  • D16800 + D16801 should fix fanciful timezones present in ICS files.
  • D16802 should add the ability to select a greater or lesser degree of away-ness for each event.
Nov 4 2016, 11:54 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 11:40 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 11:36 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 10:39 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 10:30 PM · Restricted Project, Calendar
• Gadget0624 awarded T10262: Scramble file secrets when attached objects change their view policies a Burninate token.
Nov 4 2016, 5:59 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley closed T11820: Provision and deploy new 007/008 shards in the Phacility cluster as Resolved.

These shards are now in service.

Nov 4 2016, 5:49 PM · Ops, Phacility
epriestley added a comment to T11820: Provision and deploy new 007/008 shards in the Phacility cluster.

Provisioning completed, now deploying.

Nov 4 2016, 5:22 PM · Ops, Phacility
epriestley edited the content of Adding Hardware.
Nov 4 2016, 5:11 PM
epriestley edited the content of Phacility Cluster Devices.
Nov 4 2016, 5:10 PM
epriestley added a comment to T11820: Provision and deploy new 007/008 shards in the Phacility cluster.

Starting this now.

Nov 4 2016, 5:07 PM · Ops, Phacility
epriestley created T11820: Provision and deploy new 007/008 shards in the Phacility cluster.
Nov 4 2016, 4:57 PM · Ops, Phacility
epriestley closed T11812: "Create a Paste" button on welcome page doesn't work as Resolved by committing Restricted Diffusion Commit.
Nov 4 2016, 4:51 PM · Paste, Bug Report
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Yeah, test on master -- there's a ton of stuff fixed there that's still broken on stable.

Nov 4 2016, 3:05 AM · Restricted Project, Calendar
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Today, we already decode the SSH wire protocol and figure out what's going on inside it up to the bundle2 stuff -- here's the, uh, "protocol spec":

Nov 4 2016, 2:59 AM · Diffusion, Mercurial

Nov 3 2016

epriestley created T11818: Phacility `notify` tier is pooled, but tries to load database configuration on restart.
Nov 3 2016, 9:04 PM · Aphlict, Ops, Phacility
epriestley closed T11815: Rotate *.phacility.com SSL certificate as Resolved.

I've rotated the certificates on lb, alb, and notify. One minor notify issue that I'll file separately.

Nov 3 2016, 9:00 PM · Phacility, Ops
epriestley added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.

As a workaround, the recommended value is 9999999999999999999999999999999999996999999999999999999999929999999999999.

Nov 3 2016, 8:20 PM · Setup, Bug Report
rencris awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 3 2016, 7:08 PM · Calendar
epriestley moved T11816: Calendar: Feedback and Suggestions from Backlog to Unprototype (v1) on the Calendar board.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley added a project to T11816: Calendar: Feedback and Suggestions: Calendar.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley created T11816: Calendar: Feedback and Suggestions.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley closed T8052: Calendar feed story should include description of event as Wontfix.

I'm just going to WONTFIX this for now since Maniphest and Differential don't show descriptions either and it's not clear to me that event descriptions are significantly more valuable than task/revision/etc descriptions. Open to changing this, but we should either change it everywhere or have some consistent rule for when they do/don't show.

Nov 3 2016, 6:54 PM · Calendar
epriestley created T11815: Rotate *.phacility.com SSL certificate.
Nov 3 2016, 6:29 PM · Phacility, Ops
epriestley edited projects for T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this by following the steps provided. Here's what I did:

Nov 3 2016, 6:27 PM · Bug Report (Needs Information)
epriestley added a revision to T11812: "Create a Paste" button on welcome page doesn't work: Unknown Object (Differential Revision).
Nov 3 2016, 6:24 PM · Paste, Bug Report

Nov 2 2016

epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 11:15 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 10:43 PM · Calendar
epriestley renamed T11792: Remove "No Highlighting" mode from Diffusion from line-linking fails silently when user's set to "no highlighting" to Remove "No Highlighting" mode from Diffusion.
Nov 2 2016, 9:04 PM · Diffusion, Bug Report
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 9:00 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 8:44 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 8:12 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved.

This appears to legitimately be fixed, now.

Nov 2 2016, 7:57 PM · Calendar
epriestley added a revision to T11808: Calendar has cursor paging issue on import sources: Unknown Object (Differential Revision).
Nov 2 2016, 6:34 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

I finally got this reproducing locally, at least.

Nov 2 2016, 6:19 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 6:09 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 6:06 PM · Calendar
epriestley reopened T11808: Calendar has cursor paging issue on import sources as "Open".

Gah.

Nov 2 2016, 6:03 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:43 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:36 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:33 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 5:16 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 4:57 PM · Calendar
epriestley added a comment to T9848: CustomLinter Fails.

If it is impossible to reproduce this issue without writing custom code, we won't accept a patch for it.

Nov 2 2016, 4:56 PM · Lint
epriestley added a project to T11810: Live log output from harbormaster: Harbormaster.
Nov 2 2016, 4:53 PM · Harbormaster, Feature Request
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 4:53 PM · Calendar
epriestley closed T11811: test as Invalid.
Nov 2 2016, 3:17 PM

Nov 1 2016

epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 1 2016, 11:28 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 1 2016, 10:52 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved.

I "fixed" this by deleting the data more aggressively and reloading the import. I couldn't reproduce this locally so I think it was a transient issue with an older import bug.

Nov 1 2016, 10:09 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

It seems that we're somehow importing events so they end up as their own parents.

Nov 1 2016, 10:03 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:51 PM · Calendar
epriestley reopened T11808: Calendar has cursor paging issue on import sources as "Open".

That changed the stack trace but didn't fix the issue so I probably need to not cheat.

Nov 1 2016, 9:45 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved by committing Restricted Diffusion Commit.
Nov 1 2016, 9:40 PM · Calendar
epriestley renamed T11809: Calendar v1 Errata Mark II from Calendar v1 Errata to Calendar v1 Errata Mark II.
Nov 1 2016, 9:31 PM · Calendar
epriestley added a subtask for T7924: Unprototype Calendar (v1): T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:31 PM · Restricted Project, Prioritized, Calendar
epriestley added a parent task for T11809: Calendar v1 Errata Mark II: T7924: Unprototype Calendar (v1).
Nov 1 2016, 9:31 PM · Calendar
epriestley created T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:30 PM · Calendar
epriestley added a revision to T11808: Calendar has cursor paging issue on import sources: Unknown Object (Differential Revision).
Nov 1 2016, 8:59 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

I can't reproduce this locally and I'm not really sure what's up (bad/weird import, maybe? But no issues importing the same source locally), so I'm just going to cheat my way through it at least for the moment.

Nov 1 2016, 8:56 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

Here's the trace:

Nov 1 2016, 8:44 PM · Calendar
epriestley created T11808: Calendar has cursor paging issue on import sources.
Nov 1 2016, 8:43 PM · Calendar
epriestley closed T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions as Resolved by committing Restricted Diffusion Commit.
Nov 1 2016, 8:36 PM · Calendar