Page MenuHomePhabricator
Feed Advanced Search

Jan 21 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Maybe someday this will be easier; https://lists.w3.org/Archives/Public/www-style/2016Mar/0370.html

Jan 21 2017, 10:13 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I'll get back to you

Jan 21 2017, 7:50 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Well

Jan 21 2017, 7:50 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think the pros and cons are something like:

Jan 21 2017, 7:29 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

oh man these crack me up.

Jan 21 2017, 7:23 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (110×2 px, 68 KB)

Jan 21 2017, 7:20 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Haha, sorry I think this might be a good JS learning side project for me on the weekends if I have free time.

Jan 21 2017, 7:19 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think we should just use actual emoji for this, not sprite sheets?

Jan 21 2017, 7:07 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

tarnation

Jan 21 2017, 7:05 PM · Remarkup, PHUI
chad updated subscribers of T12139: Add a proper emoji picker to Remarkup bar.
In D17238#205025, @epriestley wrote:

Yep, go for it.

Jan 21 2017, 7:00 PM · Remarkup, PHUI
chad updated the task description for T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad created T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:13 AM · Remarkup, PHUI

Jan 14 2017

mpickering added a project to T5698: Github-style Remarkup previews on a checked-in resource: Haskell.org.
Jan 14 2017, 6:19 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Dec 13 2016

epriestley closed T6592: Differential history mangles bullet numbering in quoted email forward as Resolved.

This is extremely old and it's not clear to me which bad cases remain -- I can't immediately find any by fiddling. If any do remain, they haven't turned up again in about two years. If you're still seeing issues, feel free to file a new task with a modern test case.

Dec 13 2016, 12:17 PM · Remarkup

Dec 11 2016

epriestley closed T11980: Links to external systems as Wontfix.
  • Systems integrated with Doorkeeper (JIRA, Asana, some prototype GitHub support) already get URIs marked up.
  • The current JIRA integration does cover JIRA URIs in all remarkup systems, including Phriction and Maniphest, although you can not link to multiple JIRA installs until T6703, and you must use full URIs (if you use JIRA-123, it's possible that multiple linked installs have project namespaces called "JIRA"). It's possible we'll support this more naturally in the future, but not until after T6703, which is a very low priority.
  • Custom markup rules already supported (see P1157, P1209 for some examples), although you're on your own to write them. These are probably the best fit for your use case.
  • I believe needs for this sort of thing are often very specialized, so I do not currently plan to add any kind of generic, configurable remarkup rule that just matches arbitrary regexps against stuff and links them. You could write such a rule as an extension. One caveat to this is that we currently have bugtraq.url and bugtraq.logregex, which sort of work like this, except in a bad way. I'd like to remove them in the future, but there's an outside possibility that we'll replace them with a more flexible system like the one you describe.
Dec 11 2016, 4:56 PM · Remarkup, Feature Request

Dec 9 2016

chad added a comment to T11980: Links to external systems.

Richer integration would likely happen sooner than something like this, simply because it's something we frequently get asked for and benefits a large group of installs.

Dec 9 2016, 8:00 AM · Remarkup, Feature Request
jasonrumney added a comment to T11980: Links to external systems.

I updated the summary to hopefully make the problem description more clear, and to add an additional problem which I encountered on one vendor's custom made bug tracker, where their search was returning URLs that were only temporarily valid in the session that the search was done in.

Dec 9 2016, 7:56 AM · Remarkup, Feature Request
jasonrumney updated the task description for T11980: Links to external systems.
Dec 9 2016, 7:40 AM · Remarkup, Feature Request
chad added a comment to T11980: Links to external systems.

Can you please check out Contributing Feature Requests and Describing Root Problems. We don't accept feature requests of this nature unfortunately without understanding the core problem. For example, external systems in the future could be fully integrated automatically with Phabricator, and make the need for special Remarkup pointless. We're not interested in things that are hypothetically cool or useful, and don't have the bandwidth to pursue specialized requests that can already be accomplished with a small plugin.

Dec 9 2016, 7:05 AM · Remarkup, Feature Request
chad added a comment to T11980: Links to external systems.

You can do this yourself today with a Remarkup Extension. Parse specific URL patterns in remarkup and return them looking however you want.

Dec 9 2016, 6:47 AM · Remarkup, Feature Request
jasonrumney updated the task description for T11980: Links to external systems.
Dec 9 2016, 6:46 AM · Remarkup, Feature Request
jasonrumney created T11980: Links to external systems.
Dec 9 2016, 6:40 AM · Remarkup, Feature Request

Nov 22 2016

epriestley closed T11845: Media with "autoplay" should possibly not autoplay in news feed as Resolved by committing Restricted Diffusion Commit.
Nov 22 2016, 10:20 PM · Prioritized, Remarkup
epriestley added a revision to T11845: Media with "autoplay" should possibly not autoplay in news feed: Restricted Differential Revision.
Nov 22 2016, 10:17 PM · Prioritized, Remarkup

Nov 17 2016

chad closed T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update as Resolved by committing Restricted Diffusion Commit.
Nov 17 2016, 12:35 AM · Remarkup, Design
chad added a revision to T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update: Restricted Differential Revision.
Nov 17 2016, 12:29 AM · Remarkup, Design

Nov 16 2016

OCram added a comment to T11883: Remarkup embedded images doesnt load.

You are right, I also can't reproduce it on the Phacility instance. I really don't know what do do next ^^

Nov 16 2016, 6:31 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report
chad added a comment to T11883: Remarkup embedded images doesnt load.

Please take the time to try to reproduce the issue on a Phacility instance, and report back if you can. We have not been able to reproduce the issue with these set up steps. Reproduction steps must includes everything we need to review and fix the issue locally.

Nov 16 2016, 6:28 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report
OCram updated the task description for T11883: Remarkup embedded images doesnt load.
Nov 16 2016, 6:27 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report
chad merged task T11883: Remarkup embedded images doesnt load into T11785: Clicking on images for lightbox won't load with Persistent Chat enabled.
Nov 16 2016, 6:25 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report
avivey added a project to T11883: Remarkup embedded images doesnt load: Quicksand.
Nov 16 2016, 6:23 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report
chad claimed T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update.
Nov 16 2016, 6:21 PM · Remarkup, Design
epriestley created T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update.
Nov 16 2016, 6:19 PM · Remarkup, Design
OCram created T11883: Remarkup embedded images doesnt load.
Nov 16 2016, 6:11 PM · Quicksand, Remarkup, Files, Conpherence, Bug Report

Nov 14 2016

ReynoldsCahoon added a comment to T11859: Spoiler Tags.

Thank you much, @chad

Nov 14 2016, 7:11 PM · Remarkup, Feature Request
chad added a comment to T11859: Spoiler Tags.

Is a pretty basic one, simple regex / replace. Write your CSS inline.

Nov 14 2016, 7:10 PM · Remarkup, Feature Request
ReynoldsCahoon added a comment to T11859: Spoiler Tags.

Yeah, that seems like a valid solution, however the spoiler in question is still visible, and could get glimpsed at before reading the warning. It'll have to do for now.

Nov 14 2016, 6:58 PM · Remarkup, Feature Request
chad added a comment to T11859: Spoiler Tags.

Putting something like a header maybe could help in the meantime?

Nov 14 2016, 6:54 PM · Remarkup, Feature Request
chad added a comment to T11859: Spoiler Tags.

We don't consider the fact that feature is missing, and would be used, a root problem. Something along the lines of understanding how your company was operationally impacted by seeing/hiding a spoiler would be helpful.

Nov 14 2016, 6:39 PM · Remarkup, Feature Request
ReynoldsCahoon added a comment to T11859: Spoiler Tags.

Strange, I read the Contributing Feature Requests documentation prior to submission, and I figured I'd described the root problem as having revealed content that is context-sensitive with my example of a TV series spoiler. There are potentially more uses outside of TV series spoilers, and I don't think it's any less valid than something like Macros.

Nov 14 2016, 6:27 PM · Remarkup, Feature Request
chad added a comment to T11859: Spoiler Tags.

See Contributing Feature Requests for what information is required in a valid feature request. Specifically this request lacks a root problem and doesn't seem to be about coding / product development. We also can't enforce people knowing when to use such tags, so even having them doesn't really solve the problem of tv show spoilers.

Nov 14 2016, 6:20 PM · Remarkup, Feature Request
chad closed T11859: Spoiler Tags as Wontfix.
Nov 14 2016, 6:12 PM · Remarkup, Feature Request
ReynoldsCahoon created T11859: Spoiler Tags.
Nov 14 2016, 5:45 PM · Remarkup, Feature Request

Nov 10 2016

jcox added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Pretty sure this works as intended

Nov 10 2016, 8:08 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Look at how much engagement we're generating!

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

comments

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

more

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

need

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

still

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I would edit my comment to put a paragraph of text above the autoplay audio, but newsfeed caches the old comment. :3

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I think we can safely conclude that autoplay audio in feed is an effective mechanism for disseminating important information.

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad moved T11845: Media with "autoplay" should possibly not autoplay in news feed from Backlog to Rugged Terrain on the Prioritized board.
Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad added a project to T11845: Media with "autoplay" should possibly not autoplay in news feed: Prioritized.
Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad raised the priority of T11845: Media with "autoplay" should possibly not autoplay in news feed from Low to High.
Nov 10 2016, 8:03 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Sure seems to be a lot of activity that generates feed stories on this task!

Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

@epriestley FYI

Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad assigned T11845: Media with "autoplay" should possibly not autoplay in news feed to epriestley.
Nov 10 2016, 8:02 PM · Prioritized, Remarkup
epriestley created T11845: Media with "autoplay" should possibly not autoplay in news feed.
Nov 10 2016, 7:48 PM · Prioritized, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.
  • Prototype applications must be enabled.
  • security.outbound-blacklist must not blacklist the target server (build servers may be on an internal network and on the default blacklist).
  • The link protocol must be "http" or "https".
  • You must not have exceeded your fetch quota for the last hour.
  • You must have file storage configured.
  • The image MIME type must be part of files.image-mime-types and files.viewable-mime-types.
  • The Phabricator server must be able to make outbound requests on the network.
Nov 10 2016, 2:57 PM · Contributor Onboarding, Remarkup
nochum added a comment to T4190: Rebuild remarkup image proxying.

(But note that it's cached for a trillion years, so it won't work for build status.)

Nov 10 2016, 2:53 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.
{img https://static-cdn.jtvnw.net/jtv_user_pictures/doritos-profile_image-4328d01909178d94-300x300.png}
Nov 10 2016, 2:51 PM · Contributor Onboarding, Remarkup
nochum added a comment to T4190: Rebuild remarkup image proxying.

Does the {img } thing work yet? I've been trying to use it locally but have not been able to get it to actually show an image. This would be super useful for us to be able to show the build status on a remarkup page (like the README.MD of our repo, for example). Thanks.

Nov 10 2016, 2:49 PM · Contributor Onboarding, Remarkup

Nov 6 2016

epriestley merged task T11825: Prose diffs unusable for changes with large blocks of unmodified text into T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 6 2016, 9:08 PM · Remarkup, Bug Report
chad edited projects for T11825: Prose diffs unusable for changes with large blocks of unmodified text, added: Remarkup; removed Phriction.
Nov 6 2016, 8:58 PM · Remarkup, Bug Report

Oct 20 2016

chad added a comment to T11776: Remarkup extensions with JS/CSS dependencies.

For reference, http://phacility.com/ is a Phabricator application itself, so think all the tools are available.

Oct 20 2016, 7:04 PM · Remarkup, Feature Request
chad closed T11776: Remarkup extensions with JS/CSS dependencies as Resolved.

I presume you meant to ask this question in Ponder, otherwise please see Contributing Feature Requests for what information is required in a feature request. Generally, we do not provide support for building applications/plugins/extensions against Phabricator.

Oct 20 2016, 7:00 PM · Remarkup, Feature Request
alex3d created T11776: Remarkup extensions with JS/CSS dependencies.
Oct 20 2016, 6:45 PM · Remarkup, Feature Request

Oct 7 2016

epriestley added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

T11747 wants a more advanced version of this (reviewing diffs between rendered documents), although the specific document type it wants (IPython notebooks) is likely very complex to render.

Oct 7 2016, 6:19 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley merged T11747: Viewing support for ipython notebooks in differential into T5698: Github-style Remarkup previews on a checked-in resource.
Oct 7 2016, 6:17 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Oct 4 2016

• LisaPrichard added a comment to T11284: Allow line breaks in list items.
Oct 4 2016, 12:16 PM · Remarkup

Oct 3 2016

Nickery3 added a comment to T11609: Don't resize small pictures in Remarkup.

What about display images set like this?

Oct 3 2016, 10:53 AM · Remarkup

Sep 29 2016

eadler added a project to T11641: The at-mention of a disabled user renders a line instead of a dot for inline comments: Restricted Project.
Sep 29 2016, 6:30 PM · Restricted Project, Remarkup, Bug Report

Sep 27 2016

epriestley added a comment to T4190: Rebuild remarkup image proxying.

(I'll follow up on this once I have a chance to bang on it a bit, but I want to try to finish up the RRULE stuff while it's still somewhat fresh in my mind.)

Sep 27 2016, 5:03 PM · Contributor Onboarding, Remarkup

Sep 26 2016

jcox added a revision to T4190: Rebuild remarkup image proxying: Restricted Differential Revision.
Sep 26 2016, 2:01 PM · Contributor Onboarding, Remarkup

Sep 23 2016

epriestley added a comment to T4190: Rebuild remarkup image proxying.

To actually add a remarkup rule, the basics are simple:

Sep 23 2016, 1:28 PM · Contributor Onboarding, Remarkup

Sep 22 2016

epriestley reopened T9896: make images from comments visible in email as "Open".

I think this didn't actually get handled in T10262, but should be doable now.

Sep 22 2016, 10:12 PM · Restricted Project, Remarkup, Mail
avivey added a comment to T9896: make images from comments visible in email.

Did this ever actually work? it looks like we're still embedding links:

pasted_file (127×363 px, 7 KB)

Sep 22 2016, 10:06 PM · Restricted Project, Remarkup, Mail

Sep 21 2016

epriestley added a comment to T4190: Rebuild remarkup image proxying.

On the cache:

Sep 21 2016, 3:38 PM · Contributor Onboarding, Remarkup
jcox added a revision to T4190: Rebuild remarkup image proxying: Restricted Differential Revision.
Sep 21 2016, 2:02 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

In this case, use the AphrontWriteGuard::beginScopedUnguardedWrites() method to surround the block -- you can grep for usage, but it will look like this:

Sep 21 2016, 1:15 PM · Contributor Onboarding, Remarkup
jcox added a comment to T4190: Rebuild remarkup image proxying.

I've got the endpoint and controller set up, but I get the following error when I call PhabricatorFile::newFromFileDownload:

Sep 21 2016, 1:12 PM · Contributor Onboarding, Remarkup

Sep 20 2016

jcox added a comment to T9900: Figlet does not properly render apostrophes with some characters.

Alright I've been able to narrow this down a little bit more. There's some error with how external/pear-figlet/Text/Figlet.php is smushing characters. Specifically lines 339-362 as well as the _rep($r) function. The equivalent function in the C code is here. I haven't been able to find an obvious discrepancy, but I suspect there's a subtle difference in how one of the regex functions is handling things or an error in one of the regexes themselves. This error also occurs with backticks and double-quotes:

Sep 20 2016, 5:08 PM · Contributor Onboarding, Remarkup

Sep 19 2016

epriestley renamed T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Remarkup navigation component is not able to have text starting with equals sign to Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.
Sep 19 2016, 9:44 PM · Documentation, Remarkup
cspeckmim added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

Ohhh nice, thank you I missed that
=C124

Sep 19 2016, 9:32 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

And you can technically:

Sep 19 2016, 9:32 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

Oh, right. That works, but I think isn't documented:

Sep 19 2016, 9:31 PM · Documentation, Remarkup
cspeckmim added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

It's an off-case for sure. We have a ton of data identifiers which all end with an equals-sign and a couple letters/numbers, which we abbreviate when referring to the datasets. I was actually trying to render the equals sign as part of the nav sequence and not just C124.

Sep 19 2016, 9:30 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

We could conceivably special-case this since setting an empty attribute to a value isn't meaningful, I suppose.

Sep 19 2016, 9:25 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.
{nav name=C124}
Sep 19 2016, 9:24 PM · Documentation, Remarkup
cspeckmim created T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.
Sep 19 2016, 9:04 PM · Documentation, Remarkup

Sep 15 2016

chad added a comment to T11641: The at-mention of a disabled user renders a line instead of a dot for inline comments.

.remarkup-code td span

Sep 15 2016, 6:13 PM · Restricted Project, Remarkup, Bug Report
eadler added a project to T9720: Provide a way to link to Diffusion files: Restricted Project.
Sep 15 2016, 6:08 PM · Restricted Project, Remarkup
eadler added a project to T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment: Restricted Project.
Sep 15 2016, 6:03 PM · Restricted Project, Remarkup, Feature Request
cspeckmim created T11641: The at-mention of a disabled user renders a line instead of a dot for inline comments.
Sep 15 2016, 3:46 PM · Restricted Project, Remarkup, Bug Report

Sep 10 2016

kristo.mario added a comment to T11612: Remarkup - Support rendering of iterative expressions.

Good to know. :) I think that embedding panels is enough. It did not occur to me that I can do that, much cool. :)

Sep 10 2016, 1:52 PM · Remarkup, Feature Request
chad added a comment to T11612: Remarkup - Support rendering of iterative expressions.

I think if you really want the table layout you can extend and build your own Dashboard Panel Redererer, then wire up to any query and embed away.

Sep 10 2016, 1:42 PM · Remarkup, Feature Request
kristo.mario added a comment to T11612: Remarkup - Support rendering of iterative expressions.

Good catch, thanks.

Sep 10 2016, 1:40 PM · Remarkup, Feature Request
chad closed T11612: Remarkup - Support rendering of iterative expressions as Wontfix.

You can embed Dashboard Panels already today into other documents. These are based on any query you build in any supporting application. Beyond that you will need to wait for Facts for something more data-like.

Sep 10 2016, 1:37 PM · Remarkup, Feature Request
kristo.mario created T11612: Remarkup - Support rendering of iterative expressions.
Sep 10 2016, 1:13 PM · Remarkup, Feature Request
joshuaspence renamed T11609: Don't resize small pictures in Remarkup from don't resize small pictures in remarkup to Don't resize small pictures in Remarkup.
Sep 10 2016, 12:38 AM · Remarkup